blob: d6028a237bc37b05247275b6adcfb0fa623c3b42 [file] [log] [blame]
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001/* A Media Gateway Control Protocol Media Gateway: RFC 3435 */
2/* The protocol implementation */
3
4/*
5 * (C) 2009-2012 by Holger Hans Peter Freyther <zecke@selfish.org>
6 * (C) 2009-2012 by On-Waves
7 * All Rights Reserved
8 *
9 * This program is free software; you can redistribute it and/or modify
10 * it under the terms of the GNU Affero General Public License as published by
11 * the Free Software Foundation; either version 3 of the License, or
12 * (at your option) any later version.
13 *
14 * This program is distributed in the hope that it will be useful,
15 * but WITHOUT ANY WARRANTY; without even the implied warranty of
16 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
17 * GNU Affero General Public License for more details.
18 *
19 * You should have received a copy of the GNU Affero General Public License
20 * along with this program. If not, see <http://www.gnu.org/licenses/>.
21 *
22 */
23
24#include <string.h>
25#include <stdlib.h>
26#include <unistd.h>
27#include <errno.h>
28#include <time.h>
29#include <limits.h>
Neels Hofmeyrf83ec562017-09-07 19:18:40 +020030#include <arpa/inet.h>
31
32#include <osmocom/core/msgb.h>
33#include <osmocom/core/select.h>
Philipp Maier1cb1e382017-11-02 17:16:04 +010034#include <osmocom/core/socket.h>
Philipp Maier4dba7692018-08-03 12:20:52 +020035#include <osmocom/core/byteswap.h>
Neels Hofmeyrf83ec562017-09-07 19:18:40 +020036#include <osmocom/netif/rtp.h>
Philipp Maier228e5912019-03-05 13:56:59 +010037#include <osmocom/netif/amr.h>
Philipp Maier87bd9be2017-08-22 16:35:41 +020038#include <osmocom/mgcp/mgcp.h>
Neels Hofmeyr67793542017-09-08 04:25:16 +020039#include <osmocom/mgcp/mgcp_common.h>
Philipp Maier993ea6b2020-08-04 18:26:50 +020040#include <osmocom/mgcp/mgcp_network.h>
41#include <osmocom/mgcp/mgcp_protocol.h>
Philipp Maier87bd9be2017-08-22 16:35:41 +020042#include <osmocom/mgcp/mgcp_stat.h>
43#include <osmocom/mgcp/osmux.h>
44#include <osmocom/mgcp/mgcp_conn.h>
Philipp Maier37d11c82018-02-01 14:38:12 +010045#include <osmocom/mgcp/mgcp_endp.h>
Philipp Maierc66ab2c2020-06-02 20:55:34 +020046#include <osmocom/mgcp/mgcp_trunk.h>
Philipp Maier6931f9a2018-07-26 09:29:31 +020047#include <osmocom/mgcp/mgcp_codec.h>
Philipp Maierc3413882017-10-27 12:26:54 +020048#include <osmocom/mgcp/debug.h>
Philipp Maier9fc8a022019-02-20 12:26:52 +010049#include <osmocom/codec/codec.h>
Philipp Maier889fe7f2020-07-06 17:44:12 +020050#include <osmocom/mgcp/mgcp_e1.h>
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +010051#include <osmocom/mgcp/mgcp_iuup.h>
Philipp Maier993ea6b2020-08-04 18:26:50 +020052
Neels Hofmeyrf83ec562017-09-07 19:18:40 +020053#define RTP_SEQ_MOD (1 << 16)
54#define RTP_MAX_DROPOUT 3000
55#define RTP_MAX_MISORDER 100
Neels Hofmeyrf83ec562017-09-07 19:18:40 +020056
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +010057void rtpconn_rate_ctr_add(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp,
Harald Weltea48ff4a2020-03-08 14:45:08 +010058 int id, int inc)
59{
Pau Espin Pedroldaf5bce2022-09-22 19:14:24 +020060 struct rate_ctr_group *conn_stats = conn_rtp->ctrg;
Philipp Maierc66ab2c2020-06-02 20:55:34 +020061 struct rate_ctr_group *mgw_stats = endp->trunk->ratectr.all_rtp_conn_stats;
Harald Weltea48ff4a2020-03-08 14:45:08 +010062
Philipp Maierc66ab2c2020-06-02 20:55:34 +020063 /* add to both the per-connection and the global stats */
Pau Espin Pedrol907744e2021-06-04 17:57:34 +020064 rate_ctr_add(rate_ctr_group_get_ctr(conn_stats, id), inc);
65 rate_ctr_add(rate_ctr_group_get_ctr(mgw_stats, id), inc);
Harald Weltea48ff4a2020-03-08 14:45:08 +010066}
67
Pau Espin Pedrol582c2bf2022-09-22 17:53:44 +020068void rtpconn_rate_ctr_inc(struct mgcp_conn_rtp *conn_rtp, struct mgcp_endpoint *endp, int id)
Harald Weltea48ff4a2020-03-08 14:45:08 +010069{
70 rtpconn_rate_ctr_add(conn_rtp, endp, id, 1);
71}
72
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +020073static int rx_rtp(struct msgb *msg);
74
Pau Espin Pedrolca280a12021-07-06 18:15:35 +020075bool mgcp_rtp_end_remote_addr_available(const struct mgcp_rtp_end *rtp_end)
76{
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +020077 return (osmo_sockaddr_port(&rtp_end->addr.u.sa) != 0) &&
78 (osmo_sockaddr_is_any(&rtp_end->addr) == 0);
Pau Espin Pedrolca280a12021-07-06 18:15:35 +020079}
80
Philipp Maier1cb1e382017-11-02 17:16:04 +010081/*! Determine the local rtp bind IP-address.
Philipp Maier0b79d212020-06-18 12:02:49 +020082 * \param[out] addr caller provided memory to store the resulting IP-Address.
83 * \param[in] endp mgcp endpoint, that holds a copy of the VTY parameters.
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +020084 * \ returns 0 on success, -1 if no local address could be provided.
Philipp Maier1cb1e382017-11-02 17:16:04 +010085 *
86 * The local bind IP-address is automatically selected by probing the
87 * IP-Address of the interface that is pointing towards the remote IP-Address,
88 * if no remote IP-Address is known yet, the statically configured
89 * IP-Addresses are used as fallback. */
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +020090int mgcp_get_local_addr(char *addr, struct mgcp_conn_rtp *conn)
Philipp Maier1cb1e382017-11-02 17:16:04 +010091{
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +020092 const struct mgcp_endpoint *endp = conn->conn->endp;
93 const struct mgcp_config *cfg = endp->trunk->cfg;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +020094 char ipbuf[INET6_ADDRSTRLEN];
Philipp Maier1cb1e382017-11-02 17:16:04 +010095 int rc;
Pau Espin Pedrol051eb4d2022-10-04 12:50:28 +020096 bool rem_addr_set = osmo_sockaddr_is_any(&conn->end.addr) == 0;
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +020097 const char *bind_addr;
Philipp Maier1cb1e382017-11-02 17:16:04 +010098
Pau Espin Pedrol479cf762022-09-07 19:42:54 +020099 /* Osmux: No smart IP addresses allocation is supported yet. Simply
100 * return the one set in VTY config: */
101 if (mgcp_conn_rtp_is_osmux(conn)) {
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200102 if (rem_addr_set) {
103 /* Match IP version with what was requested from remote: */
104 bind_addr = conn->end.addr.u.sa.sa_family == AF_INET6 ?
Pau Espin Pedrol36413c02022-10-12 17:58:17 +0200105 cfg->osmux.local_addr_v6 :
106 cfg->osmux.local_addr_v4;
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200107 } else {
108 /* Choose any of the bind addresses, preferring v6 over v4 if available: */
Pau Espin Pedrol36413c02022-10-12 17:58:17 +0200109 bind_addr = cfg->osmux.local_addr_v6;
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200110 if (!bind_addr)
Pau Espin Pedrol36413c02022-10-12 17:58:17 +0200111 bind_addr = cfg->osmux.local_addr_v4;
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200112 }
113 if (!bind_addr) {
114 LOGPCONN(conn->conn, DOSMUX, LOGL_ERROR,
115 "Unable to locate local Osmux address, check your configuration! v4=%u v6=%u remote_known=%s\n",
Pau Espin Pedrol36413c02022-10-12 17:58:17 +0200116 !!cfg->osmux.local_addr_v4,
117 !!cfg->osmux.local_addr_v6,
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200118 rem_addr_set ? osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf) : "no");
119 return -1;
120 }
121 LOGPCONN(conn->conn, DOSMUX, LOGL_DEBUG,
122 "Using configured osmux bind ip as local bind ip %s\n",
Pau Espin Pedrol479cf762022-09-07 19:42:54 +0200123 bind_addr);
124 osmo_strlcpy(addr, bind_addr, INET6_ADDRSTRLEN);
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200125 return 0;
Pau Espin Pedrol479cf762022-09-07 19:42:54 +0200126 }
127
Philipp Maier1cb1e382017-11-02 17:16:04 +0100128 /* Try probing the local IP-Address */
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +0200129 if (cfg->net_ports.bind_addr_probe && rem_addr_set) {
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200130 rc = osmo_sock_local_ip(addr, osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));
Philipp Maier1cb1e382017-11-02 17:16:04 +0100131 if (rc < 0)
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200132 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
133 "local interface auto detection failed, using configured addresses...\n");
Philipp Maier1cb1e382017-11-02 17:16:04 +0100134 else {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200135 LOGPCONN(conn->conn, DRTP, LOGL_DEBUG,
136 "selected local rtp bind ip %s by probing using remote ip %s\n",
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200137 addr, osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200138 return 0;
Philipp Maier1cb1e382017-11-02 17:16:04 +0100139 }
140 }
141
Pau Espin Pedrol479cf762022-09-07 19:42:54 +0200142 /* Select from preconfigured IP-Addresses. */
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200143 if (rem_addr_set) {
Philipp Maier1cb1e382017-11-02 17:16:04 +0100144 /* Check there is a bind IP for the RTP traffic configured,
145 * if so, use that IP-Address */
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200146 bind_addr = conn->end.addr.u.sa.sa_family == AF_INET6 ?
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +0200147 cfg->net_ports.bind_addr_v6 :
148 cfg->net_ports.bind_addr_v4;
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200149 } else {
150 /* Choose any of the bind addresses, preferring v6 over v4 */
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +0200151 bind_addr = cfg->net_ports.bind_addr_v6;
Eric2764bdb2021-08-23 22:11:47 +0200152 if (!strlen(bind_addr))
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +0200153 bind_addr = cfg->net_ports.bind_addr_v4;
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200154 }
Eric2764bdb2021-08-23 22:11:47 +0200155 if (strlen(bind_addr)) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200156 LOGPCONN(conn->conn, DRTP, LOGL_DEBUG,
157 "using configured rtp bind ip as local bind ip %s\n",
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200158 bind_addr);
Philipp Maier1cb1e382017-11-02 17:16:04 +0100159 } else {
160 /* No specific bind IP is configured for the RTP traffic, so
161 * assume the IP where we listen for incoming MGCP messages
162 * as bind IP */
Pau Espin Pedrol654b68d2022-10-05 10:37:49 +0200163 bind_addr = cfg->source_addr;
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200164 LOGPCONN(conn->conn, DRTP, LOGL_DEBUG,
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200165 "using mgcp bind ip as local rtp bind ip: %s\n", bind_addr);
Philipp Maier1cb1e382017-11-02 17:16:04 +0100166 }
Pau Espin Pedrol8a2a1b22020-09-02 20:46:24 +0200167 osmo_strlcpy(addr, bind_addr, INET6_ADDRSTRLEN);
Pau Espin Pedrol70c03f52022-10-04 16:49:41 +0200168 return 0;
Philipp Maier1cb1e382017-11-02 17:16:04 +0100169}
170
Philipp Maier87bd9be2017-08-22 16:35:41 +0200171/* This does not need to be a precision timestamp and
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200172 * is allowed to wrap quite fast. The returned value is
Philipp Maier87bd9be2017-08-22 16:35:41 +0200173 * 1/codec_rate seconds. */
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +0100174uint32_t mgcp_get_current_ts(unsigned codec_rate)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200175{
176 struct timespec tp;
177 uint64_t ret;
178
Philipp Maier87bd9be2017-08-22 16:35:41 +0200179 if (!codec_rate)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200180 return 0;
181
182 memset(&tp, 0, sizeof(tp));
183 if (clock_gettime(CLOCK_MONOTONIC, &tp) != 0)
Philipp Maierc3413882017-10-27 12:26:54 +0200184 LOGP(DRTP, LOGL_NOTICE, "Getting the clock failed.\n");
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200185
186 /* convert it to 1/unit seconds */
187 ret = tp.tv_sec;
Philipp Maier87bd9be2017-08-22 16:35:41 +0200188 ret *= codec_rate;
189 ret += (int64_t) tp.tv_nsec * codec_rate / 1000 / 1000 / 1000;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200190
191 return ret;
192}
193
Philipp Maier87bd9be2017-08-22 16:35:41 +0200194/* Compute timestamp alignment error */
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200195static int32_t ts_alignment_error(const struct mgcp_rtp_stream_state *sstate,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200196 int ptime, uint32_t timestamp)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200197{
198 int32_t timestamp_delta;
199
200 if (ptime == 0)
201 return 0;
202
203 /* Align according to: T - Tlast = k * Tptime */
204 timestamp_delta = timestamp - sstate->last_timestamp;
205
206 return timestamp_delta % ptime;
207}
208
Philipp Maier87bd9be2017-08-22 16:35:41 +0200209/* Check timestamp and sequence number for plausibility */
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200210static int check_rtp_timestamp(const struct mgcp_endpoint *endp,
211 const struct mgcp_rtp_state *state,
212 const struct mgcp_rtp_stream_state *sstate,
213 const struct mgcp_rtp_end *rtp_end,
214 const struct osmo_sockaddr *addr,
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200215 uint16_t seq, uint32_t timestamp,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200216 const char *text, int32_t * tsdelta_out)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200217{
218 int32_t tsdelta;
219 int32_t timestamp_error;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200220 char ipbuf[INET6_ADDRSTRLEN];
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200221
222 /* Not fully intialized, skip */
223 if (sstate->last_tsdelta == 0 && timestamp == sstate->last_timestamp)
224 return 0;
225
226 if (seq == sstate->last_seq) {
227 if (timestamp != sstate->last_timestamp) {
Philipp Maier9e1d1642018-05-09 16:26:34 +0200228 rate_ctr_inc(sstate->err_ts_ctr);
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200229 LOGPENDP(endp, DRTP, LOGL_ERROR,
230 "The %s timestamp delta is != 0 but the sequence "
231 "number %d is the same, "
232 "TS offset: %d, SeqNo offset: %d "
233 "on SSRC: %u timestamp: %u "
234 "from %s:%d\n",
235 text, seq,
236 state->patch.timestamp_offset, state->patch.seq_offset,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200237 sstate->ssrc, timestamp,
238 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
239 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200240 }
241 return 0;
242 }
243
244 tsdelta =
Philipp Maier87bd9be2017-08-22 16:35:41 +0200245 (int32_t)(timestamp - sstate->last_timestamp) /
246 (int16_t)(seq - sstate->last_seq);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200247
248 if (tsdelta == 0) {
249 /* Don't update *tsdelta_out */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200250 LOGPENDP(endp, DRTP, LOGL_NOTICE,
251 "The %s timestamp delta is %d "
252 "on SSRC: %u timestamp: %u "
253 "from %s:%d\n",
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200254 text, tsdelta, sstate->ssrc, timestamp,
255 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
256 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200257
258 return 0;
259 }
260
261 if (sstate->last_tsdelta != tsdelta) {
262 if (sstate->last_tsdelta) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200263 LOGPENDP(endp, DRTP, LOGL_INFO,
264 "The %s timestamp delta changes from %d to %d "
265 "on SSRC: %u timestamp: %u from %s:%d\n",
266 text, sstate->last_tsdelta, tsdelta,
267 sstate->ssrc, timestamp,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200268 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
269 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200270 }
271 }
272
273 if (tsdelta_out)
274 *tsdelta_out = tsdelta;
275
276 timestamp_error =
Philipp Maier87bd9be2017-08-22 16:35:41 +0200277 ts_alignment_error(sstate, state->packet_duration, timestamp);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200278
279 if (timestamp_error) {
Philipp Maier9e1d1642018-05-09 16:26:34 +0200280 rate_ctr_inc(sstate->err_ts_ctr);
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200281 LOGPENDP(endp, DRTP, LOGL_NOTICE,
282 "The %s timestamp has an alignment error of %d "
283 "on SSRC: %u "
284 "SeqNo delta: %d, TS delta: %d, dTS/dSeq: %d "
285 "from %s:%d. ptime: %d\n",
286 text, timestamp_error,
287 sstate->ssrc,
288 (int16_t)(seq - sstate->last_seq),
289 (int32_t)(timestamp - sstate->last_timestamp),
290 tsdelta,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200291 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
292 osmo_sockaddr_port(&addr->u.sa),
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200293 state->packet_duration);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200294 }
295 return 1;
296}
297
298/* Set the timestamp offset according to the packet duration. */
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200299static int adjust_rtp_timestamp_offset(const struct mgcp_endpoint *endp,
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200300 struct mgcp_rtp_state *state,
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200301 const struct mgcp_rtp_end *rtp_end,
302 const struct osmo_sockaddr *addr,
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200303 int16_t delta_seq, uint32_t in_timestamp,
304 bool marker_bit)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200305{
306 int32_t tsdelta = state->packet_duration;
307 int timestamp_offset;
308 uint32_t out_timestamp;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200309 char ipbuf[INET6_ADDRSTRLEN];
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200310
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200311 if (marker_bit) {
312 /* If RTP pkt contains marker bit, the timestamps are not longer
313 * in sync, so we can erase timestamp offset patching. */
314 state->patch.timestamp_offset = 0;
315 return 0;
316 }
317
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200318 if (tsdelta == 0) {
319 tsdelta = state->out_stream.last_tsdelta;
320 if (tsdelta != 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200321 LOGPENDP(endp, DRTP, LOGL_NOTICE,
322 "A fixed packet duration is not available, "
323 "using last output timestamp delta instead: %d "
324 "from %s:%d\n", tsdelta,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200325 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
326 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200327 } else {
Philipp Maierbc0346e2018-06-07 09:52:16 +0200328 tsdelta = rtp_end->codec->rate * 20 / 1000;
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200329 LOGPENDP(endp, DRTP, LOGL_NOTICE,
330 "Fixed packet duration and last timestamp delta "
331 "are not available, "
332 "using fixed 20ms instead: %d "
333 "from %s:%d\n", tsdelta,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200334 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
335 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200336 }
337 }
338
339 out_timestamp = state->out_stream.last_timestamp + delta_seq * tsdelta;
340 timestamp_offset = out_timestamp - in_timestamp;
341
Harald Welte33381352017-12-25 09:44:26 +0100342 if (state->patch.timestamp_offset != timestamp_offset) {
343 state->patch.timestamp_offset = timestamp_offset;
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200344 LOGPENDP(endp, DRTP, LOGL_NOTICE,
345 "Timestamp offset change on SSRC: %u "
346 "SeqNo delta: %d, TS offset: %d, "
347 "from %s:%d\n", state->in_stream.ssrc,
348 delta_seq, state->patch.timestamp_offset,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200349 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
350 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200351 }
352
353 return timestamp_offset;
354}
355
356/* Set the timestamp offset according to the packet duration. */
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200357static int align_rtp_timestamp_offset(const struct mgcp_endpoint *endp,
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200358 struct mgcp_rtp_state *state,
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200359 const struct mgcp_rtp_end *rtp_end,
360 const struct osmo_sockaddr *addr,
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200361 uint32_t timestamp, bool marker_bit)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200362{
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200363 char ipbuf[INET6_ADDRSTRLEN];
Philipp Maier87bd9be2017-08-22 16:35:41 +0200364 int ts_error = 0;
365 int ts_check = 0;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200366 int ptime = state->packet_duration;
367
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200368 if (marker_bit) {
369 /* If RTP pkt contains marker bit, the timestamps are not longer
370 * in sync, so no alignment is needed. */
371 return 0;
372 }
373
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200374 /* Align according to: T + Toffs - Tlast = k * Tptime */
375
Philipp Maier87bd9be2017-08-22 16:35:41 +0200376 ts_error = ts_alignment_error(&state->out_stream, ptime,
Harald Welte33381352017-12-25 09:44:26 +0100377 timestamp + state->patch.timestamp_offset);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200378
Philipp Maier87bd9be2017-08-22 16:35:41 +0200379 /* If there is an alignment error, we have to compensate it */
380 if (ts_error) {
Harald Welte33381352017-12-25 09:44:26 +0100381 state->patch.timestamp_offset += ptime - ts_error;
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200382 LOGPENDP(endp, DRTP, LOGL_NOTICE,
383 "Corrected timestamp alignment error of %d on SSRC: %u "
384 "new TS offset: %d, "
385 "from %s:%d\n",
386 ts_error, state->in_stream.ssrc,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200387 state->patch.timestamp_offset,
388 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
389 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200390 }
391
Philipp Maier87bd9be2017-08-22 16:35:41 +0200392 /* Check we really managed to compensate the timestamp
393 * offset. There should not be any remaining error, failing
Harald Welte1d1b98f2017-12-25 10:03:40 +0100394 * here would point to a serous problem with the alignment
395 * error computation function */
Philipp Maier87bd9be2017-08-22 16:35:41 +0200396 ts_check = ts_alignment_error(&state->out_stream, ptime,
Harald Welte33381352017-12-25 09:44:26 +0100397 timestamp + state->patch.timestamp_offset);
Philipp Maier87bd9be2017-08-22 16:35:41 +0200398 OSMO_ASSERT(ts_check == 0);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200399
Philipp Maier87bd9be2017-08-22 16:35:41 +0200400 /* Return alignment error before compensation */
401 return ts_error;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200402}
403
Philipp Maier87bd9be2017-08-22 16:35:41 +0200404/*! dummy callback to disable transcoding (see also cfg->rtp_processing_cb).
Philipp Maier0b79d212020-06-18 12:02:49 +0200405 * \param[in] associated endpoint.
406 * \param[in] destination RTP end.
407 * \param[in,out] pointer to buffer with voice data.
408 * \param[in] voice data length.
409 * \param[in] maximum size of caller provided voice data buffer.
410 * \returns ignores input parameters, return always 0. */
Philipp Maier87bd9be2017-08-22 16:35:41 +0200411int mgcp_rtp_processing_default(struct mgcp_endpoint *endp,
412 struct mgcp_rtp_end *dst_end,
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200413 char *data, int *len, int buf_size)
414{
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200415 LOGPENDP(endp, DRTP, LOGL_DEBUG, "transcoding disabled\n");
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200416 return 0;
417}
418
Philipp Maier87bd9be2017-08-22 16:35:41 +0200419/*! dummy callback to disable transcoding (see also cfg->setup_rtp_processing_cb).
Philipp Maier0b79d212020-06-18 12:02:49 +0200420 * \param[in] associated endpoint.
421 * \param[in] destination RTP connnection.
422 * \param[in] source RTP connection.
423 * \returns ignores input parameters, return always 0. */
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200424int mgcp_setup_rtp_processing_default(struct mgcp_endpoint *endp,
Philipp Maieracc10352018-07-19 18:07:57 +0200425 struct mgcp_conn_rtp *conn_dst,
426 struct mgcp_conn_rtp *conn_src)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200427{
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200428 LOGPENDP(endp, DRTP, LOGL_DEBUG, "transcoding disabled\n");
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200429 return 0;
430}
431
432void mgcp_get_net_downlink_format_default(struct mgcp_endpoint *endp,
Philipp Maier58128252019-03-06 11:28:18 +0100433 const struct mgcp_rtp_codec **codec,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200434 const char **fmtp_extra,
435 struct mgcp_conn_rtp *conn)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200436{
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200437 LOGPENDP(endp, DRTP, LOGL_DEBUG, "conn:%s using format defaults\n",
438 mgcp_conn_dump(conn->conn));
Philipp Maier87bd9be2017-08-22 16:35:41 +0200439
Philipp Maier58128252019-03-06 11:28:18 +0100440 *codec = conn->end.codec;
Philipp Maier87bd9be2017-08-22 16:35:41 +0200441 *fmtp_extra = conn->end.fmtp_extra;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200442}
443
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200444void mgcp_rtp_annex_count(const struct mgcp_endpoint *endp,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200445 struct mgcp_rtp_state *state, const uint16_t seq,
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200446 const int32_t transit, const uint32_t ssrc,
447 const bool marker_bit)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200448{
449 int32_t d;
450
451 /* initialize or re-initialize */
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200452 if (!state->stats.initialized || state->stats.ssrc != ssrc || marker_bit) {
Harald Welte49e3d5a2017-12-25 09:47:57 +0100453 state->stats.initialized = 1;
454 state->stats.base_seq = seq;
455 state->stats.max_seq = seq - 1;
456 state->stats.ssrc = ssrc;
457 state->stats.jitter = 0;
458 state->stats.transit = transit;
459 state->stats.cycles = 0;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200460 } else {
461 uint16_t udelta;
462
Philipp Maier87bd9be2017-08-22 16:35:41 +0200463 /* The below takes the shape of the validation of
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200464 * Appendix A. Check if there is something weird with
465 * the sequence number, otherwise check for a wrap
466 * around in the sequence number.
467 * It can't wrap during the initialization so let's
468 * skip it here. The Appendix A probably doesn't have
Philipp Maier87bd9be2017-08-22 16:35:41 +0200469 * this issue because of the probation. */
Harald Welte49e3d5a2017-12-25 09:47:57 +0100470 udelta = seq - state->stats.max_seq;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200471 if (udelta < RTP_MAX_DROPOUT) {
Harald Welte49e3d5a2017-12-25 09:47:57 +0100472 if (seq < state->stats.max_seq)
473 state->stats.cycles += RTP_SEQ_MOD;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200474 } else if (udelta <= RTP_SEQ_MOD - RTP_MAX_MISORDER) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200475 LOGPENDP(endp, DRTP, LOGL_NOTICE,
476 "RTP seqno made a very large jump on delta: %u\n",
477 udelta);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200478 }
479 }
480
Philipp Maier87bd9be2017-08-22 16:35:41 +0200481 /* Calculate the jitter between the two packages. The TS should be
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200482 * taken closer to the read function. This was taken from the
483 * Appendix A of RFC 3550. Timestamp and arrival_time have a 1/rate
Philipp Maier87bd9be2017-08-22 16:35:41 +0200484 * resolution. */
Harald Welte49e3d5a2017-12-25 09:47:57 +0100485 d = transit - state->stats.transit;
486 state->stats.transit = transit;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200487 if (d < 0)
488 d = -d;
Harald Welte49e3d5a2017-12-25 09:47:57 +0100489 state->stats.jitter += d - ((state->stats.jitter + 8) >> 4);
490 state->stats.max_seq = seq;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200491}
492
Philipp Maier6931f9a2018-07-26 09:29:31 +0200493/* There may be different payload type numbers negotiated for two connections.
494 * Patch the payload type of an RTP packet so that it uses the payload type
495 * that is valid for the destination connection (conn_dst) */
496static int mgcp_patch_pt(struct mgcp_conn_rtp *conn_src,
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200497 struct mgcp_conn_rtp *conn_dst, struct msgb *msg)
Philipp Maier6931f9a2018-07-26 09:29:31 +0200498{
499 struct rtp_hdr *rtp_hdr;
500 uint8_t pt_in;
501 int pt_out;
502
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200503 if (msgb_length(msg) < sizeof(struct rtp_hdr)) {
504 LOG_CONN_RTP(conn_src, LOGL_ERROR, "RTP packet too short (%u < %zu)\n",
505 msgb_length(msg), sizeof(struct rtp_hdr));
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200506 return -EINVAL;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200507 }
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200508
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200509 rtp_hdr = (struct rtp_hdr *)msgb_data(msg);
Philipp Maier6931f9a2018-07-26 09:29:31 +0200510
511 pt_in = rtp_hdr->payload_type;
512 pt_out = mgcp_codec_pt_translate(conn_src, conn_dst, pt_in);
513 if (pt_out < 0)
514 return -EINVAL;
515
516 rtp_hdr->payload_type = (uint8_t) pt_out;
517 return 0;
518}
519
Philipp Maier87bd9be2017-08-22 16:35:41 +0200520/* The RFC 3550 Appendix A assumes there are multiple sources but
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200521 * some of the supported endpoints (e.g. the nanoBTS) can only handle
522 * one source and this code will patch RTP header to appear as if there
523 * is only one source.
524 * There is also no probation period for new sources. Every RTP header
Philipp Maier87bd9be2017-08-22 16:35:41 +0200525 * we receive will be seen as a switch in streams. */
Pau Espin Pedrol8358c4b2021-07-07 12:41:38 +0200526void mgcp_patch_and_count(const struct mgcp_endpoint *endp,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200527 struct mgcp_rtp_state *state,
528 struct mgcp_rtp_end *rtp_end,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200529 struct osmo_sockaddr *addr, struct msgb *msg)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200530{
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200531 char ipbuf[INET6_ADDRSTRLEN];
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200532 uint32_t arrival_time;
533 int32_t transit;
534 uint16_t seq;
535 uint32_t timestamp, ssrc;
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200536 bool marker_bit;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200537 struct rtp_hdr *rtp_hdr;
Philipp Maierbc0346e2018-06-07 09:52:16 +0200538 int payload = rtp_end->codec->payload_type;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200539 unsigned int len = msgb_length(msg);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200540
541 if (len < sizeof(*rtp_hdr))
542 return;
543
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200544 rtp_hdr = (struct rtp_hdr *)msgb_data(msg);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200545 seq = ntohs(rtp_hdr->sequence);
546 timestamp = ntohl(rtp_hdr->timestamp);
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +0100547 arrival_time = mgcp_get_current_ts(rtp_end->codec->rate);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200548 ssrc = ntohl(rtp_hdr->ssrc);
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200549 marker_bit = !!rtp_hdr->marker;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200550 transit = arrival_time - timestamp;
551
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200552 mgcp_rtp_annex_count(endp, state, seq, transit, ssrc, marker_bit);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200553
554 if (!state->initialized) {
555 state->initialized = 1;
556 state->in_stream.last_seq = seq - 1;
Harald Welte33381352017-12-25 09:44:26 +0100557 state->in_stream.ssrc = state->patch.orig_ssrc = ssrc;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200558 state->in_stream.last_tsdelta = 0;
Philipp Maier87bd9be2017-08-22 16:35:41 +0200559 state->packet_duration =
560 mgcp_rtp_packet_duration(endp, rtp_end);
Philipp Maier0ec1d4e2018-05-16 11:09:42 +0200561 state->out_stream.last_seq = seq - 1;
562 state->out_stream.ssrc = state->patch.orig_ssrc = ssrc;
563 state->out_stream.last_tsdelta = 0;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200564 state->out_stream.last_timestamp = timestamp;
Philipp Maier87bd9be2017-08-22 16:35:41 +0200565 state->out_stream.ssrc = ssrc - 1; /* force output SSRC change */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200566 LOGPENDP(endp, DRTP, LOGL_INFO,
567 "initializing stream, SSRC: %u timestamp: %u "
568 "pkt-duration: %d, from %s:%d\n",
569 state->in_stream.ssrc,
570 state->patch.seq_offset, state->packet_duration,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200571 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
572 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200573 if (state->packet_duration == 0) {
Philipp Maier87bd9be2017-08-22 16:35:41 +0200574 state->packet_duration =
Philipp Maierbc0346e2018-06-07 09:52:16 +0200575 rtp_end->codec->rate * 20 / 1000;
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200576 LOGPENDP(endp, DRTP, LOGL_NOTICE,
577 "fixed packet duration is not available, "
578 "using fixed 20ms instead: %d from %s:%d\n",
579 state->packet_duration,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200580 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
581 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200582 }
583 } else if (state->in_stream.ssrc != ssrc) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200584 LOGPENDP(endp, DRTP, LOGL_NOTICE,
585 "SSRC changed: %u -> %u "
586 "from %s:%d\n",
587 state->in_stream.ssrc, rtp_hdr->ssrc,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200588 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
589 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200590
591 state->in_stream.ssrc = ssrc;
592 if (rtp_end->force_constant_ssrc) {
593 int16_t delta_seq;
594
595 /* Always increment seqno by 1 */
Harald Welte33381352017-12-25 09:44:26 +0100596 state->patch.seq_offset =
Philipp Maier87bd9be2017-08-22 16:35:41 +0200597 (state->out_stream.last_seq + 1) - seq;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200598
599 /* Estimate number of packets that would have been sent */
600 delta_seq =
Philipp Maier87bd9be2017-08-22 16:35:41 +0200601 (arrival_time - state->in_stream.last_arrival_time
602 + state->packet_duration / 2) /
603 state->packet_duration;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200604
605 adjust_rtp_timestamp_offset(endp, state, rtp_end, addr,
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200606 delta_seq, timestamp, marker_bit);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200607
Pau Espin Pedrol4c77e9b2021-07-07 12:12:58 +0200608 state->patch.patch_ssrc = true;
Harald Welte33381352017-12-25 09:44:26 +0100609 ssrc = state->patch.orig_ssrc;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200610 if (rtp_end->force_constant_ssrc != -1)
611 rtp_end->force_constant_ssrc -= 1;
612
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200613 LOGPENDP(endp, DRTP, LOGL_NOTICE,
614 "SSRC patching enabled, SSRC: %u "
615 "SeqNo offset: %d, TS offset: %d "
616 "from %s:%d\n", state->in_stream.ssrc,
617 state->patch.seq_offset, state->patch.timestamp_offset,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200618 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
619 osmo_sockaddr_port(&addr->u.sa));
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200620 }
621
622 state->in_stream.last_tsdelta = 0;
623 } else {
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200624 if (!marker_bit) {
625 /* Compute current per-packet timestamp delta */
626 check_rtp_timestamp(endp, state, &state->in_stream, rtp_end,
627 addr, seq, timestamp, "input",
628 &state->in_stream.last_tsdelta);
629 } else {
630 state->in_stream.last_tsdelta = 0;
631 }
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200632
Harald Welte33381352017-12-25 09:44:26 +0100633 if (state->patch.patch_ssrc)
634 ssrc = state->patch.orig_ssrc;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200635 }
636
637 /* Save before patching */
638 state->in_stream.last_timestamp = timestamp;
639 state->in_stream.last_seq = seq;
640 state->in_stream.last_arrival_time = arrival_time;
641
642 if (rtp_end->force_aligned_timing &&
643 state->out_stream.ssrc == ssrc && state->packet_duration)
644 /* Align the timestamp offset */
Philipp Maier87bd9be2017-08-22 16:35:41 +0200645 align_rtp_timestamp_offset(endp, state, rtp_end, addr,
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200646 timestamp, marker_bit);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200647
648 /* Store the updated SSRC back to the packet */
Harald Welte33381352017-12-25 09:44:26 +0100649 if (state->patch.patch_ssrc)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200650 rtp_hdr->ssrc = htonl(ssrc);
651
652 /* Apply the offset and store it back to the packet.
653 * This won't change anything if the offset is 0, so the conditional is
654 * omitted. */
Harald Welte33381352017-12-25 09:44:26 +0100655 seq += state->patch.seq_offset;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200656 rtp_hdr->sequence = htons(seq);
Harald Welte33381352017-12-25 09:44:26 +0100657 timestamp += state->patch.timestamp_offset;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200658 rtp_hdr->timestamp = htonl(timestamp);
659
660 /* Check again, whether the timestamps are still valid */
Pau Espin Pedrolb066bd02021-07-07 13:41:19 +0200661 if (!marker_bit) {
662 if (state->out_stream.ssrc == ssrc)
663 check_rtp_timestamp(endp, state, &state->out_stream, rtp_end,
664 addr, seq, timestamp, "output",
665 &state->out_stream.last_tsdelta);
666 } else {
667 state->out_stream.last_tsdelta = 0;
668 }
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200669
670 /* Save output values */
671 state->out_stream.last_seq = seq;
672 state->out_stream.last_timestamp = timestamp;
673 state->out_stream.ssrc = ssrc;
674
675 if (payload < 0)
676 return;
677
678#if 0
Philipp Maierc66ab2c2020-06-02 20:55:34 +0200679 LOGPENDP(endp, DRTP, LOGL_DEBUG, "payload hdr payload %u -> endp payload %u\n",
680 rtp_hdr->payload_type, payload);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200681 rtp_hdr->payload_type = payload;
682#endif
683}
684
Philipp Maier9fc8a022019-02-20 12:26:52 +0100685/* There are different dialects used to format and transfer voice data. When
686 * the receiving end expects GSM-HR data to be formated after RFC 5993, this
687 * function is used to convert between RFC 5993 and TS 101318, which we normally
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200688 * use.
689 * Return 0 on sucess, negative on errors like invalid data length. */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200690static int rfc5993_hr_convert(struct mgcp_endpoint *endp, struct msgb *msg)
Philipp Maier9fc8a022019-02-20 12:26:52 +0100691{
Philipp Maier9fc8a022019-02-20 12:26:52 +0100692 struct rtp_hdr *rtp_hdr;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200693 if (msgb_length(msg) < sizeof(struct rtp_hdr)) {
Pau Espin Pedrol08077712022-10-19 19:06:45 +0200694 LOGPENDP(endp, DRTP, LOGL_ERROR, "RTP packet too short (%d < %zu)\n",
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200695 msgb_length(msg), sizeof(struct rtp_hdr));
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200696 return -EINVAL;
697 }
698
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200699 rtp_hdr = (struct rtp_hdr *)msgb_data(msg);
Philipp Maier9fc8a022019-02-20 12:26:52 +0100700
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200701 if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr)) {
Philipp Maier9fc8a022019-02-20 12:26:52 +0100702 /* TS 101318 encoding => RFC 5993 encoding */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200703 msgb_put(msg, 1);
Philipp Maier9fc8a022019-02-20 12:26:52 +0100704 memmove(rtp_hdr->data + 1, rtp_hdr->data, GSM_HR_BYTES);
705 rtp_hdr->data[0] = 0x00;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200706 } else if (msgb_length(msg) == GSM_HR_BYTES + sizeof(struct rtp_hdr) + 1) {
Philipp Maier9fc8a022019-02-20 12:26:52 +0100707 /* RFC 5993 encoding => TS 101318 encoding */
708 memmove(rtp_hdr->data, rtp_hdr->data + 1, GSM_HR_BYTES);
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200709 msgb_trim(msg, msgb_length(msg) - 1);
Philipp Maier9fc8a022019-02-20 12:26:52 +0100710 } else {
711 /* It is possible that multiple payloads occur in one RTP
712 * packet. This is not supported yet. */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200713 LOGPENDP(endp, DRTP, LOGL_ERROR,
714 "cannot figure out how to convert RTP packet\n");
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200715 return -ENOTSUP;
Philipp Maier9fc8a022019-02-20 12:26:52 +0100716 }
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200717 return 0;
Philipp Maier9fc8a022019-02-20 12:26:52 +0100718}
719
Pau Espin Pedrol377d3912022-10-25 13:52:19 +0200720/*! Convert msg to AMR RTP framing mode specified by target_is_oa.
721 * \param[in] endp MGCP Endpoint where this message belongs to (used for logging purposes)
722 * \param[in] msg Message containing an AMR RTP payload (in octet-aligned or bandwidth-efficient format).
723 * \param[in] target_is_oa the target framing mode that msg will contain after this function succeeds.
724 * \returns The size of the new RTP AMR content on success, negative on error.
725 *
726 * For AMR RTP two framing modes are defined RFC3267. There is a bandwidth
Philipp Maier228e5912019-03-05 13:56:59 +0100727 * efficient encoding scheme where all fields are packed together one after
728 * another and an octet aligned mode where all fields are aligned to octet
Pau Espin Pedrol377d3912022-10-25 13:52:19 +0200729 * boundaries. This function is used to convert between the two modes.
730 */
731int amr_oa_bwe_convert(struct mgcp_endpoint *endp, struct msgb *msg,
Philipp Maier228e5912019-03-05 13:56:59 +0100732 bool target_is_oa)
733{
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200734 /* NOTE: the msgb has an allocated length of RTP_BUF_SIZE, so there is
Philipp Maier228e5912019-03-05 13:56:59 +0100735 * plenty of space available to store the slightly larger, converted
736 * data */
Philipp Maier228e5912019-03-05 13:56:59 +0100737 struct rtp_hdr *rtp_hdr;
738 unsigned int payload_len;
739 int rc;
Pau Espin Pedrol9ac9cb92022-10-26 12:36:48 +0200740 bool orig_is_oa;
Philipp Maier228e5912019-03-05 13:56:59 +0100741
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200742 if (msgb_length(msg) < sizeof(struct rtp_hdr)) {
743 LOGPENDP(endp, DRTP, LOGL_ERROR, "AMR RTP packet too short (%d < %zu)\n", msgb_length(msg), sizeof(struct rtp_hdr));
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200744 return -EINVAL;
745 }
746
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200747 rtp_hdr = (struct rtp_hdr *)msgb_data(msg);
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200748 payload_len = msgb_length(msg) - sizeof(struct rtp_hdr);
Pau Espin Pedrol9ac9cb92022-10-26 12:36:48 +0200749 orig_is_oa = osmo_amr_is_oa(rtp_hdr->data, payload_len);
Philipp Maier228e5912019-03-05 13:56:59 +0100750
Pau Espin Pedrol9ac9cb92022-10-26 12:36:48 +0200751 if (orig_is_oa) {
Philipp Maier228e5912019-03-05 13:56:59 +0100752 if (!target_is_oa)
753 /* Input data is oa an target format is bwe
754 * ==> convert */
755 rc = osmo_amr_oa_to_bwe(rtp_hdr->data, payload_len);
756 else
757 /* Input data is already bew, but we accept it anyway
758 * ==> no conversion needed */
759 rc = payload_len;
760 } else {
761 if (target_is_oa)
762 /* Input data is bwe an target format is oa
763 * ==> convert */
764 rc = osmo_amr_bwe_to_oa(rtp_hdr->data, payload_len,
765 RTP_BUF_SIZE);
766 else
767 /* Input data is already oa, but we accept it anyway
768 * ==> no conversion needed */
769 rc = payload_len;
770 }
771 if (rc < 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200772 LOGPENDP(endp, DRTP, LOGL_ERROR,
Pau Espin Pedrol9ac9cb92022-10-26 12:36:48 +0200773 "RTP AMR packet conversion %s->%s failed: %s\n",
774 orig_is_oa ? "OA" : "BWE",
775 target_is_oa ? "OA" : "BWE",
776 osmo_hexdump(rtp_hdr->data, payload_len));
Philipp Maier228e5912019-03-05 13:56:59 +0100777 return -EINVAL;
778 }
779
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200780 return msgb_trim(msg, rc + sizeof(struct rtp_hdr));
Philipp Maier228e5912019-03-05 13:56:59 +0100781}
782
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200783/* Return whether an RTP packet with AMR payload is in octet-aligned mode.
784 * Return 0 if in bandwidth-efficient mode, 1 for octet-aligned mode, and negative if the RTP data is invalid. */
785static int amr_oa_check(char *data, int len)
Philipp Maier228e5912019-03-05 13:56:59 +0100786{
787 struct rtp_hdr *rtp_hdr;
788 unsigned int payload_len;
789
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200790 if (len < sizeof(struct rtp_hdr))
791 return -EINVAL;
792
Philipp Maier228e5912019-03-05 13:56:59 +0100793 rtp_hdr = (struct rtp_hdr *)data;
794
795 payload_len = len - sizeof(struct rtp_hdr);
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200796 if (payload_len < sizeof(struct amr_hdr))
797 return -EINVAL;
Philipp Maier228e5912019-03-05 13:56:59 +0100798
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +0200799 return osmo_amr_is_oa(rtp_hdr->data, payload_len) ? 1 : 0;
Philipp Maier228e5912019-03-05 13:56:59 +0100800}
801
Philipp Maier87bd9be2017-08-22 16:35:41 +0200802/* Forward data to a debug tap. This is debug function that is intended for
803 * debugging the voice traffic with tools like gstreamer */
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +0100804void forward_data_tap(int fd, struct mgcp_rtp_tap *tap, struct msgb *msg)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200805{
Philipp Maiere6f172d2017-11-07 12:00:01 +0100806 int rc;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200807
Philipp Maiere6f172d2017-11-07 12:00:01 +0100808 if (!tap->enabled)
809 return;
810
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200811 rc = sendto(fd, msgb_data(msg), msgb_length(msg), 0, (struct sockaddr *)&tap->forward,
Philipp Maiere6f172d2017-11-07 12:00:01 +0100812 sizeof(tap->forward));
813
814 if (rc < 0)
815 LOGP(DRTP, LOGL_ERROR,
816 "Forwarding tapped (debug) voice data failed.\n");
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200817}
818
Philipp Maier889fe7f2020-07-06 17:44:12 +0200819/* Generate an RTP header if it is missing */
820static void gen_rtp_header(struct msgb *msg, struct mgcp_rtp_end *rtp_end,
821 struct mgcp_rtp_state *state)
822{
823 struct rtp_hdr *hdr = (struct rtp_hdr *)msgb_data(msg);
824
825 if (hdr->version > 0)
826 return;
827
828 hdr->version = 2;
829 hdr->payload_type = rtp_end->codec->payload_type;
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +0100830 hdr->timestamp = osmo_htonl(mgcp_get_current_ts(rtp_end->codec->rate));
Philipp Maier889fe7f2020-07-06 17:44:12 +0200831 hdr->sequence = osmo_htons(state->alt_rtp_tx_sequence);
832 hdr->ssrc = state->alt_rtp_tx_ssrc;
833}
834
Philipp Maier87bd9be2017-08-22 16:35:41 +0200835/* Check if the origin (addr) matches the address/port data of the RTP
836 * connections. */
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200837static int check_rtp_origin(struct mgcp_conn_rtp *conn, struct osmo_sockaddr *addr)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200838{
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200839 char ipbuf[INET6_ADDRSTRLEN];
840
Pau Espin Pedrol051eb4d2022-10-04 12:50:28 +0200841 if (osmo_sockaddr_is_any(&conn->end.addr) != 0) {
Neels Hofmeyrefd645e2018-09-10 13:14:50 +0200842 switch (conn->conn->mode) {
843 case MGCP_CONN_LOOPBACK:
844 /* HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP
845 * message received. We currently hackishly accomplish that by putting the endpoint in
846 * loopback mode and patching over the looped back RTP message to make it look like an
847 * ack. We don't know the femto cell's IP address and port until the RAB Assignment
848 * Response is received, but the nano3G expects an IuUP Initialization Ack before it even
849 * sends the RAB Assignment Response. Hence, if the remote address is 0.0.0.0 and the
850 * MGCP port is in loopback mode, allow looping back the packet to any source. */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200851 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
852 "In loopback mode and remote address not set:"
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200853 " allowing data from address: %s\n",
854 osmo_sockaddr_ntop(&addr->u.sa, ipbuf));
Neels Hofmeyrefd645e2018-09-10 13:14:50 +0200855 return 0;
856
857 default:
858 /* Receiving early media before the endpoint is configured. Instead of logging
859 * this as an error that occurs on every call, keep it more low profile to not
860 * confuse humans with expected errors. */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200861 LOGPCONN(conn->conn, DRTP, LOGL_INFO,
862 "Rx RTP from %s, but remote address not set:"
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200863 " dropping early media\n",
864 osmo_sockaddr_ntop(&addr->u.sa, ipbuf));
Neels Hofmeyrefd645e2018-09-10 13:14:50 +0200865 return -1;
866 }
Neels Hofmeyr0063ca22018-07-23 18:12:16 +0200867 }
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200868
Philipp Maier87bd9be2017-08-22 16:35:41 +0200869 /* Note: Check if the inbound RTP data comes from the same host to
870 * which we send our outgoing RTP traffic. */
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200871 if (conn->end.addr.u.sa.sa_family != addr->u.sa.sa_family ||
872 (conn->end.addr.u.sa.sa_family == AF_INET &&
873 conn->end.addr.u.sin.sin_addr.s_addr != addr->u.sin.sin_addr.s_addr) ||
874 (conn->end.addr.u.sa.sa_family == AF_INET6 &&
875 memcmp(&conn->end.addr.u.sin6.sin6_addr, &addr->u.sin6.sin6_addr,
876 sizeof(struct in6_addr)))) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200877 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200878 "data from wrong address: %s, ",
879 osmo_sockaddr_ntop(&addr->u.sa, ipbuf));
Philipp Maierc3413882017-10-27 12:26:54 +0200880 LOGPC(DRTP, LOGL_ERROR, "expected: %s\n",
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200881 osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf));
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200882 LOGPCONN(conn->conn, DRTP, LOGL_ERROR, "packet tossed\n");
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200883 return -1;
884 }
885
Philipp Maier87bd9be2017-08-22 16:35:41 +0200886 /* Note: Usually the remote remote port of the data we receive will be
887 * the same as the remote port where we transmit outgoing RTP traffic
888 * to (set by MDCX). We use this to check the origin of the data for
889 * plausibility. */
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200890 if (osmo_sockaddr_port(&conn->end.addr.u.sa) != osmo_sockaddr_port(&addr->u.sa) &&
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200891 ntohs(conn->end.rtcp_port) != osmo_sockaddr_port(&addr->u.sa)) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200892 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200893 "data from wrong source port: %d, ",
894 osmo_sockaddr_port(&addr->u.sa));
Philipp Maierc3413882017-10-27 12:26:54 +0200895 LOGPC(DRTP, LOGL_ERROR,
Philipp Maier87bd9be2017-08-22 16:35:41 +0200896 "expected: %d for RTP or %d for RTCP\n",
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200897 osmo_sockaddr_port(&conn->end.addr.u.sa), ntohs(conn->end.rtcp_port));
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200898 LOGPCONN(conn->conn, DRTP, LOGL_ERROR, "packet tossed\n");
Philipp Maier87bd9be2017-08-22 16:35:41 +0200899 return -1;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200900 }
901
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200902 return 0;
903}
904
Philipp Maier87bd9be2017-08-22 16:35:41 +0200905/* Check the if the destination address configuration of an RTP connection
906 * makes sense */
907static int check_rtp_destin(struct mgcp_conn_rtp *conn)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200908{
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200909 char ipbuf[INET6_ADDRSTRLEN];
Pau Espin Pedrol051eb4d2022-10-04 12:50:28 +0200910 bool ip_is_any = osmo_sockaddr_is_any(&conn->end.addr) != 0;
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200911 uint16_t port = osmo_sockaddr_port(&conn->end.addr.u.sa);
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200912
Philipp Maiere6df0e42018-05-29 14:03:06 +0200913 /* Note: it is legal to create a connection but never setting a port
914 * and IP-address for outgoing data. */
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200915 if (ip_is_any && port == 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200916 LOGPCONN(conn->conn, DRTP, LOGL_DEBUG,
Neels Hofmeyra4b677c2021-07-07 23:38:23 +0200917 "destination IP-address and rtp port is not (yet) known (%s:%u)\n",
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200918 osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf), port);
Philipp Maiere6df0e42018-05-29 14:03:06 +0200919 return -1;
920 }
921
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +0200922 if (ip_is_any) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200923 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
924 "destination IP-address is invalid (%s:%u)\n",
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200925 osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf), port);
Philipp Maier87bd9be2017-08-22 16:35:41 +0200926 return -1;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200927 }
Philipp Maier87bd9be2017-08-22 16:35:41 +0200928
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200929 if (port == 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +0200930 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
931 "destination rtp port is invalid (%s:%u)\n",
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +0200932 osmo_sockaddr_ntop(&conn->end.addr.u.sa, ipbuf), port);
Philipp Maier87bd9be2017-08-22 16:35:41 +0200933 return -1;
934 }
935
936 return 0;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +0200937}
938
Philipp Maier4dba7692018-08-03 12:20:52 +0200939/* Do some basic checks to make sure that the RTCP packets we are going to
940 * process are not complete garbage */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200941static int check_rtcp(struct mgcp_conn_rtp *conn_src, struct msgb *msg)
Philipp Maier4dba7692018-08-03 12:20:52 +0200942{
943 struct rtcp_hdr *hdr;
944 unsigned int len;
945 uint8_t type;
946
947 /* RTPC packets that are just a header without data do not make
948 * any sense. */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200949 if (msgb_length(msg) < sizeof(struct rtcp_hdr)) {
950 LOG_CONN_RTP(conn_src, LOGL_ERROR, "RTCP packet too short (%u < %zu)\n",
951 msgb_length(msg), sizeof(struct rtcp_hdr));
Philipp Maier4dba7692018-08-03 12:20:52 +0200952 return -EINVAL;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200953 }
Philipp Maier4dba7692018-08-03 12:20:52 +0200954
955 /* Make sure that the length of the received packet does not exceed
956 * the available buffer size */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200957 hdr = (struct rtcp_hdr *)msgb_data(msg);
Philipp Maier4dba7692018-08-03 12:20:52 +0200958 len = (osmo_ntohs(hdr->length) + 1) * 4;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200959 if (len > msgb_length(msg)) {
960 LOG_CONN_RTP(conn_src, LOGL_ERROR, "RTCP header length exceeds packet size (%u > %u)\n",
961 len, msgb_length(msg));
Philipp Maier4dba7692018-08-03 12:20:52 +0200962 return -EINVAL;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200963 }
Philipp Maier4dba7692018-08-03 12:20:52 +0200964
965 /* Make sure we accept only packets that have a proper packet type set
966 * See also: http://www.iana.org/assignments/rtp-parameters/rtp-parameters.xhtml */
967 type = hdr->type;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200968 if ((type < 192 || type > 195) && (type < 200 || type > 213)) {
969 LOG_CONN_RTP(conn_src, LOGL_ERROR, "RTCP header: invalid type: %u\n", type);
Philipp Maier4dba7692018-08-03 12:20:52 +0200970 return -EINVAL;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200971 }
Philipp Maier4dba7692018-08-03 12:20:52 +0200972
973 return 0;
974}
975
976/* Do some basic checks to make sure that the RTP packets we are going to
977 * process are not complete garbage */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200978static int check_rtp(struct mgcp_conn_rtp *conn_src, struct msgb *msg)
Philipp Maier4dba7692018-08-03 12:20:52 +0200979{
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +0200980 size_t min_size = sizeof(struct rtp_hdr);
981 if (msgb_length(msg) < min_size) {
982 LOG_CONN_RTP(conn_src, LOGL_ERROR, "RTP packet too short (%u < %zu)\n",
983 msgb_length(msg), min_size);
984 return -1;
985 }
Philipp Maier4dba7692018-08-03 12:20:52 +0200986
987 /* FIXME: Add more checks, the reason why we do not check more than
988 * the length is because we currently handle IUUP packets as RTP
989 * packets, so they must pass this check, if we weould be more
990 * strict here, we would possibly break 3G. (see also FIXME note
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +0100991 * below.*/
Philipp Maier4dba7692018-08-03 12:20:52 +0200992
993 return 0;
994}
995
Pau Espin Pedrol6db3f7f2022-10-24 17:55:02 +0200996/*! Dispatch msg bridged from the sister conn in the endpoint.
997 * \param[in] conn_dst The destination conn that should handle and transmit the content to
998 * its peer outside MGW.
999 * \param[in] msg msgb containing an RTP pkt received by the sister conn in the endpoint,
1000 * \returns bytes sent, -1 on error.
1001 *
1002 * Possible options are standard RTP packet transmission, transmission
1003 * via IuUP or transmission via an osmux connection.
1004 */
1005static int mgcp_conn_rtp_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg)
Philipp Maier87bd9be2017-08-22 16:35:41 +02001006{
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001007 struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg);
1008 enum rtp_proto proto = mc->proto;
1009 struct mgcp_conn_rtp *conn_src = mc->conn_src;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001010 struct mgcp_endpoint *endp = conn_src->conn->endp;
Philipp Maier87bd9be2017-08-22 16:35:41 +02001011
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001012 LOGPENDP(endp, DRTP, LOGL_DEBUG, "destin conn:%s\n",
1013 mgcp_conn_dump(conn_dst->conn));
Philipp Maier87bd9be2017-08-22 16:35:41 +02001014
1015 /* Before we try to deliver the packet, we check if the destination
1016 * port and IP-Address make sense at all. If not, we will be unable
1017 * to deliver the packet. */
1018 if (check_rtp_destin(conn_dst) != 0)
1019 return -1;
1020
1021 /* Depending on the RTP connection type, deliver the RTP packet to the
1022 * destination connection. */
1023 switch (conn_dst->type) {
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001024 case MGCP_RTP_DEFAULT:
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001025 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1026 "endpoint type is MGCP_RTP_DEFAULT, "
1027 "using mgcp_send() to forward data directly\n");
Philipp Maier87bd9be2017-08-22 16:35:41 +02001028 return mgcp_send(endp, proto == MGCP_PROTO_RTP,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001029 mc->from_addr, msg, conn_src, conn_dst);
Pau Espin Pedrol9d939b62022-10-03 16:59:20 +02001030 case MGCP_RTP_OSMUX:
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001031 LOGPENDP(endp, DRTP, LOGL_DEBUG,
Pau Espin Pedrol9d939b62022-10-03 16:59:20 +02001032 "endpoint type is MGCP_RTP_OSMUX, "
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001033 "using osmux_xfrm_to_osmux() to forward data through OSMUX\n");
Pau Espin Pedrold1e94c72022-10-25 13:49:40 +02001034 return conn_osmux_send_rtp(conn_dst, msg);
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001035 case MGCP_RTP_IUUP:
1036 if (proto == MGCP_PROTO_RTP) {
1037 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1038 "endpoint type is MGCP_RTP_IUUP, "
1039 "using mgcp_conn_iuup_send_rtp() to forward data over IuUP\n");
1040 return mgcp_conn_iuup_send_rtp(conn_src, conn_dst, msg);
1041 }
1042 /* RTCP: we forward as usual for regular RTP connection */
1043 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1044 "endpoint type is MGCP_RTP_IUUP and proto!=MGCP_PROTO_RTP, "
1045 "using mgcp_send() to forward data directly\n");
1046 return mgcp_send(endp, false,
1047 mc->from_addr, msg, conn_src, conn_dst);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001048 }
1049
Philipp Maier87bd9be2017-08-22 16:35:41 +02001050 /* If the data has not been handled/forwarded until here, it will
1051 * be discarded, this should not happen, normally the MGCP type
1052 * should be properly set */
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001053 LOGPENDP(endp, DRTP, LOGL_ERROR, "bad MGCP type -- data discarded!\n");
Philipp Maier87bd9be2017-08-22 16:35:41 +02001054
1055 return -1;
1056}
1057
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001058/*! send udp packet.
1059 * \param[in] fd associated file descriptor.
1060 * \param[in] addr destination ip-address.
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001061 * \param[in] buf buffer that holds the data to be send.
1062 * \param[in] len length of the data to be sent.
1063 * \returns bytes sent, -1 on error. */
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001064int mgcp_udp_send(int fd, const struct osmo_sockaddr *addr, const char *buf, int len)
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001065{
1066 char ipbuf[INET6_ADDRSTRLEN];
1067 size_t addr_len;
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001068
1069 LOGP(DRTP, LOGL_DEBUG,
1070 "sending %i bytes length packet to %s:%u ...\n", len,
1071 osmo_sockaddr_ntop(&addr->u.sa, ipbuf),
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001072 osmo_sockaddr_port(&addr->u.sa));
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001073
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001074 if (addr->u.sa.sa_family == AF_INET6) {
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001075 addr_len = sizeof(addr->u.sin6);
1076 } else {
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001077 addr_len = sizeof(addr->u.sin);
1078 }
1079
1080 return sendto(fd, buf, len, 0, &addr->u.sa, addr_len);
1081}
1082
1083/*! send RTP dummy packet (to keep NAT connection open).
1084 * \param[in] endp mcgp endpoint that holds the RTP connection.
1085 * \param[in] conn associated RTP connection.
1086 * \returns bytes sent, -1 on error. */
1087int mgcp_send_dummy(struct mgcp_endpoint *endp, struct mgcp_conn_rtp *conn)
1088{
1089 int rc;
1090 int was_rtcp = 0;
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001091 struct osmo_sockaddr rtcp_addr;
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001092
1093 OSMO_ASSERT(endp);
1094 OSMO_ASSERT(conn);
1095
1096 LOGPCONN(conn->conn, DRTP, LOGL_DEBUG, "sending dummy packet... %s\n",
1097 mgcp_conn_dump(conn->conn));
1098
Pau Espin Pedrola24dcc62021-07-06 17:48:47 +02001099 /* Before we try to deliver the packet, we check if the destination
1100 * port and IP-Address make sense at all. If not, we will be unable
1101 * to deliver the packet. */
1102 if (check_rtp_destin(conn) != 0)
1103 goto failed;
1104
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001105 if (mgcp_conn_rtp_is_iuup(conn))
1106 rc = mgcp_conn_iuup_send_dummy(conn);
1107 else
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001108 rc = mgcp_udp_send(conn->end.rtp.fd, &conn->end.addr,
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001109 rtp_dummy_payload, sizeof(rtp_dummy_payload));
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001110
1111 if (rc == -1)
1112 goto failed;
1113
1114 if (endp->trunk->omit_rtcp)
1115 return rc;
1116
1117 was_rtcp = 1;
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001118 rtcp_addr = conn->end.addr;
1119 osmo_sockaddr_set_port(&rtcp_addr.u.sa, ntohs(conn->end.rtcp_port));
1120 rc = mgcp_udp_send(conn->end.rtcp.fd, &rtcp_addr,
1121 rtp_dummy_payload, sizeof(rtp_dummy_payload));
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001122
1123 if (rc >= 0)
1124 return rc;
1125
1126failed:
1127 LOGPCONN(conn->conn, DRTP, LOGL_ERROR,
1128 "Failed to send dummy %s packet.\n",
1129 was_rtcp ? "RTCP" : "RTP");
1130
1131 return -1;
1132}
1133
1134/*! Send RTP/RTCP data to a specified destination connection.
1135 * \param[in] endp associated endpoint (for configuration, logging).
1136 * \param[in] is_rtp flag to specify if the packet is of type RTP or RTCP.
1137 * \param[in] spoofed source address (set to NULL to disable).
1138 * \param[in] buf buffer that contains the RTP/RTCP data.
1139 * \param[in] len length of the buffer that contains the RTP/RTCP data.
1140 * \param[in] conn_src associated source connection.
1141 * \param[in] conn_dst associated destination connection.
1142 * \returns 0 on success, -1 on ERROR. */
1143int mgcp_send(struct mgcp_endpoint *endp, int is_rtp, struct osmo_sockaddr *addr,
1144 struct msgb *msg, struct mgcp_conn_rtp *conn_src,
1145 struct mgcp_conn_rtp *conn_dst)
1146{
1147 /*! When no destination connection is available (e.g. when only one
1148 * connection in loopback mode exists), then the source connection
1149 * shall be specified as destination connection */
1150
1151 struct mgcp_trunk *trunk = endp->trunk;
1152 struct mgcp_rtp_end *rtp_end;
1153 struct mgcp_rtp_state *rtp_state;
1154 char ipbuf[INET6_ADDRSTRLEN];
1155 char *dest_name;
1156 int rc;
1157 int len;
1158
1159 OSMO_ASSERT(conn_src);
1160 OSMO_ASSERT(conn_dst);
1161
1162 if (is_rtp)
1163 LOGPENDP(endp, DRTP, LOGL_DEBUG, "delivering RTP packet...\n");
1164 else
1165 LOGPENDP(endp, DRTP, LOGL_DEBUG, "delivering RTCP packet...\n");
1166
Neels Hofmeyrc1468ef2022-10-24 01:00:26 +02001167 /* Patch the payload type number: translate from conn_src to conn_dst.
1168 * Do not patch for IuUP, where the correct payload type number is already set in bridge_iuup_to_rtp_peer():
1169 * IuUP -> AMR: calls this function, skip patching if conn_src is IuUP.
1170 * {AMR or IuUP} -> IuUP: calls mgcp_udp_send() directly, skipping this function: No need to examine dst. */
1171 if (is_rtp && !mgcp_conn_rtp_is_iuup(conn_src)) {
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001172 rc = mgcp_patch_pt(conn_src, conn_dst, msg);
1173 if (rc < 0) {
Neels Hofmeyrc1468ef2022-10-24 01:00:26 +02001174 /* FIXME: It is legal that the payload type on the egress connection is
1175 * different from the payload type that has been negotiated on the
1176 * ingress connection. Essentially the codecs are the same so we can
1177 * match them and patch the payload type. However, if we can not find
1178 * the codec pendant (everything ist equal except the PT), we are of
1179 * course unable to patch the payload type. A situation like this
1180 * should not occur if transcoding is consequently avoided. Until
1181 * we have transcoding support in osmo-mgw we can not resolve this. */
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001182 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1183 "can not patch PT because no suitable egress codec was found.\n");
1184 }
1185 }
1186
1187 /* Note: In case of loopback configuration, both, the source and the
1188 * destination will point to the same connection. */
1189 rtp_end = &conn_dst->end;
1190 rtp_state = &conn_src->state;
1191 dest_name = conn_dst->conn->name;
1192
1193 /* Ensure we have an alternative SSRC in case we need it, see also
1194 * gen_rtp_header() */
1195 if (rtp_state->alt_rtp_tx_ssrc == 0)
1196 rtp_state->alt_rtp_tx_ssrc = rand();
1197
1198 if (!rtp_end->output_enabled) {
1199 rtpconn_rate_ctr_inc(conn_dst, endp, RTP_DROPPED_PACKETS_CTR);
1200 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1201 "output disabled, drop to %s %s "
1202 "rtp_port:%u rtcp_port:%u\n",
1203 dest_name,
1204 osmo_sockaddr_ntop(&rtp_end->addr.u.sa, ipbuf),
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001205 osmo_sockaddr_port(&rtp_end->addr.u.sa), ntohs(rtp_end->rtcp_port)
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001206 );
1207 } else if (is_rtp) {
1208 int cont;
1209 int nbytes = 0;
1210 int buflen = msgb_length(msg);
1211
1212 /* Make sure we have a valid RTP header, in cases where no RTP
1213 * header is present, we will generate one. */
1214 gen_rtp_header(msg, rtp_end, rtp_state);
1215
1216 do {
1217 /* Run transcoder */
Ericfbf78d12021-08-23 22:31:39 +02001218 cont = endp->trunk->cfg->rtp_processing_cb(endp, rtp_end, (char *)msgb_data(msg), &buflen, RTP_BUF_SIZE);
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001219 if (cont < 0)
1220 break;
1221
1222 if (addr)
1223 mgcp_patch_and_count(endp, rtp_state, rtp_end,
1224 addr, msg);
1225
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001226 if (mgcp_conn_rtp_is_iuup(conn_dst) || mgcp_conn_rtp_is_iuup(conn_src)) {
1227 /* the iuup code will correctly transform to the correct AMR mode */
Pau Espin Pedrolcca55242022-10-24 17:14:33 +02001228 } else if (mgcp_codec_amr_align_mode_is_indicated(conn_dst->end.codec)) {
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001229 rc = amr_oa_bwe_convert(endp, msg,
1230 conn_dst->end.codec->param.amr_octet_aligned);
1231 if (rc < 0) {
1232 LOGPENDP(endp, DRTP, LOGL_ERROR,
Pau Espin Pedrol9ac9cb92022-10-26 12:36:48 +02001233 "Error in AMR octet-aligned <-> bandwidth-efficient mode conversion (target=%s)\n",
1234 conn_dst->end.codec->param.amr_octet_aligned ? "octet-aligned" : "bandwidth-efficient");
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001235 break;
1236 }
1237 } else if (rtp_end->rfc5993_hr_convert &&
1238 strcmp(conn_src->end.codec->subtype_name, "GSM-HR-08") == 0) {
1239 rc = rfc5993_hr_convert(endp, msg);
1240 if (rc < 0) {
1241 LOGPENDP(endp, DRTP, LOGL_ERROR, "Error while converting to GSM-HR-08\n");
1242 break;
1243 }
1244 }
1245
1246 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1247 "process/send to %s %s "
1248 "rtp_port:%u rtcp_port:%u\n",
1249 dest_name,
1250 osmo_sockaddr_ntop(&rtp_end->addr.u.sa, ipbuf),
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001251 osmo_sockaddr_port(&rtp_end->addr.u.sa), ntohs(rtp_end->rtcp_port)
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001252 );
1253
1254 /* Forward a copy of the RTP data to a debug ip/port */
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001255 forward_data_tap(rtp_end->rtp.fd, &conn_src->tap_out,
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001256 msg);
1257
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001258 len = mgcp_udp_send(rtp_end->rtp.fd, &rtp_end->addr,
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001259 (char *)msgb_data(msg), msgb_length(msg));
1260
1261 if (len <= 0)
1262 return len;
1263
1264 rtpconn_rate_ctr_inc(conn_dst, endp, RTP_PACKETS_TX_CTR);
1265 rtpconn_rate_ctr_add(conn_dst, endp, RTP_OCTETS_TX_CTR, len);
1266 rtp_state->alt_rtp_tx_sequence++;
1267
1268 nbytes += len;
1269 buflen = cont;
1270 } while (buflen > 0);
1271 return nbytes;
1272 } else if (!trunk->omit_rtcp) {
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001273 struct osmo_sockaddr rtcp_addr = rtp_end->addr;
1274 osmo_sockaddr_set_port(&rtcp_addr.u.sa, rtp_end->rtcp_port);
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001275 LOGPENDP(endp, DRTP, LOGL_DEBUG,
1276 "send to %s %s rtp_port:%u rtcp_port:%u\n",
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001277 dest_name, osmo_sockaddr_ntop(&rtcp_addr.u.sa, ipbuf),
1278 osmo_sockaddr_port(&rtp_end->addr.u.sa),
1279 osmo_sockaddr_port(&rtcp_addr.u.sa)
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001280 );
1281
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001282 len = mgcp_udp_send(rtp_end->rtcp.fd, &rtcp_addr,
1283 (char *)msgb_data(msg), msgb_length(msg));
Pau Espin Pedrol62d9df62021-07-06 16:39:09 +02001284
1285 rtpconn_rate_ctr_inc(conn_dst, endp, RTP_PACKETS_TX_CTR);
1286 rtpconn_rate_ctr_add(conn_dst, endp, RTP_OCTETS_TX_CTR, len);
1287 rtp_state->alt_rtp_tx_sequence++;
1288
1289 return len;
1290 }
1291
1292 return 0;
1293}
1294
Pau Espin Pedrolde805b62022-10-03 16:08:58 +02001295/*! Dispatch incoming RTP packet to opposite RTP connection.
1296 * \param[in] msg Message buffer to bridge, coming from source connection.
1297 * msg shall contain "struct osmo_rtp_msg_ctx *" attached in
1298 * "OSMO_RTP_MSG_CTX(msg)".
1299 * \returns 0 on success, -1 on ERROR.
1300 */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001301int mgcp_dispatch_rtp_bridge_cb(struct msgb *msg)
Philipp Maier87bd9be2017-08-22 16:35:41 +02001302{
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001303 struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg);
1304 struct mgcp_conn_rtp *conn_src = mc->conn_src;
1305 struct mgcp_conn *conn = conn_src->conn;
Philipp Maier87bd9be2017-08-22 16:35:41 +02001306 struct mgcp_conn *conn_dst;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001307 struct osmo_sockaddr *from_addr = mc->from_addr;
Philipp Maier97a93122021-05-07 22:50:31 +02001308 char ipbuf[INET6_ADDRSTRLEN];
Philipp Maier87bd9be2017-08-22 16:35:41 +02001309
1310 /*! NOTE: This callback function implements the endpoint specific
Alexander Chemeris61cf9bb2020-05-11 18:13:53 +03001311 * dispatch behaviour of an rtp bridge/proxy endpoint. It is assumed
Philipp Maier87bd9be2017-08-22 16:35:41 +02001312 * that the endpoint will hold only two connections. This premise
1313 * is used to determine the opposite connection (it is always the
1314 * connection that is not the originating connection). Once the
1315 * destination connection is known the RTP packet is sent via
1316 * the destination connection. */
1317
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001318 /* If source is IuUP, we need to handle state, forward it through specific bridge path: */
1319 if (mgcp_conn_rtp_is_iuup(conn_src) && mc->proto == MGCP_PROTO_RTP)
1320 return mgcp_conn_iuup_dispatch_rtp(msg);
Pau Espin Pedrol9aaaab62019-05-15 23:23:27 +02001321
1322 /* Check if the connection is in loopback mode, if yes, just send the
1323 * incoming data back to the origin */
1324 if (conn->mode == MGCP_CONN_LOOPBACK) {
1325 /* When we are in loopback mode, we loop back all incoming
1326 * packets back to their origin. We will use the originating
1327 * address data from the UDP packet header to patch the
1328 * outgoing address in connection on the fly */
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001329 if (osmo_sockaddr_port(&conn->u.rtp.end.addr.u.sa) == 0) {
Philipp Maier97a93122021-05-07 22:50:31 +02001330 memcpy(&conn->u.rtp.end.addr, from_addr,
1331 sizeof(conn->u.rtp.end.addr));
Philipp Maier97a93122021-05-07 22:50:31 +02001332 LOG_CONN_RTP(conn_src, LOGL_NOTICE,
1333 "loopback mode: implicitly using source address (%s:%u) as destination address\n",
1334 osmo_sockaddr_ntop(&from_addr->u.sa, ipbuf),
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001335 osmo_sockaddr_port(&conn->u.rtp.end.addr.u.sa));
Pau Espin Pedrol9aaaab62019-05-15 23:23:27 +02001336 }
Pau Espin Pedrol6db3f7f2022-10-24 17:55:02 +02001337 return mgcp_conn_rtp_dispatch_rtp(conn_src, msg);
Pau Espin Pedrol9aaaab62019-05-15 23:23:27 +02001338 }
1339
Philipp Maier87bd9be2017-08-22 16:35:41 +02001340 /* Find a destination connection. */
1341 /* NOTE: This code path runs every time an RTP packet is received. The
1342 * function mgcp_find_dst_conn() we use to determine the detination
1343 * connection will iterate the connection list inside the endpoint.
1344 * Since list iterations are quite costly, we will figure out the
1345 * destination only once and use the optional private data pointer of
1346 * the connection to cache the destination connection pointer. */
1347 if (!conn->priv) {
1348 conn_dst = mgcp_find_dst_conn(conn);
1349 conn->priv = conn_dst;
1350 } else {
1351 conn_dst = (struct mgcp_conn *)conn->priv;
1352 }
1353
1354 /* There is no destination conn, stop here */
1355 if (!conn_dst) {
Alexander Chemerisebb9bf32020-05-11 18:14:31 +03001356 LOGPCONN(conn, DRTP, LOGL_DEBUG,
1357 "no connection to forward an incoming RTP packet to\n");
Philipp Maier87bd9be2017-08-22 16:35:41 +02001358 return -1;
1359 }
1360
1361 /* The destination conn is not an RTP connection */
1362 if (conn_dst->type != MGCP_CONN_TYPE_RTP) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001363 LOGPCONN(conn, DRTP, LOGL_ERROR,
1364 "unable to find suitable destination conn\n");
Philipp Maier87bd9be2017-08-22 16:35:41 +02001365 return -1;
1366 }
1367
1368 /* Dispatch RTP packet to destination RTP connection */
Pau Espin Pedrol6db3f7f2022-10-24 17:55:02 +02001369 return mgcp_conn_rtp_dispatch_rtp(&conn_dst->u.rtp, msg);
Philipp Maier87bd9be2017-08-22 16:35:41 +02001370}
1371
Philipp Maier0996a1e2020-06-10 15:27:14 +02001372/*! dispatch incoming RTP packet to E1 subslot, handle RTCP packets locally.
1373 * \param[in] proto protocol (MGCP_CONN_TYPE_RTP or MGCP_CONN_TYPE_RTCP).
1374 * \param[in] addr socket address where the RTP packet has been received from.
1375 * \param[in] buf buffer that hold the RTP payload.
1376 * \param[in] buf_size size data length of buf.
1377 * \param[in] conn originating connection.
1378 * \returns 0 on success, -1 on ERROR. */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001379int mgcp_dispatch_e1_bridge_cb(struct msgb *msg)
Philipp Maier0996a1e2020-06-10 15:27:14 +02001380{
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001381 struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg);
1382 struct mgcp_conn_rtp *conn_src = mc->conn_src;
1383 struct mgcp_conn *conn = conn_src->conn;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001384 struct osmo_sockaddr *from_addr = mc->from_addr;
Philipp Maier97a93122021-05-07 22:50:31 +02001385 char ipbuf[INET6_ADDRSTRLEN];
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001386
Philipp Maier889fe7f2020-07-06 17:44:12 +02001387 /* Check if the connection is in loopback mode, if yes, just send the
1388 * incoming data back to the origin */
1389 if (conn->mode == MGCP_CONN_LOOPBACK) {
1390 /* When we are in loopback mode, we loop back all incoming
1391 * packets back to their origin. We will use the originating
1392 * address data from the UDP packet header to patch the
1393 * outgoing address in connection on the fly */
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001394 if (osmo_sockaddr_port(&conn->u.rtp.end.addr.u.sa) == 0) {
Philipp Maier97a93122021-05-07 22:50:31 +02001395 memcpy(&conn->u.rtp.end.addr, from_addr,
1396 sizeof(conn->u.rtp.end.addr));
Philipp Maier97a93122021-05-07 22:50:31 +02001397 LOG_CONN_RTP(conn_src, LOGL_NOTICE,
1398 "loopback mode: implicitly using source address (%s:%u) as destination address\n",
1399 osmo_sockaddr_ntop(&from_addr->u.sa, ipbuf),
Pau Espin Pedrol5ffd1272022-10-04 13:45:48 +02001400 osmo_sockaddr_port(&conn->u.rtp.end.addr.u.sa));
Philipp Maier889fe7f2020-07-06 17:44:12 +02001401 }
Pau Espin Pedrol6db3f7f2022-10-24 17:55:02 +02001402 return mgcp_conn_rtp_dispatch_rtp(conn_src, msg);
Philipp Maier889fe7f2020-07-06 17:44:12 +02001403 }
1404
1405 /* Forward to E1 */
1406 return mgcp_e1_send_rtp(conn->endp, conn->u.rtp.end.codec, msg);
Philipp Maier0996a1e2020-06-10 15:27:14 +02001407}
1408
Philipp Maierdf5d2192018-01-24 11:39:32 +01001409/*! cleanup an endpoint when a connection on an RTP bridge endpoint is removed.
1410 * \param[in] endp Endpoint on which the connection resides.
Philipp Maier08eb9352020-06-18 11:55:35 +02001411 * \param[in] conn Connection that is about to be removed (ignored). */
Philipp Maierdf5d2192018-01-24 11:39:32 +01001412void mgcp_cleanup_rtp_bridge_cb(struct mgcp_endpoint *endp, struct mgcp_conn *conn)
1413{
1414 struct mgcp_conn *conn_cleanup;
1415
1416 /* In mgcp_dispatch_rtp_bridge_cb() we use conn->priv to cache the
1417 * pointer to the destination connection, so that we do not have
1418 * to go through the list every time an RTP packet arrives. To prevent
1419 * a use-after-free situation we invalidate this information for all
1420 * connections present when one connection is removed from the
1421 * endpoint. */
1422 llist_for_each_entry(conn_cleanup, &endp->conns, entry) {
Pau Espin Pedrol6d0a59a2020-09-08 16:50:22 +02001423 if (conn_cleanup->priv == conn)
1424 conn_cleanup->priv = NULL;
Philipp Maierdf5d2192018-01-24 11:39:32 +01001425 }
1426}
1427
Philipp Maier0996a1e2020-06-10 15:27:14 +02001428/*! cleanup an endpoint when a connection on an E1 endpoint is removed.
1429 * \param[in] endp Endpoint on which the connection resides.
1430 * \param[in] conn Connection that is about to be removed (ignored). */
1431void mgcp_cleanup_e1_bridge_cb(struct mgcp_endpoint *endp, struct mgcp_conn *conn)
1432{
Philipp Maier889fe7f2020-07-06 17:44:12 +02001433 /* Cleanup tasks for E1 are the same as for regular endpoint. The
1434 * shut down of the E1 part is handled separately. */
1435 mgcp_cleanup_rtp_bridge_cb(endp, conn);
Philipp Maier0996a1e2020-06-10 15:27:14 +02001436}
1437
Philipp Maier87bd9be2017-08-22 16:35:41 +02001438/* Handle incoming RTP data from NET */
1439static int rtp_data_net(struct osmo_fd *fd, unsigned int what)
1440{
1441 /* NOTE: This is a generic implementation. RTP data is received. In
1442 * case of loopback the data is just sent back to its origin. All
1443 * other cases implement endpoint specific behaviour (e.g. how is the
1444 * destination connection determined?). That specific behaviour is
1445 * implemented by the callback function that is called at the end of
1446 * the function */
1447
1448 struct mgcp_conn_rtp *conn_src;
1449 struct mgcp_endpoint *endp;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001450 struct osmo_sockaddr addr;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001451 socklen_t slen = sizeof(addr);
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001452 char ipbuf[INET6_ADDRSTRLEN];
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001453 int ret;
1454 enum rtp_proto proto;
1455 struct osmo_rtp_msg_ctx *mc;
Eric8f333032021-08-13 00:00:43 +02001456 struct msgb *msg;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001457 int rc;
Philipp Maier87bd9be2017-08-22 16:35:41 +02001458
1459 conn_src = (struct mgcp_conn_rtp *)fd->data;
1460 OSMO_ASSERT(conn_src);
1461 endp = conn_src->conn->endp;
1462 OSMO_ASSERT(endp);
Eric8f333032021-08-13 00:00:43 +02001463 msg = msgb_alloc_c(endp->trunk, RTP_BUF_SIZE, "RTP-rx");
Philipp Maier87bd9be2017-08-22 16:35:41 +02001464
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001465 proto = (fd == &conn_src->end.rtp)? MGCP_PROTO_RTP : MGCP_PROTO_RTCP;
Philipp Maier87bd9be2017-08-22 16:35:41 +02001466
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001467 ret = recvfrom(fd->fd, msgb_data(msg), msg->data_len, 0, (struct sockaddr *)&addr.u.sa, &slen);
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001468
1469 if (ret <= 0) {
1470 LOG_CONN_RTP(conn_src, LOGL_ERROR, "recvfrom error: %s\n", strerror(errno));
1471 rc = -1;
1472 goto out;
1473 }
1474
1475 msgb_put(msg, ret);
1476
1477 LOG_CONN_RTP(conn_src, LOGL_DEBUG, "%s: rx %u bytes from %s:%u\n",
Philipp Maier069dd162022-03-30 16:09:22 +02001478 proto == MGCP_PROTO_RTP ? "RTP" : "RTCP",
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001479 msgb_length(msg), osmo_sockaddr_ntop(&addr.u.sa, ipbuf),
1480 osmo_sockaddr_port(&addr.u.sa));
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001481
1482 if ((proto == MGCP_PROTO_RTP && check_rtp(conn_src, msg))
1483 || (proto == MGCP_PROTO_RTCP && check_rtcp(conn_src, msg))) {
1484 /* Logging happened in the two check_ functions */
1485 rc = -1;
1486 goto out;
1487 }
1488
Philipp Maierb3d14eb2021-05-20 14:18:52 +02001489 if (mgcp_is_rtp_dummy_payload(msg)) {
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001490 LOG_CONN_RTP(conn_src, LOGL_DEBUG, "rx dummy packet (dropped)\n");
1491 rc = 0;
1492 goto out;
1493 }
1494
1495 /* Since the msgb remains owned and freed by this function, the msg ctx data struct can just be on the stack and
1496 * needs not be allocated with the msgb. */
1497 mc = OSMO_RTP_MSG_CTX(msg);
1498 *mc = (struct osmo_rtp_msg_ctx){
1499 .proto = proto,
1500 .conn_src = conn_src,
1501 .from_addr = &addr,
1502 };
1503 LOG_CONN_RTP(conn_src, LOGL_DEBUG, "msg ctx: %d %p %s\n",
1504 mc->proto, mc->conn_src,
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001505 osmo_hexdump((void*)mc->from_addr,
1506 mc->from_addr->u.sa.sa_family == AF_INET6 ?
1507 sizeof(struct sockaddr_in6) :
1508 sizeof(struct sockaddr_in)));
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001509
1510 /* Increment RX statistics */
Pau Espin Pedroldaf5bce2022-09-22 19:14:24 +02001511 rate_ctr_inc(rate_ctr_group_get_ctr(conn_src->ctrg, RTP_PACKETS_RX_CTR));
1512 rate_ctr_add(rate_ctr_group_get_ctr(conn_src->ctrg, RTP_OCTETS_RX_CTR), msgb_length(msg));
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001513 /* FIXME: count RTP and RTCP separately, also count IuUP payload-less separately */
1514
1515 /* Forward a copy of the RTP data to a debug ip/port */
Pau Espin Pedrolbb3ccde2021-12-23 19:49:26 +01001516 forward_data_tap(fd->fd, &conn_src->tap_in, msg);
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001517
1518 rc = rx_rtp(msg);
1519
1520out:
1521 msgb_free(msg);
1522 return rc;
1523}
1524
Philipp Maiere1442752022-03-30 16:06:15 +02001525/* Note: This function is able to handle RTP and RTCP */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001526static int rx_rtp(struct msgb *msg)
1527{
1528 struct osmo_rtp_msg_ctx *mc = OSMO_RTP_MSG_CTX(msg);
1529 struct mgcp_conn_rtp *conn_src = mc->conn_src;
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001530 struct osmo_sockaddr *from_addr = mc->from_addr;
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001531 struct mgcp_conn *conn = conn_src->conn;
1532 struct mgcp_trunk *trunk = conn->endp->trunk;
1533
1534 LOG_CONN_RTP(conn_src, LOGL_DEBUG, "rx_rtp(%u bytes)\n", msgb_length(msg));
Philipp Maier87bd9be2017-08-22 16:35:41 +02001535
Pau Espin Pedrol58c0b0a2022-10-24 17:36:13 +02001536 /* Check if the origin of the RTP packet seems plausible */
1537 if (!trunk->rtp_accept_all && check_rtp_origin(conn_src, from_addr))
1538 return -1;
Oliver Smithe36b7752019-01-22 16:31:36 +01001539
Philipp Maier82dfb502023-01-19 14:27:17 +01001540 /* Handle AMR frame format conversion (octet-aligned vs. bandwith-efficient) */
Philipp Maiere1442752022-03-30 16:06:15 +02001541 if (mc->proto == MGCP_PROTO_RTP &&
Pau Espin Pedrolcca55242022-10-24 17:14:33 +02001542 mgcp_codec_amr_align_mode_is_indicated(conn_src->end.codec)) {
Philipp Maier82dfb502023-01-19 14:27:17 +01001543 /* Make sure that the incoming AMR frame format matches the frame format that the call agent has
1544 * communicated via SDP when the connection was created/modfied. */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001545 int oa = amr_oa_check((char*)msgb_data(msg), msgb_length(msg));
Neels Hofmeyr7c6dd3c2019-08-20 03:06:17 +02001546 if (oa < 0)
1547 return -1;
Pau Espin Pedrold266c372022-10-24 16:57:39 +02001548 if (((bool)oa) != conn_src->end.codec->param.amr_octet_aligned) {
1549 LOG_CONN_RTP(conn_src, LOGL_NOTICE,
1550 "rx_rtp(%u bytes): Expected RTP AMR octet-aligned=%u but got octet-aligned=%u."
1551 " check the config of your call-agent!\n",
1552 msgb_length(msg), conn_src->end.codec->param.amr_octet_aligned, oa);
Philipp Maier228e5912019-03-05 13:56:59 +01001553 return -1;
Pau Espin Pedrold266c372022-10-24 16:57:39 +02001554 }
Philipp Maier228e5912019-03-05 13:56:59 +01001555 }
1556
Pau Espin Pedrol58c0b0a2022-10-24 17:36:13 +02001557 mgcp_conn_watchdog_kick(conn_src->conn);
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001558
Philipp Maier87bd9be2017-08-22 16:35:41 +02001559 /* Execute endpoint specific implementation that handles the
1560 * dispatching of the RTP data */
Neels Hofmeyr51b42ff2020-06-19 01:34:42 +02001561 return conn->endp->type->dispatch_rtp_cb(msg);
Philipp Maier87bd9be2017-08-22 16:35:41 +02001562}
1563
Philipp Maier87bd9be2017-08-22 16:35:41 +02001564/*! bind RTP port to osmo_fd.
Philipp Maier0b79d212020-06-18 12:02:49 +02001565 * \param[in] source_addr source (local) address to bind on.
1566 * \param[in] fd associated file descriptor.
1567 * \param[in] port to bind on.
Harald Welte55a92292021-04-28 19:06:34 +02001568 * \param[in] dscp IP DSCP value to use.
1569 * \param[in] prio socket priority to use.
Philipp Maier0b79d212020-06-18 12:02:49 +02001570 * \returns 0 on success, -1 on ERROR. */
Harald Welte55a92292021-04-28 19:06:34 +02001571int mgcp_create_bind(const char *source_addr, struct osmo_fd *fd, int port, uint8_t dscp,
1572 uint8_t prio)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001573{
Harald Welte8890dfa2017-11-17 15:09:30 +01001574 int rc;
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001575
Pau Espin Pedrola790f0c2020-08-31 13:29:11 +02001576 rc = osmo_sock_init2(AF_UNSPEC, SOCK_DGRAM, IPPROTO_UDP, source_addr, port,
Harald Welte55a92292021-04-28 19:06:34 +02001577 NULL, 0, OSMO_SOCK_F_BIND | OSMO_SOCK_F_DSCP(dscp) |
1578 OSMO_SOCK_F_PRIO(prio));
Harald Welte8890dfa2017-11-17 15:09:30 +01001579 if (rc < 0) {
Philipp Maierc3413882017-10-27 12:26:54 +02001580 LOGP(DRTP, LOGL_ERROR, "failed to bind UDP port (%s:%i).\n",
Philipp Maier87bd9be2017-08-22 16:35:41 +02001581 source_addr, port);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001582 return -1;
1583 }
Harald Welte8890dfa2017-11-17 15:09:30 +01001584 fd->fd = rc;
1585 LOGP(DRTP, LOGL_DEBUG, "created socket + bound UDP port (%s:%i).\n", source_addr, port);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001586
1587 return 0;
1588}
1589
Philipp Maier87bd9be2017-08-22 16:35:41 +02001590/* Bind RTP and RTCP port (helper function for mgcp_bind_net_rtp_port()) */
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001591static int bind_rtp(struct mgcp_config *cfg, const char *source_addr,
Philipp Maierc66ab2c2020-06-02 20:55:34 +02001592 struct mgcp_rtp_end *rtp_end, struct mgcp_endpoint *endp)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001593{
Philipp Maier87bd9be2017-08-22 16:35:41 +02001594 /* NOTE: The port that is used for RTCP is the RTP port incremented by one
1595 * (e.g. RTP-Port = 16000 ==> RTCP-Port = 16001) */
1596
Harald Welte55a92292021-04-28 19:06:34 +02001597 if (mgcp_create_bind(source_addr, &rtp_end->rtp, rtp_end->local_port,
1598 cfg->endp_dscp, cfg->endp_priority) != 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001599 LOGPENDP(endp, DRTP, LOGL_ERROR,
1600 "failed to create RTP port: %s:%d\n",
1601 source_addr, rtp_end->local_port);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001602 goto cleanup0;
1603 }
1604
Harald Welte55a92292021-04-28 19:06:34 +02001605 if (mgcp_create_bind(source_addr, &rtp_end->rtcp, rtp_end->local_port + 1,
1606 cfg->endp_dscp, cfg->endp_priority) != 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001607 LOGPENDP(endp, DRTP, LOGL_ERROR,
1608 "failed to create RTCP port: %s:%d\n",
1609 source_addr, rtp_end->local_port + 1);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001610 goto cleanup1;
1611 }
1612
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001613 if (osmo_fd_register(&rtp_end->rtp) != 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001614 LOGPENDP(endp, DRTP, LOGL_ERROR,
1615 "failed to register RTP port %d\n",
1616 rtp_end->local_port);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001617 goto cleanup2;
1618 }
1619
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001620 if (osmo_fd_register(&rtp_end->rtcp) != 0) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001621 LOGPENDP(endp, DRTP, LOGL_ERROR,
1622 "failed to register RTCP port %d\n",
1623 rtp_end->local_port + 1);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001624 goto cleanup3;
1625 }
1626
1627 return 0;
1628
1629cleanup3:
1630 osmo_fd_unregister(&rtp_end->rtp);
1631cleanup2:
1632 close(rtp_end->rtcp.fd);
1633 rtp_end->rtcp.fd = -1;
1634cleanup1:
1635 close(rtp_end->rtp.fd);
1636 rtp_end->rtp.fd = -1;
1637cleanup0:
1638 return -1;
1639}
1640
Philipp Maier87bd9be2017-08-22 16:35:41 +02001641/*! bind RTP port to endpoint/connection.
Philipp Maier0b79d212020-06-18 12:02:49 +02001642 * \param[in] endp endpoint that holds the RTP connection.
1643 * \param[in] rtp_port port number to bind on.
1644 * \param[in] conn associated RTP connection.
1645 * \returns 0 on success, -1 on ERROR. */
Philipp Maier87bd9be2017-08-22 16:35:41 +02001646int mgcp_bind_net_rtp_port(struct mgcp_endpoint *endp, int rtp_port,
1647 struct mgcp_conn_rtp *conn)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001648{
Philipp Maier87bd9be2017-08-22 16:35:41 +02001649 char name[512];
1650 struct mgcp_rtp_end *end;
1651
Philipp Maier01d24a32017-11-21 17:26:09 +01001652 snprintf(name, sizeof(name), "%s-%s", conn->conn->name, conn->conn->id);
Philipp Maier87bd9be2017-08-22 16:35:41 +02001653 end = &conn->end;
1654
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001655 if (end->rtp.fd != -1 || end->rtcp.fd != -1) {
Pau Espin Pedrol3239f622019-04-24 18:47:46 +02001656 LOGPENDP(endp, DRTP, LOGL_ERROR, "%u was already bound on conn:%s\n",
1657 rtp_port, mgcp_conn_dump(conn->conn));
Philipp Maier87bd9be2017-08-22 16:35:41 +02001658
1659 /* Double bindings should never occour! Since we always allocate
1660 * connections dynamically and free them when they are not
1661 * needed anymore, there must be no previous binding leftover.
1662 * Should there be a connection bound twice, we have a serious
1663 * problem and must exit immediately! */
1664 OSMO_ASSERT(false);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001665 }
1666
1667 end->local_port = rtp_port;
Harald Weltec2a8f592020-10-19 13:25:41 +02001668 osmo_fd_setup(&end->rtp, -1, OSMO_FD_READ, rtp_data_net, conn, 0);
1669 osmo_fd_setup(&end->rtcp, -1, OSMO_FD_READ, rtp_data_net, conn, 0);
Philipp Maier87bd9be2017-08-22 16:35:41 +02001670
Ericfbf78d12021-08-23 22:31:39 +02001671 return bind_rtp(endp->trunk->cfg, conn->end.local_addr, end, endp);
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001672}
1673
Philipp Maier87bd9be2017-08-22 16:35:41 +02001674/*! free allocated RTP and RTCP ports.
1675 * \param[in] end RTP end */
1676void mgcp_free_rtp_port(struct mgcp_rtp_end *end)
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001677{
1678 if (end->rtp.fd != -1) {
1679 close(end->rtp.fd);
1680 end->rtp.fd = -1;
1681 osmo_fd_unregister(&end->rtp);
1682 }
1683
1684 if (end->rtcp.fd != -1) {
1685 close(end->rtcp.fd);
1686 end->rtcp.fd = -1;
1687 osmo_fd_unregister(&end->rtcp);
1688 }
Neels Hofmeyrf83ec562017-09-07 19:18:40 +02001689}