Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 1 | /* SMS queue to continously attempt to deliver SMS */ |
| 2 | /* |
| 3 | * (C) 2010 by Holger Hans Peter Freyther <zecke@selfish.org> |
| 4 | * All Rights Reserved |
| 5 | * |
| 6 | * This program is free software; you can redistribute it and/or modify |
Harald Welte | 9af6ddf | 2011-01-01 15:25:50 +0100 | [diff] [blame] | 7 | * it under the terms of the GNU Affero General Public License as published by |
| 8 | * the Free Software Foundation; either version 3 of the License, or |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 9 | * (at your option) any later version. |
| 10 | * |
| 11 | * This program is distributed in the hope that it will be useful, |
| 12 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 13 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
Harald Welte | 9af6ddf | 2011-01-01 15:25:50 +0100 | [diff] [blame] | 14 | * GNU Affero General Public License for more details. |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 15 | * |
Harald Welte | 9af6ddf | 2011-01-01 15:25:50 +0100 | [diff] [blame] | 16 | * You should have received a copy of the GNU Affero General Public License |
| 17 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 18 | * |
| 19 | */ |
| 20 | |
| 21 | /** |
| 22 | * The difficulty of such a queue is to send a lot of SMS without |
| 23 | * overloading the paging subsystem and the database and other users |
| 24 | * of the MSC. To make the best use we would need to know the number |
| 25 | * of pending paging requests, then throttle the number of SMS we |
| 26 | * want to send and such. |
| 27 | * We will start with a very simple SMS Queue and then try to speed |
| 28 | * things up by collecting data from other parts of the system. |
| 29 | */ |
| 30 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 31 | #include <limits.h> |
| 32 | |
Neels Hofmeyr | 9084396 | 2017-09-04 15:04:35 +0200 | [diff] [blame] | 33 | #include <osmocom/msc/sms_queue.h> |
Neels Hofmeyr | 9084396 | 2017-09-04 15:04:35 +0200 | [diff] [blame] | 34 | #include <osmocom/msc/db.h> |
| 35 | #include <osmocom/msc/debug.h> |
| 36 | #include <osmocom/msc/gsm_data.h> |
| 37 | #include <osmocom/msc/gsm_04_11.h> |
| 38 | #include <osmocom/msc/gsm_subscriber.h> |
| 39 | #include <osmocom/msc/signal.h> |
| 40 | #include <osmocom/msc/vlr.h> |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 41 | |
Pablo Neira Ayuso | 136f453 | 2011-03-22 16:47:59 +0100 | [diff] [blame] | 42 | #include <osmocom/core/talloc.h> |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 43 | |
Holger Hans Peter Freyther | 81c0e25 | 2010-12-25 14:08:00 +0100 | [diff] [blame] | 44 | #include <osmocom/vty/vty.h> |
| 45 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 46 | /* |
| 47 | * One pending SMS that we wait for. |
| 48 | */ |
| 49 | struct gsm_sms_pending { |
| 50 | struct llist_head entry; |
| 51 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 52 | struct vlr_subscr *vsub; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 53 | unsigned long long sms_id; |
| 54 | int failed_attempts; |
| 55 | int resend; |
| 56 | }; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 57 | |
| 58 | struct gsm_sms_queue { |
Pablo Neira Ayuso | bf540cb | 2011-05-06 12:11:06 +0200 | [diff] [blame] | 59 | struct osmo_timer_list resend_pending; |
| 60 | struct osmo_timer_list push_queue; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 61 | struct gsm_network *network; |
Holger Hans Peter Freyther | 7e59c83 | 2010-12-25 14:46:54 +0100 | [diff] [blame] | 62 | int max_fail; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 63 | int max_pending; |
| 64 | int pending; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 65 | |
| 66 | struct llist_head pending_sms; |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 67 | |
Neels Hofmeyr | 7b61ffe | 2018-11-30 02:46:53 +0100 | [diff] [blame] | 68 | char last_msisdn[VLR_MSISDN_LENGTH+1]; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 69 | }; |
| 70 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 71 | static int sms_subscr_cb(unsigned int, unsigned int, void *, void *); |
| 72 | static int sms_sms_cb(unsigned int, unsigned int, void *, void *); |
| 73 | |
| 74 | static struct gsm_sms_pending *sms_find_pending(struct gsm_sms_queue *smsq, |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 75 | unsigned long long sms_id) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 76 | { |
| 77 | struct gsm_sms_pending *pending; |
| 78 | |
| 79 | llist_for_each_entry(pending, &smsq->pending_sms, entry) { |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 80 | if (pending->sms_id == sms_id) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 81 | return pending; |
| 82 | } |
| 83 | |
| 84 | return NULL; |
| 85 | } |
| 86 | |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 87 | int sms_queue_sms_is_pending(struct gsm_sms_queue *smsq, unsigned long long sms_id) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 88 | { |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 89 | return sms_find_pending(smsq, sms_id) != NULL; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 90 | } |
| 91 | |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 92 | static struct gsm_sms_pending *sms_subscriber_find_pending( |
| 93 | struct gsm_sms_queue *smsq, |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 94 | struct vlr_subscr *vsub) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 95 | { |
| 96 | struct gsm_sms_pending *pending; |
| 97 | |
| 98 | llist_for_each_entry(pending, &smsq->pending_sms, entry) { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 99 | if (pending->vsub == vsub) |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 100 | return pending; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 101 | } |
| 102 | |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 103 | return NULL; |
| 104 | } |
| 105 | |
| 106 | static int sms_subscriber_is_pending(struct gsm_sms_queue *smsq, |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 107 | struct vlr_subscr *vsub) |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 108 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 109 | return sms_subscriber_find_pending(smsq, vsub) != NULL; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 110 | } |
| 111 | |
| 112 | static struct gsm_sms_pending *sms_pending_from(struct gsm_sms_queue *smsq, |
| 113 | struct gsm_sms *sms) |
| 114 | { |
| 115 | struct gsm_sms_pending *pending; |
| 116 | |
| 117 | pending = talloc_zero(smsq, struct gsm_sms_pending); |
| 118 | if (!pending) |
| 119 | return NULL; |
| 120 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 121 | pending->vsub = vlr_subscr_get(sms->receiver); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 122 | pending->sms_id = sms->id; |
| 123 | return pending; |
| 124 | } |
| 125 | |
| 126 | static void sms_pending_free(struct gsm_sms_pending *pending) |
| 127 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 128 | vlr_subscr_put(pending->vsub); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 129 | llist_del(&pending->entry); |
| 130 | talloc_free(pending); |
| 131 | } |
| 132 | |
| 133 | static void sms_pending_resend(struct gsm_sms_pending *pending) |
| 134 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 135 | struct gsm_network *net = pending->vsub->vlr->user_ctx; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 136 | struct gsm_sms_queue *smsq; |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 137 | LOGP(DLSMS, LOGL_DEBUG, |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 138 | "Scheduling resend of SMS %llu.\n", pending->sms_id); |
| 139 | |
| 140 | pending->resend = 1; |
| 141 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 142 | smsq = net->sms_queue; |
Pablo Neira Ayuso | bf540cb | 2011-05-06 12:11:06 +0200 | [diff] [blame] | 143 | if (osmo_timer_pending(&smsq->resend_pending)) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 144 | return; |
| 145 | |
Pablo Neira Ayuso | bf540cb | 2011-05-06 12:11:06 +0200 | [diff] [blame] | 146 | osmo_timer_schedule(&smsq->resend_pending, 1, 0); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 147 | } |
| 148 | |
| 149 | static void sms_pending_failed(struct gsm_sms_pending *pending, int paging_error) |
| 150 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 151 | struct gsm_network *net = pending->vsub->vlr->user_ctx; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 152 | struct gsm_sms_queue *smsq; |
| 153 | |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 154 | LOGP(DLSMS, LOGL_NOTICE, "Sending SMS %llu failed %d times.\n", |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 155 | pending->sms_id, pending->failed_attempts); |
| 156 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 157 | smsq = net->sms_queue; |
Holger Hans Peter Freyther | 7e59c83 | 2010-12-25 14:46:54 +0100 | [diff] [blame] | 158 | if (++pending->failed_attempts < smsq->max_fail) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 159 | return sms_pending_resend(pending); |
| 160 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 161 | sms_pending_free(pending); |
| 162 | smsq->pending -= 1; |
| 163 | sms_queue_trigger(smsq); |
| 164 | } |
| 165 | |
| 166 | /* |
| 167 | * Resend all SMS that are scheduled for a resend. This is done to |
| 168 | * avoid an immediate failure. |
| 169 | */ |
| 170 | static void sms_resend_pending(void *_data) |
| 171 | { |
| 172 | struct gsm_sms_pending *pending, *tmp; |
| 173 | struct gsm_sms_queue *smsq = _data; |
| 174 | |
| 175 | llist_for_each_entry_safe(pending, tmp, &smsq->pending_sms, entry) { |
| 176 | struct gsm_sms *sms; |
| 177 | if (!pending->resend) |
| 178 | continue; |
| 179 | |
| 180 | sms = db_sms_get(smsq->network, pending->sms_id); |
| 181 | |
| 182 | /* the sms is gone? Move to the next */ |
| 183 | if (!sms) { |
| 184 | sms_pending_free(pending); |
| 185 | smsq->pending -= 1; |
| 186 | sms_queue_trigger(smsq); |
| 187 | } else { |
| 188 | pending->resend = 0; |
Vadim Yanitskiy | 24e025e | 2018-11-22 15:42:39 +0700 | [diff] [blame] | 189 | gsm411_send_sms(smsq->network, sms->receiver, sms); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 190 | } |
| 191 | } |
| 192 | } |
| 193 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 194 | /* Find the next pending SMS by cycling through the recipients. We could also |
| 195 | * cycle through the pending SMS, but that might cause us to keep trying to |
| 196 | * send SMS to the same few subscribers repeatedly while not servicing other |
| 197 | * subscribers for a long time. By walking the list of recipient MSISDNs, we |
| 198 | * ensure that all subscribers get their fair time to receive SMS. */ |
| 199 | struct gsm_sms *smsq_take_next_sms(struct gsm_network *net, |
| 200 | char *last_msisdn, |
| 201 | size_t last_msisdn_buflen) |
Holger Hans Peter Freyther | f7e2389 | 2010-12-25 17:45:23 +0100 | [diff] [blame] | 202 | { |
| 203 | struct gsm_sms *sms; |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 204 | int wrapped = 0; |
| 205 | int sanity = 100; |
| 206 | char started_with_msisdn[last_msisdn_buflen]; |
Holger Hans Peter Freyther | f7e2389 | 2010-12-25 17:45:23 +0100 | [diff] [blame] | 207 | |
Max | 98f7467 | 2018-02-05 12:57:06 +0100 | [diff] [blame] | 208 | OSMO_STRLCPY_ARRAY(started_with_msisdn, last_msisdn); |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 209 | |
| 210 | while (wrapped < 2 && (--sanity)) { |
| 211 | /* If we wrapped around and passed the first msisdn, we're |
| 212 | * through the entire SMS DB; end it. */ |
| 213 | if (wrapped && strcmp(last_msisdn, started_with_msisdn) >= 0) |
| 214 | break; |
| 215 | |
| 216 | sms = db_sms_get_next_unsent_rr_msisdn(net, last_msisdn, 9); |
| 217 | if (!sms) { |
| 218 | last_msisdn[0] = '\0'; |
Max | 5e2e9bd | 2018-02-06 19:31:08 +0100 | [diff] [blame] | 219 | wrapped++; |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 220 | continue; |
| 221 | } |
| 222 | |
| 223 | /* Whatever happens, next time around service another recipient |
| 224 | */ |
| 225 | osmo_strlcpy(last_msisdn, sms->dst.addr, last_msisdn_buflen); |
| 226 | |
| 227 | /* Is the subscriber attached? If not, go to next SMS */ |
| 228 | if (!sms->receiver || !sms->receiver->lu_complete) |
| 229 | continue; |
| 230 | |
Holger Hans Peter Freyther | f7e2389 | 2010-12-25 17:45:23 +0100 | [diff] [blame] | 231 | return sms; |
| 232 | } |
| 233 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 234 | DEBUGP(DLSMS, "SMS queue: no SMS to be sent\n"); |
| 235 | return NULL; |
Holger Hans Peter Freyther | f7e2389 | 2010-12-25 17:45:23 +0100 | [diff] [blame] | 236 | } |
| 237 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 238 | /** |
| 239 | * I will submit up to max_pending - pending SMS to the |
| 240 | * subsystem. |
| 241 | */ |
| 242 | static void sms_submit_pending(void *_data) |
| 243 | { |
| 244 | struct gsm_sms_queue *smsq = _data; |
| 245 | int attempts = smsq->max_pending - smsq->pending; |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 246 | int initialized = 0; |
| 247 | unsigned long long first_sub = 0; |
Holger Hans Peter Freyther | 5479fc8 | 2010-12-25 19:32:12 +0100 | [diff] [blame] | 248 | int attempted = 0, rounds = 0; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 249 | |
Harald Welte | e5d2c60 | 2012-11-13 06:52:42 +0100 | [diff] [blame] | 250 | LOGP(DLSMS, LOGL_DEBUG, "Attempting to send %d SMS\n", attempts); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 251 | |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 252 | do { |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 253 | struct gsm_sms_pending *pending; |
| 254 | struct gsm_sms *sms; |
| 255 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 256 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 257 | sms = smsq_take_next_sms(smsq->network, smsq->last_msisdn, |
| 258 | sizeof(smsq->last_msisdn)); |
Neels Hofmeyr | 1e918c3 | 2016-05-09 21:48:53 +0200 | [diff] [blame] | 259 | if (!sms) { |
| 260 | LOGP(DLSMS, LOGL_DEBUG, "Sending SMS done (%d attempted)\n", |
| 261 | attempted); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 262 | break; |
Neels Hofmeyr | 1e918c3 | 2016-05-09 21:48:53 +0200 | [diff] [blame] | 263 | } |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 264 | |
Holger Hans Peter Freyther | 5479fc8 | 2010-12-25 19:32:12 +0100 | [diff] [blame] | 265 | rounds += 1; |
Neels Hofmeyr | 1e918c3 | 2016-05-09 21:48:53 +0200 | [diff] [blame] | 266 | LOGP(DLSMS, LOGL_DEBUG, "Sending SMS round %d\n", rounds); |
Holger Hans Peter Freyther | 5479fc8 | 2010-12-25 19:32:12 +0100 | [diff] [blame] | 267 | |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 268 | /* |
| 269 | * This code needs to detect a loop. It assumes that no SMS |
| 270 | * will vanish during the time this is executed. We will remember |
| 271 | * the id of the first GSM subscriber we see and then will |
| 272 | * compare this. The Database code should make sure that we will |
| 273 | * see all other subscribers first before seeing this one again. |
| 274 | * |
| 275 | * It is always scary to have an infinite loop like this. |
| 276 | */ |
| 277 | if (!initialized) { |
| 278 | first_sub = sms->receiver->id; |
| 279 | initialized = 1; |
| 280 | } else if (first_sub == sms->receiver->id) { |
Neels Hofmeyr | 1e918c3 | 2016-05-09 21:48:53 +0200 | [diff] [blame] | 281 | LOGP(DLSMS, LOGL_DEBUG, "Sending SMS done (loop) (%d attempted)\n", |
| 282 | attempted); |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 283 | sms_free(sms); |
| 284 | break; |
| 285 | } |
| 286 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 287 | /* no need to send a pending sms */ |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 288 | if (sms_queue_sms_is_pending(smsq, sms->id)) { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 289 | LOGP(DLSMS, LOGL_DEBUG, |
Holger Hans Peter Freyther | dc53af6 | 2010-12-27 20:12:25 +0100 | [diff] [blame] | 290 | "SMSqueue with pending sms: %llu. Skipping\n", sms->id); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 291 | sms_free(sms); |
| 292 | continue; |
| 293 | } |
| 294 | |
| 295 | /* no need to send a SMS with the same receiver */ |
| 296 | if (sms_subscriber_is_pending(smsq, sms->receiver)) { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 297 | LOGP(DLSMS, LOGL_DEBUG, |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 298 | "SMSqueue with pending sub: %llu. Skipping\n", sms->receiver->id); |
| 299 | sms_free(sms); |
| 300 | continue; |
| 301 | } |
| 302 | |
| 303 | pending = sms_pending_from(smsq, sms); |
| 304 | if (!pending) { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 305 | LOGP(DLSMS, LOGL_ERROR, |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 306 | "Failed to create pending SMS entry.\n"); |
| 307 | sms_free(sms); |
| 308 | continue; |
| 309 | } |
| 310 | |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 311 | attempted += 1; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 312 | smsq->pending += 1; |
Holger Hans Peter Freyther | 701076e | 2010-12-28 14:25:25 +0100 | [diff] [blame] | 313 | llist_add_tail(&pending->entry, &smsq->pending_sms); |
Vadim Yanitskiy | 24e025e | 2018-11-22 15:42:39 +0700 | [diff] [blame] | 314 | gsm411_send_sms(smsq->network, sms->receiver, sms); |
Holger Hans Peter Freyther | 5479fc8 | 2010-12-25 19:32:12 +0100 | [diff] [blame] | 315 | } while (attempted < attempts && rounds < 1000); |
Holger Hans Peter Freyther | 2038457 | 2010-12-25 19:28:44 +0100 | [diff] [blame] | 316 | |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 317 | LOGP(DLSMS, LOGL_DEBUG, "SMSqueue added %d messages in %d rounds\n", attempted, rounds); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 318 | } |
| 319 | |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 320 | /** |
| 321 | * Send the next SMS or trigger the queue |
| 322 | */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 323 | static void sms_send_next(struct vlr_subscr *vsub) |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 324 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 325 | struct gsm_network *net = vsub->vlr->user_ctx; |
| 326 | struct gsm_sms_queue *smsq = net->sms_queue; |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 327 | struct gsm_sms_pending *pending; |
| 328 | struct gsm_sms *sms; |
| 329 | |
| 330 | /* the subscriber should not be in the queue */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 331 | OSMO_ASSERT(!sms_subscriber_is_pending(smsq, vsub)); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 332 | |
| 333 | /* check for more messages for this subscriber */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 334 | sms = db_sms_get_unsent_for_subscr(vsub, UINT_MAX); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 335 | if (!sms) |
| 336 | goto no_pending_sms; |
| 337 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 338 | /* The sms should not be scheduled right now */ |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 339 | OSMO_ASSERT(!sms_queue_sms_is_pending(smsq, sms->id)); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 340 | |
| 341 | /* Remember that we deliver this SMS and send it */ |
| 342 | pending = sms_pending_from(smsq, sms); |
| 343 | if (!pending) { |
| 344 | LOGP(DLSMS, LOGL_ERROR, |
| 345 | "Failed to create pending SMS entry.\n"); |
| 346 | sms_free(sms); |
| 347 | goto no_pending_sms; |
| 348 | } |
| 349 | |
| 350 | smsq->pending += 1; |
| 351 | llist_add_tail(&pending->entry, &smsq->pending_sms); |
Vadim Yanitskiy | 24e025e | 2018-11-22 15:42:39 +0700 | [diff] [blame] | 352 | gsm411_send_sms(smsq->network, sms->receiver, sms); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 353 | return; |
| 354 | |
| 355 | no_pending_sms: |
| 356 | /* Try to send the SMS to avoid the queue being stuck */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 357 | sms_submit_pending(net->sms_queue); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 358 | } |
| 359 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 360 | /* |
| 361 | * Kick off the queue again. |
| 362 | */ |
| 363 | int sms_queue_trigger(struct gsm_sms_queue *smsq) |
| 364 | { |
Neels Hofmeyr | 1e918c3 | 2016-05-09 21:48:53 +0200 | [diff] [blame] | 365 | LOGP(DLSMS, LOGL_DEBUG, "Triggering SMS queue\n"); |
Pablo Neira Ayuso | bf540cb | 2011-05-06 12:11:06 +0200 | [diff] [blame] | 366 | if (osmo_timer_pending(&smsq->push_queue)) |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 367 | return 0; |
| 368 | |
Pablo Neira Ayuso | bf540cb | 2011-05-06 12:11:06 +0200 | [diff] [blame] | 369 | osmo_timer_schedule(&smsq->push_queue, 1, 0); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 370 | return 0; |
| 371 | } |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 372 | |
| 373 | int sms_queue_start(struct gsm_network *network, int max_pending) |
| 374 | { |
| 375 | struct gsm_sms_queue *sms = talloc_zero(network, struct gsm_sms_queue); |
| 376 | if (!sms) { |
| 377 | LOGP(DMSC, LOGL_ERROR, "Failed to create the SMS queue.\n"); |
| 378 | return -1; |
| 379 | } |
| 380 | |
Pablo Neira Ayuso | bbc5b99 | 2011-05-06 12:12:31 +0200 | [diff] [blame] | 381 | osmo_signal_register_handler(SS_SUBSCR, sms_subscr_cb, network); |
| 382 | osmo_signal_register_handler(SS_SMS, sms_sms_cb, network); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 383 | |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 384 | network->sms_queue = sms; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 385 | INIT_LLIST_HEAD(&sms->pending_sms); |
Holger Hans Peter Freyther | a37e3bc | 2010-12-25 17:43:03 +0100 | [diff] [blame] | 386 | sms->max_fail = 1; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 387 | sms->network = network; |
| 388 | sms->max_pending = max_pending; |
Pablo Neira Ayuso | 5121576 | 2017-05-08 20:57:52 +0200 | [diff] [blame] | 389 | osmo_timer_setup(&sms->push_queue, sms_submit_pending, sms); |
| 390 | osmo_timer_setup(&sms->resend_pending, sms_resend_pending, sms); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 391 | |
| 392 | sms_submit_pending(sms); |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 393 | |
| 394 | return 0; |
| 395 | } |
| 396 | |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 397 | static int sub_ready_for_sm(struct gsm_network *net, struct vlr_subscr *vsub) |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 398 | { |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 399 | struct gsm_sms *sms; |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 400 | struct gsm_sms_pending *pending; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 401 | |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 402 | /* |
| 403 | * The code used to be very clever and tried to submit |
| 404 | * a SMS during the Location Updating Request. This has |
| 405 | * two issues: |
| 406 | * 1.) The Phone might not be ready yet, e.g. the C155 |
| 407 | * will not respond to the Submit when it is booting. |
| 408 | * 2.) The queue is already trying to submit SMS to the |
| 409 | * user and by not responding to the paging request |
| 410 | * we will set the LAC back to 0. We would have to |
| 411 | * stop the paging and move things over. |
| 412 | * |
| 413 | * We need to be careful in what we try here. |
| 414 | */ |
| 415 | |
| 416 | /* check if we have pending requests */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 417 | pending = sms_subscriber_find_pending(net->sms_queue, vsub); |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 418 | if (pending) { |
| 419 | LOGP(DMSC, LOGL_NOTICE, |
| 420 | "Pending paging while subscriber %llu attached.\n", |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 421 | vsub->id); |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 422 | return 0; |
| 423 | } |
| 424 | |
Holger Hans Peter Freyther | 074b2b2 | 2011-07-25 00:13:06 +0200 | [diff] [blame] | 425 | /* Now try to deliver any pending SMS to this sub */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 426 | sms = db_sms_get_unsent_for_subscr(vsub, UINT_MAX); |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 427 | if (!sms) |
| 428 | return -1; |
Vadim Yanitskiy | 24e025e | 2018-11-22 15:42:39 +0700 | [diff] [blame] | 429 | |
| 430 | gsm411_send_sms(net, vsub, sms); |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 431 | return 0; |
| 432 | } |
| 433 | |
| 434 | static int sms_subscr_cb(unsigned int subsys, unsigned int signal, |
| 435 | void *handler_data, void *signal_data) |
| 436 | { |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 437 | struct vlr_subscr *vsub = signal_data; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 438 | |
| 439 | if (signal != S_SUBSCR_ATTACHED) |
| 440 | return 0; |
| 441 | |
| 442 | /* this is readyForSM */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 443 | return sub_ready_for_sm(handler_data, vsub); |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 444 | } |
| 445 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 446 | static int sms_sms_cb(unsigned int subsys, unsigned int signal, |
| 447 | void *handler_data, void *signal_data) |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 448 | { |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 449 | struct gsm_network *network = handler_data; |
| 450 | struct sms_signal_data *sig_sms = signal_data; |
| 451 | struct gsm_sms_pending *pending; |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 452 | struct vlr_subscr *vsub; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 453 | |
| 454 | /* We got a new SMS and maybe should launch the queue again. */ |
| 455 | if (signal == S_SMS_SUBMITTED || signal == S_SMS_SMMA) { |
Holger Hans Peter Freyther | 024dc77 | 2014-02-24 14:29:27 +0100 | [diff] [blame] | 456 | /* TODO: For SMMA we might want to re-use the radio connection. */ |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 457 | sms_queue_trigger(network->sms_queue); |
| 458 | return 0; |
| 459 | } |
| 460 | |
| 461 | if (!sig_sms->sms) |
| 462 | return -1; |
| 463 | |
| 464 | |
| 465 | /* |
| 466 | * Find the entry of our queue. The SMS subsystem will submit |
| 467 | * sms that are not in our control as we just have a channel |
| 468 | * open anyway. |
| 469 | */ |
Stefan Sperling | 87cba1f | 2018-01-22 17:05:37 +0100 | [diff] [blame] | 470 | pending = sms_find_pending(network->sms_queue, sig_sms->sms->id); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 471 | if (!pending) |
| 472 | return 0; |
| 473 | |
| 474 | switch (signal) { |
| 475 | case S_SMS_DELIVERED: |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 476 | /* Remember the subscriber and clear the pending entry */ |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 477 | network->sms_queue->pending -= 1; |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 478 | vsub = vlr_subscr_get(pending->vsub); |
Stefan Sperling | 6ba2d5a | 2018-01-18 18:55:26 +0100 | [diff] [blame] | 479 | db_sms_delete_sent_message_by_id(pending->sms_id); |
Harald Welte | 37a3ae8 | 2018-04-14 20:53:36 +0200 | [diff] [blame] | 480 | sms_pending_free(pending); |
Holger Hans Peter Freyther | 93de8b2 | 2014-02-24 16:13:04 +0100 | [diff] [blame] | 481 | /* Attempt to send another SMS to this subscriber */ |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 482 | sms_send_next(vsub); |
| 483 | vlr_subscr_put(vsub); |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 484 | break; |
| 485 | case S_SMS_MEM_EXCEEDED: |
| 486 | network->sms_queue->pending -= 1; |
| 487 | sms_pending_free(pending); |
| 488 | sms_queue_trigger(network->sms_queue); |
| 489 | break; |
| 490 | case S_SMS_UNKNOWN_ERROR: |
| 491 | /* |
| 492 | * There can be many reasons for this failure. E.g. the paging |
| 493 | * timed out, the subscriber was not paged at all, or there was |
| 494 | * a protocol error. The current strategy is to try sending the |
| 495 | * next SMS for busy/oom and to retransmit when we have paged. |
| 496 | * |
| 497 | * When the paging expires three times we will disable the |
| 498 | * subscriber. If we have some kind of other transmit error we |
| 499 | * should flag the SMS as bad. |
| 500 | */ |
| 501 | switch (sig_sms->paging_result) { |
| 502 | case 0: |
| 503 | /* BAD SMS? */ |
| 504 | db_sms_inc_deliver_attempts(sig_sms->sms); |
| 505 | sms_pending_failed(pending, 0); |
| 506 | break; |
| 507 | case GSM_PAGING_EXPIRED: |
| 508 | sms_pending_failed(pending, 1); |
| 509 | break; |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 510 | case GSM_PAGING_BUSY: |
| 511 | network->sms_queue->pending -= 1; |
| 512 | sms_pending_free(pending); |
| 513 | sms_queue_trigger(network->sms_queue); |
| 514 | break; |
| 515 | default: |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 516 | LOGP(DLSMS, LOGL_ERROR, "Unhandled result: %d\n", |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 517 | sig_sms->paging_result); |
| 518 | } |
| 519 | break; |
| 520 | default: |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 521 | LOGP(DLSMS, LOGL_ERROR, "Unhandled result: %d\n", |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 522 | sig_sms->paging_result); |
| 523 | } |
| 524 | |
Stefan Sperling | 14e0517 | 2018-01-22 17:31:20 +0100 | [diff] [blame] | 525 | /* While here, attempt to remove an expired SMS from the DB. */ |
| 526 | db_sms_delete_oldest_expired_message(); |
| 527 | |
Holger Hans Peter Freyther | 1716406 | 2010-12-24 21:39:55 +0100 | [diff] [blame] | 528 | return 0; |
Holger Hans Peter Freyther | 11b28f9 | 2010-12-24 13:48:27 +0100 | [diff] [blame] | 529 | } |
Holger Hans Peter Freyther | 81c0e25 | 2010-12-25 14:08:00 +0100 | [diff] [blame] | 530 | |
| 531 | /* VTY helper functions */ |
| 532 | int sms_queue_stats(struct gsm_sms_queue *smsq, struct vty *vty) |
| 533 | { |
| 534 | struct gsm_sms_pending *pending; |
| 535 | |
| 536 | vty_out(vty, "SMSqueue with max_pending: %d pending: %d%s", |
| 537 | smsq->max_pending, smsq->pending, VTY_NEWLINE); |
| 538 | |
| 539 | llist_for_each_entry(pending, &smsq->pending_sms, entry) |
Holger Hans Peter Freyther | 583e9ae | 2010-12-27 20:19:48 +0100 | [diff] [blame] | 540 | vty_out(vty, " SMS Pending for Subscriber: %llu SMS: %llu Failed: %d.%s", |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 541 | pending->vsub->id, pending->sms_id, |
Holger Hans Peter Freyther | 583e9ae | 2010-12-27 20:19:48 +0100 | [diff] [blame] | 542 | pending->failed_attempts, VTY_NEWLINE); |
Holger Hans Peter Freyther | 81c0e25 | 2010-12-25 14:08:00 +0100 | [diff] [blame] | 543 | return 0; |
| 544 | } |
Holger Hans Peter Freyther | 3c6f6c2 | 2010-12-25 14:25:12 +0100 | [diff] [blame] | 545 | |
| 546 | int sms_queue_set_max_pending(struct gsm_sms_queue *smsq, int max_pending) |
| 547 | { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 548 | LOGP(DLSMS, LOGL_NOTICE, "SMSqueue old max: %d new: %d\n", |
Holger Hans Peter Freyther | 3c6f6c2 | 2010-12-25 14:25:12 +0100 | [diff] [blame] | 549 | smsq->max_pending, max_pending); |
| 550 | smsq->max_pending = max_pending; |
| 551 | return 0; |
| 552 | } |
Holger Hans Peter Freyther | 4dcc5e5 | 2010-12-25 14:38:30 +0100 | [diff] [blame] | 553 | |
Holger Hans Peter Freyther | 994dcbb | 2010-12-25 14:50:50 +0100 | [diff] [blame] | 554 | int sms_queue_set_max_failure(struct gsm_sms_queue *smsq, int max_fail) |
| 555 | { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 556 | LOGP(DLSMS, LOGL_NOTICE, "SMSqueue max failure old: %d new: %d\n", |
Holger Hans Peter Freyther | 994dcbb | 2010-12-25 14:50:50 +0100 | [diff] [blame] | 557 | smsq->max_fail, max_fail); |
| 558 | smsq->max_fail = max_fail; |
| 559 | return 0; |
| 560 | } |
| 561 | |
Holger Hans Peter Freyther | 4dcc5e5 | 2010-12-25 14:38:30 +0100 | [diff] [blame] | 562 | int sms_queue_clear(struct gsm_sms_queue *smsq) |
| 563 | { |
| 564 | struct gsm_sms_pending *pending, *tmp; |
| 565 | |
| 566 | llist_for_each_entry_safe(pending, tmp, &smsq->pending_sms, entry) { |
Holger Hans Peter Freyther | eff40949 | 2012-11-10 19:46:58 +0100 | [diff] [blame] | 567 | LOGP(DLSMS, LOGL_NOTICE, |
Harald Welte | 2483f1b | 2016-06-19 18:06:02 +0200 | [diff] [blame] | 568 | "SMSqueue clearing for sub %llu\n", pending->vsub->id); |
Holger Hans Peter Freyther | 4dcc5e5 | 2010-12-25 14:38:30 +0100 | [diff] [blame] | 569 | sms_pending_free(pending); |
| 570 | } |
| 571 | |
Holger Hans Peter Freyther | 96e9f08 | 2010-12-28 14:09:07 +0100 | [diff] [blame] | 572 | smsq->pending = 0; |
Holger Hans Peter Freyther | 4dcc5e5 | 2010-12-25 14:38:30 +0100 | [diff] [blame] | 573 | return 0; |
| 574 | } |