blob: 2727d0dd3434f878ddfcf902e8190f198086d339 [file] [log] [blame]
Daniel Willmann1264cb42010-10-21 15:00:36 +02001/* SNMP-like status interface
2 *
3 * (C) 2010-2011 by Daniel Willmann <daniel@totalueberwachung.de>
4 * (C) 2010-2011 by On-Waves
5 *
6 * All Rights Reserved
7 *
8 * This program is free software; you can redistribute it and/or modify
9 * it under the terms of the GNU General Public License as published by
10 * the Free Software Foundation; either version 2 of the License, or
11 * (at your option) any later version.
12 *
13 * This program is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
16 * GNU General Public License for more details.
17 *
18 * You should have received a copy of the GNU General Public License along
19 * with this program; if not, write to the Free Software Foundation, Inc.,
20 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
21 *
22 */
23
24#include <errno.h>
Daniel Willmann0834a342011-07-19 12:12:10 +020025#include <inttypes.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020026#include <stdio.h>
27#include <stdlib.h>
28#include <string.h>
29#include <time.h>
30#include <unistd.h>
31
32#include <arpa/inet.h>
33
34#include <netinet/tcp.h>
35
36#include <sys/fcntl.h>
37#include <sys/ioctl.h>
38#include <sys/socket.h>
39#include <sys/types.h>
40
41#include <openbsc/control_cmd.h>
Daniel Willmann782974b2011-07-22 17:55:42 +020042#include <openbsc/control_if.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020043#include <openbsc/debug.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020044#include <openbsc/gsm_data.h>
45#include <openbsc/ipaccess.h>
46#include <openbsc/socket.h>
Pablo Neira Ayuso10dfc262011-08-17 22:44:07 +020047#include <osmocom/abis/subchan_demux.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020048
49#include <openbsc/abis_rsl.h>
50#include <openbsc/abis_nm.h>
51
52#include <osmocom/core/msgb.h>
Daniel Willmanne9f58942011-04-21 11:43:55 +020053#include <osmocom/core/rate_ctr.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020054#include <osmocom/core/select.h>
Daniel Willmanne9f58942011-04-21 11:43:55 +020055#include <osmocom/core/statistics.h>
Daniel Willmann1264cb42010-10-21 15:00:36 +020056#include <osmocom/core/talloc.h>
57
58#include <osmocom/gsm/tlv.h>
59
60#include <osmocom/vty/command.h>
61#include <osmocom/vty/vector.h>
62
Pablo Neira Ayuso10dfc262011-08-17 22:44:07 +020063#include <osmocom/abis/e1_input.h>
64#include <osmocom/abis/ipa.h>
65
Daniel Willmann1264cb42010-10-21 15:00:36 +020066vector ctrl_node_vec;
67
Daniel Willmann35a1b3b2011-05-06 16:38:11 +020068/* Send command to all */
69int ctrl_cmd_send_to_all(struct ctrl_handle *ctrl, struct ctrl_cmd *cmd)
70{
71 struct ctrl_connection *ccon;
72 int ret = 0;
73
74 llist_for_each_entry(ccon, &ctrl->ccon_list, list_entry) {
75 if (ccon == cmd->ccon)
76 continue;
77 if (ctrl_cmd_send(&ccon->write_queue, cmd))
78 ret++;
79 }
80 return ret;
81}
82
Daniel Willmann1264cb42010-10-21 15:00:36 +020083int ctrl_cmd_send(struct osmo_wqueue *queue, struct ctrl_cmd *cmd)
84{
85 int ret;
86 struct msgb *msg;
87
88 msg = ctrl_cmd_make(cmd);
89 if (!msg) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +020090 LOGP(DCTRL, LOGL_ERROR, "Could not generate msg\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +020091 return -1;
92 }
93
94 ipaccess_prepend_header_ext(msg, IPAC_PROTO_EXT_CTRL);
95 ipaccess_prepend_header(msg, IPAC_PROTO_OSMO);
96
97 ret = osmo_wqueue_enqueue(queue, msg);
98 if (ret != 0) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +020099 LOGP(DCTRL, LOGL_ERROR, "Failed to enqueue the command.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200100 msgb_free(msg);
101 }
102 return ret;
103}
104
Daniel Willmannf2e75d42011-07-22 18:08:31 +0200105struct ctrl_cmd *ctrl_cmd_trap(struct ctrl_cmd *cmd)
106{
107 struct ctrl_cmd *trap;
108
109 trap = ctrl_cmd_cpy(tall_bsc_ctx, cmd);
110 if (!trap)
111 return NULL;
112
113 trap->ccon = cmd->ccon;
114 trap->type = CTRL_TYPE_TRAP;
115 return trap;
116}
117
Daniel Willmann1264cb42010-10-21 15:00:36 +0200118static void control_close_conn(struct ctrl_connection *ccon)
119{
Harald Welte6d96dd72013-03-16 10:13:04 +0100120 osmo_wqueue_clear(&ccon->write_queue);
Daniel Willmann1264cb42010-10-21 15:00:36 +0200121 close(ccon->write_queue.bfd.fd);
122 osmo_fd_unregister(&ccon->write_queue.bfd);
Daniel Willmann0e0cf372011-05-06 16:37:25 +0200123 llist_del(&ccon->list_entry);
Daniel Willmann1264cb42010-10-21 15:00:36 +0200124 if (ccon->closed_cb)
125 ccon->closed_cb(ccon);
126 talloc_free(ccon);
127}
128
129static int handle_control_read(struct osmo_fd * bfd)
130{
Pablo Neira Ayuso10dfc262011-08-17 22:44:07 +0200131 int ret = -1;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200132 struct osmo_wqueue *queue;
133 struct ctrl_connection *ccon;
134 struct ipaccess_head *iph;
135 struct ipaccess_head_ext *iph_ext;
Alexander Huemer1d3634e2011-10-12 00:29:30 +0200136 struct msgb *msg = NULL;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200137 struct ctrl_cmd *cmd;
138 struct ctrl_handle *ctrl = bfd->data;
139
140 queue = container_of(bfd, struct osmo_wqueue, bfd);
141 ccon = container_of(queue, struct ctrl_connection, write_queue);
142
Pablo Neira Ayuso10dfc262011-08-17 22:44:07 +0200143 ret = ipa_msg_recv(bfd->fd, &msg);
144 if (ret <= 0) {
145 if (ret == 0)
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200146 LOGP(DCTRL, LOGL_INFO, "The control connection was closed\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200147 else
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200148 LOGP(DCTRL, LOGL_ERROR, "Failed to parse ip access message: %d\n", ret);
Daniel Willmann1264cb42010-10-21 15:00:36 +0200149
150 goto err;
151 }
152
153 if (msg->len < sizeof(*iph) + sizeof(*iph_ext)) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200154 LOGP(DCTRL, LOGL_ERROR, "The message is too short.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200155 goto err;
156 }
157
158 iph = (struct ipaccess_head *) msg->data;
159 if (iph->proto != IPAC_PROTO_OSMO) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200160 LOGP(DCTRL, LOGL_ERROR, "Protocol mismatch. We got 0x%x\n", iph->proto);
Daniel Willmann1264cb42010-10-21 15:00:36 +0200161 goto err;
162 }
163
164 iph_ext = (struct ipaccess_head_ext *) iph->data;
165 if (iph_ext->proto != IPAC_PROTO_EXT_CTRL) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200166 LOGP(DCTRL, LOGL_ERROR, "Extended protocol mismatch. We got 0x%x\n", iph_ext->proto);
Daniel Willmann1264cb42010-10-21 15:00:36 +0200167 goto err;
168 }
169
170 msg->l2h = iph_ext->data;
171
172 cmd = ctrl_cmd_parse(ccon, msg);
173
174 if (cmd) {
175 cmd->ccon = ccon;
Holger Hans Peter Freytherea62a382014-03-23 16:25:16 +0100176 if (ctrl->handler(cmd, ctrl->gsmnet) != CTRL_CMD_HANDLED) {
Daniel Willmann1264cb42010-10-21 15:00:36 +0200177 ctrl_cmd_send(queue, cmd);
178 talloc_free(cmd);
179 }
180 } else {
181 cmd = talloc_zero(ccon, struct ctrl_cmd);
182 if (!cmd)
183 goto err;
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200184 LOGP(DCTRL, LOGL_ERROR, "Command parser error.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200185 cmd->type = CTRL_TYPE_ERROR;
186 cmd->id = "err";
187 cmd->reply = "Command parser error.";
188 ctrl_cmd_send(queue, cmd);
189 talloc_free(cmd);
190 }
191
192 msgb_free(msg);
193 return 0;
194
195err:
196 control_close_conn(ccon);
197 msgb_free(msg);
198 return ret;
199}
200
201static int control_write_cb(struct osmo_fd *bfd, struct msgb *msg)
202{
203 int rc;
204
205 rc = write(bfd->fd, msg->data, msg->len);
206 if (rc != msg->len)
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200207 LOGP(DCTRL, LOGL_ERROR, "Failed to write message to the control connection.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200208
209 return rc;
210}
211
212static struct ctrl_connection *ctrl_connection_alloc(void *ctx)
213{
214 struct ctrl_connection *ccon = talloc_zero(ctx, struct ctrl_connection);
215 if (!ccon)
216 return NULL;
217
218 osmo_wqueue_init(&ccon->write_queue, 100);
219 /* Error handling here? */
220
221 INIT_LLIST_HEAD(&ccon->cmds);
222 return ccon;
223}
224
225static int listen_fd_cb(struct osmo_fd *listen_bfd, unsigned int what)
226{
227 int ret, fd, on;
Daniel Willmann0e0cf372011-05-06 16:37:25 +0200228 struct ctrl_handle *ctrl;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200229 struct ctrl_connection *ccon;
230 struct sockaddr_in sa;
231 socklen_t sa_len = sizeof(sa);
232
233
234 if (!(what & BSC_FD_READ))
235 return 0;
236
237 fd = accept(listen_bfd->fd, (struct sockaddr *) &sa, &sa_len);
238 if (fd < 0) {
239 perror("accept");
240 return fd;
241 }
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200242 LOGP(DCTRL, LOGL_INFO, "accept()ed new control connection from %s\n",
Daniel Willmann1264cb42010-10-21 15:00:36 +0200243 inet_ntoa(sa.sin_addr));
244
245 on = 1;
246 ret = setsockopt(fd, IPPROTO_TCP, TCP_NODELAY, &on, sizeof(on));
247 if (ret != 0) {
248 LOGP(DNAT, LOGL_ERROR, "Failed to set TCP_NODELAY: %s\n", strerror(errno));
249 close(fd);
250 return ret;
251 }
252 ccon = ctrl_connection_alloc(listen_bfd->data);
253 if (!ccon) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200254 LOGP(DCTRL, LOGL_ERROR, "Failed to allocate.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200255 close(fd);
256 return -1;
257 }
258
Daniel Willmann0e0cf372011-05-06 16:37:25 +0200259 ctrl = listen_bfd->data;
260 ccon->write_queue.bfd.data = ctrl;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200261 ccon->write_queue.bfd.fd = fd;
262 ccon->write_queue.bfd.when = BSC_FD_READ;
263 ccon->write_queue.read_cb = handle_control_read;
264 ccon->write_queue.write_cb = control_write_cb;
265
266 ret = osmo_fd_register(&ccon->write_queue.bfd);
267 if (ret < 0) {
Holger Hans Peter Freyther19abc952011-08-22 23:37:02 +0200268 LOGP(DCTRL, LOGL_ERROR, "Could not register FD.\n");
Daniel Willmann1264cb42010-10-21 15:00:36 +0200269 close(ccon->write_queue.bfd.fd);
270 talloc_free(ccon);
271 }
272
Daniel Willmann0e0cf372011-05-06 16:37:25 +0200273 llist_add(&ccon->list_entry, &ctrl->ccon_list);
274
Daniel Willmann1264cb42010-10-21 15:00:36 +0200275 return ret;
276}
277
Daniel Willmanne9f58942011-04-21 11:43:55 +0200278static uint64_t get_rate_ctr_value(const struct rate_ctr *ctr, int intv)
279{
280 if (intv >= RATE_CTR_INTV_NUM)
281 return 0;
282
283 /* Absolute value */
284 if (intv == -1) {
285 return ctr->current;
286 } else {
287 return ctr->intv[intv].rate;
288 }
289}
290
291static char *get_all_rate_ctr_in_group(const struct rate_ctr_group *ctrg, int intv)
292{
293 int i;
294 char *counters = talloc_strdup(tall_bsc_ctx, "");
295 if (!counters)
296 return NULL;
297
298 for (i=0;i<ctrg->desc->num_ctr;i++) {
Daniel Willmann0834a342011-07-19 12:12:10 +0200299 counters = talloc_asprintf_append(counters, "\n%s.%u.%s %"PRIu64,
Daniel Willmanne9f58942011-04-21 11:43:55 +0200300 ctrg->desc->group_name_prefix, ctrg->idx,
301 ctrg->desc->ctr_desc[i].name,
302 get_rate_ctr_value(&ctrg->ctr[i], intv));
303 if (!counters)
304 return NULL;
305 }
306 return counters;
307}
308
309static int get_rate_ctr_group(const char *ctr_group, int intv, struct ctrl_cmd *cmd)
310{
311 int i;
312 char *counters;
313 struct rate_ctr_group *ctrg;
314
315 cmd->reply = talloc_asprintf(cmd, "All counters in group %s", ctr_group);
316 if (!cmd->reply)
317 goto oom;
318
319 for (i=0;;i++) {
320 ctrg = rate_ctr_get_group_by_name_idx(ctr_group, i);
321 if (!ctrg)
322 break;
323
324 counters = get_all_rate_ctr_in_group(ctrg, intv);
325 if (!counters)
326 goto oom;
327
328 cmd->reply = talloc_asprintf_append(cmd->reply, "%s", counters);
329 talloc_free(counters);
330 if (!cmd->reply)
331 goto oom;
332 }
333
334 /* We found no counter group by that name */
335 if (i == 0) {
336 cmd->reply = talloc_asprintf(cmd, "No counter group with name %s.", ctr_group);
337 return CTRL_CMD_ERROR;
338 }
339
340 return CTRL_CMD_REPLY;
341oom:
342 cmd->reply = "OOM.";
343 return CTRL_CMD_ERROR;
344}
345
346static int get_rate_ctr_group_idx(const struct rate_ctr_group *ctrg, int intv, struct ctrl_cmd *cmd)
347{
348 char *counters;
349
350 counters = get_all_rate_ctr_in_group(ctrg, intv);
351 if (!counters)
352 goto oom;
353
354 cmd->reply = talloc_asprintf(cmd, "All counters in %s.%u%s",
355 ctrg->desc->group_name_prefix, ctrg->idx, counters);
356 talloc_free(counters);
357 if (!cmd->reply)
358 goto oom;
359
360 return CTRL_CMD_REPLY;
361oom:
362 cmd->reply = "OOM.";
363 return CTRL_CMD_ERROR;
364}
365
366/* rate_ctr */
367CTRL_CMD_DEFINE(rate_ctr, "rate_ctr *");
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200368static int get_rate_ctr(struct ctrl_cmd *cmd, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200369{
370 int intv;
371 unsigned int idx;
372 char *ctr_group, *ctr_idx, *ctr_name, *tmp, *dup, *saveptr, *interval;
373 struct rate_ctr_group *ctrg;
374 const struct rate_ctr *ctr;
375
376 dup = talloc_strdup(cmd, cmd->variable);
377 if (!dup)
378 goto oom;
379
380 /* Skip over possible prefixes (net.) */
381 tmp = strstr(dup, "rate_ctr");
382 if (!tmp) {
383 talloc_free(dup);
384 cmd->reply = "rate_ctr not a token in rate_ctr command!";
385 goto err;
386 }
387
388 strtok_r(tmp, ".", &saveptr);
389 interval = strtok_r(NULL, ".", &saveptr);
390 if (!interval) {
391 talloc_free(dup);
392 cmd->reply = "Missing interval.";
393 goto err;
394 }
395
396 if (!strcmp(interval, "abs")) {
397 intv = -1;
398 } else if (!strcmp(interval, "per_sec")) {
399 intv = RATE_CTR_INTV_SEC;
400 } else if (!strcmp(interval, "per_min")) {
401 intv = RATE_CTR_INTV_MIN;
402 } else if (!strcmp(interval, "per_hour")) {
403 intv = RATE_CTR_INTV_HOUR;
404 } else if (!strcmp(interval, "per_day")) {
405 intv = RATE_CTR_INTV_DAY;
406 } else {
407 talloc_free(dup);
408 cmd->reply = "Wrong interval.";
409 goto err;
410 }
411
412 ctr_group = strtok_r(NULL, ".", &saveptr);
413 tmp = strtok_r(NULL, ".", &saveptr);
414 if (!ctr_group || !tmp) {
415 talloc_free(dup);
416 cmd->reply = "Counter group must be of form a.b";
417 goto err;
418 }
419 ctr_group[strlen(ctr_group)] = '.';
420
421 ctr_idx = strtok_r(NULL, ".", &saveptr);
422 if (!ctr_idx) {
423 talloc_free(dup);
424 return get_rate_ctr_group(ctr_group, intv, cmd);
425 }
426 idx = atoi(ctr_idx);
427
428 ctrg = rate_ctr_get_group_by_name_idx(ctr_group, idx);
429 if (!ctrg) {
430 talloc_free(dup);
431 cmd->reply = "Counter group not found.";
432 goto err;
433 }
434
435 ctr_name = strtok_r(NULL, "\0", &saveptr);
436 if (!ctr_name) {
437 talloc_free(dup);
438 return get_rate_ctr_group_idx(ctrg, intv, cmd);
439 }
440
441 ctr = rate_ctr_get_by_name(ctrg, ctr_name);
442 if (!ctr) {
443 cmd->reply = "Counter name not found.";
444 talloc_free(dup);
445 goto err;
446 }
447
448 talloc_free(dup);
449
Holger Hans Peter Freytherad6451f2012-03-16 12:18:39 +0100450 cmd->reply = talloc_asprintf(cmd, "%"PRIu64, get_rate_ctr_value(ctr, intv));
Daniel Willmanne9f58942011-04-21 11:43:55 +0200451 if (!cmd->reply)
452 goto oom;
453
454 return CTRL_CMD_REPLY;
455oom:
456 cmd->reply = "OOM";
457err:
458 return CTRL_CMD_ERROR;
459}
460
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200461static int set_rate_ctr(struct ctrl_cmd *cmd, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200462{
463 cmd->reply = "Can't set rate counter.";
464
465 return CTRL_CMD_ERROR;
466}
467
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200468static int verify_rate_ctr(struct ctrl_cmd *cmd, const char *value, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200469{
470 return 0;
471}
472
473/* counter */
474CTRL_CMD_DEFINE(counter, "counter *");
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200475static int get_counter(struct ctrl_cmd *cmd, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200476{
477 char *ctr_name, *tmp, *dup, *saveptr;
478 struct osmo_counter *counter;
479
480 cmd->reply = "OOM";
481 dup = talloc_strdup(cmd, cmd->variable);
482 if (!dup)
483 goto err;
484
485
486 tmp = strstr(dup, "counter");
487 if (!tmp) {
488 talloc_free(dup);
489 goto err;
490 }
491
492 strtok_r(tmp, ".", &saveptr);
493 ctr_name = strtok_r(NULL, "\0", &saveptr);
494
495 if (!ctr_name)
496 goto err;
497
498 counter = osmo_counter_get_by_name(ctr_name);
499 if (!counter) {
500 cmd->reply = "Counter name not found.";
501 talloc_free(dup);
502 goto err;
503 }
504
505 talloc_free(dup);
506
507 cmd->reply = talloc_asprintf(cmd, "%lu", counter->value);
508 if (!cmd->reply) {
509 cmd->reply = "OOM";
510 goto err;
511 }
512
513 return CTRL_CMD_REPLY;
514err:
515 return CTRL_CMD_ERROR;
516}
517
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200518static int set_counter(struct ctrl_cmd *cmd, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200519{
520
521 cmd->reply = "Can't set counter.";
522
523 return CTRL_CMD_ERROR;
524}
525
Daniel Willmannf7c74e52011-08-05 11:48:18 +0200526static int verify_counter(struct ctrl_cmd *cmd, const char *value, void *data)
Daniel Willmanne9f58942011-04-21 11:43:55 +0200527{
528 return 0;
529}
530
Holger Hans Peter Freytherea62a382014-03-23 16:25:16 +0100531struct ctrl_handle *controlif_setup(struct gsm_network *gsmnet, uint16_t port,
532 ctrl_cmd_handler handler)
Daniel Willmann1264cb42010-10-21 15:00:36 +0200533{
534 int ret;
535 struct ctrl_handle *ctrl;
536
537 ctrl = talloc_zero(tall_bsc_ctx, struct ctrl_handle);
538 if (!ctrl)
Daniel Willmann782974b2011-07-22 17:55:42 +0200539 return NULL;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200540
Daniel Willmann0e0cf372011-05-06 16:37:25 +0200541 INIT_LLIST_HEAD(&ctrl->ccon_list);
542
Daniel Willmann1264cb42010-10-21 15:00:36 +0200543 ctrl->gsmnet = gsmnet;
Holger Hans Peter Freytherea62a382014-03-23 16:25:16 +0100544 ctrl->handler = handler;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200545
546 ctrl_node_vec = vector_init(5);
Daniel Willmann9f973162011-08-05 12:22:35 +0200547 if (!ctrl_node_vec)
548 goto err;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200549
550 /* Listen for control connections */
Daniel Willmannb06dd302011-07-29 10:41:24 +0200551 ret = make_sock(&ctrl->listen_fd, IPPROTO_TCP, INADDR_LOOPBACK, port,
Daniel Willmann1264cb42010-10-21 15:00:36 +0200552 0, listen_fd_cb, ctrl);
Daniel Willmann9f973162011-08-05 12:22:35 +0200553 if (ret < 0)
554 goto err_vec;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200555
Daniel Willmann9f973162011-08-05 12:22:35 +0200556 ret = ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_rate_ctr);
557 if (ret)
558 goto err_vec;
559 ret = ctrl_cmd_install(CTRL_NODE_ROOT, &cmd_counter);
560 if (ret)
561 goto err_vec;
Daniel Willmanne9f58942011-04-21 11:43:55 +0200562
Daniel Willmann782974b2011-07-22 17:55:42 +0200563 return ctrl;
Daniel Willmann9f973162011-08-05 12:22:35 +0200564err_vec:
565 vector_free(ctrl_node_vec);
566 ctrl_node_vec = NULL;
567err:
568 talloc_free(ctrl);
569 return NULL;
Daniel Willmann1264cb42010-10-21 15:00:36 +0200570}