commit 6b60d52abf0a12a21f6f11150a5e3a0dd3eceda6
author Vadim Yanitskiy <vyanitskiy@sysmocom.de> Thu Sep 30 22:54:07 2021 +0600
committer Vadim Yanitskiy <vyanitskiy@sysmocom.de> Fri Oct 01 15:47:05 2021 +0600
tree 3a98e029b5a3da322eaa6e9a555b5a867b9b0f76
parent 137efc9b1834d60569b676481360429be5de7509

fix rsl_chan_nr_str_{buf,c}(): enlarge the buffer size

20 bytes is not enough for some VAMOS specific channel number values,
so the resulting string representation gets truncated by snprintf():

  expected: "VAMOS TCH/H(0) on TS4\0"
  actual:   "VAMOS TCH/H(0) on T\0"

Let's enlarge the buffers to 32 bytes.

Change-Id: I68d839f4ab742cf56de34e7e22572a1163aec2da

src/gsm/rsl.c

diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c
index 0574966..e648d82 100644
--- a/src/gsm/rsl.c
+++ b/src/gsm/rsl.c
@@ -268,7 +268,7 @@
  */
 const char *rsl_chan_nr_str(uint8_t chan_nr)
 {
-	static __thread char str[20];
+	static __thread char str[32];
 	return rsl_chan_nr_str_buf(str, sizeof(str), chan_nr);
 }
 
@@ -279,10 +279,10 @@
  */
 char *rsl_chan_nr_str_c(const void *ctx, uint8_t chan_nr)
 {
-	char *str = talloc_size(ctx, 20);
+	char *str = talloc_size(ctx, 32);
 	if (!str)
 		return NULL;
-	return rsl_chan_nr_str_buf(str, 20, chan_nr);
+	return rsl_chan_nr_str_buf(str, 32, chan_nr);
 }
 
 static const struct value_string rsl_err_vals[] = {