library: Ensure setverdict(fail) is followed by mtc.stop
This will prevent subsequent failures from overwriting the verdict so we
can easily see the root cause of the test failure.
Using testcase.stop instead for errors internal to our test
infrastructure to mark them as test errors instead of failed.
Change-Id: Idc6819aaf0b01e70c38fad828dd44dcec6bdd778
diff --git a/library/BSSGP_Emulation.ttcn b/library/BSSGP_Emulation.ttcn
index f51d539..8b3b9eb 100644
--- a/library/BSSGP_Emulation.ttcn
+++ b/library/BSSGP_Emulation.ttcn
@@ -288,8 +288,7 @@
return;
}
}
- setverdict(fail, "Client Table full");
- self.stop;
+ testcase.stop("Client Table full");
}
private function f_tbl_client_del(hexstring imsi, BSSGP_Client_CT vc_conn) runs on BSSGP_CT {
@@ -299,7 +298,7 @@
if (ClientTable[i].comp_ref != vc_conn) {
setverdict(fail, "Cannot unregister index=", i, " IMSI ", imsi, " registred to ",
ClientTable[i].comp_ref, " from ", vc_conn);
- self.stop;
+ mtc.stop;
}
log("Removing Client IMSI=", imsi, ", index=", i);
ClientTable[i] := {
@@ -313,7 +312,7 @@
}
}
setverdict(fail, "Could not find client for IMSI ", imsi);
- self.stop;
+ mtc.stop;
}
/* TS 44.064 7.2.1.1 LLGMM-ASSIGN */
@@ -344,7 +343,7 @@
}
}
setverdict(fail, "Couldn't find Component for IMSI ", imsi);
- self.stop;
+ mtc.stop;
}
private function f_tbl_comp_by_tlli(OCT4 tlli) runs on BSSGP_CT return BSSGP_Client_CT {
@@ -357,7 +356,7 @@
}
}
setverdict(fail, "Couldn't find Component for TLLI ", tlli);
- self.stop;
+ mtc.stop;
}
private function f_tbl_idx_by_comp(BSSGP_Client_CT comp_ref) runs on BSSGP_CT return integer {
@@ -368,7 +367,7 @@
}
}
setverdict(fail, "Couldn't find Client for Component ", comp_ref);
- self.stop;
+ mtc.stop;
}
private function f_tbl_tlli_by_comp(BSSGP_Client_CT comp_ref) runs on BSSGP_CT return OCT4 {
@@ -380,7 +379,7 @@
}
}
setverdict(fail, "Couldn't find TLLI for Component ", comp_ref);
- self.stop;
+ mtc.stop;
}
altstep as_allstate() runs on BSSGP_CT {
@@ -590,7 +589,7 @@
return c_LLC_SAPI_LLSMS;
}
setverdict(fail, "No LLC SAPI for ", l3_mo);
- self.stop;
+ mtc.stop;
}
private function f_llc_sapi_by_l3_mt(PDU_L3_SGSN_MS l3_mt) return BIT4 {
@@ -602,7 +601,7 @@
return c_LLC_SAPI_LLSMS;
}
setverdict(fail, "No LLC SAPI for ", l3_mt);
- self.stop;
+ mtc.stop;
}