library/Osmocom_Types: fix maximum values passed to f_rnd_int()
It's clearly stated in a comment to this function that the returned
value is 0 <= x < max, so it's always less than the maximum.
Change-Id: If127fc6a2feeddbdd3ea636b56dadf8957941758
diff --git a/library/Osmocom_Types.ttcn b/library/Osmocom_Types.ttcn
index 3c0137c..967beb4 100644
--- a/library/Osmocom_Types.ttcn
+++ b/library/Osmocom_Types.ttcn
@@ -65,7 +65,7 @@
}
/* return hexstring composed of random digits */
-function f_rnd_hexstring(in integer len, in integer max := 15) return hexstring {
+function f_rnd_hexstring(in integer len, in integer max := 16) return hexstring {
var integer i;
var hexstring ret := ''H;
for (i := 0; i < len; i := i + 1) {
@@ -79,7 +79,7 @@
var integer i;
var octetstring ret := ''O;
for (i := 0; i < len; i := i + 1) {
- ret := ret & int2oct(f_rnd_int(255), 1);
+ ret := ret & int2oct(f_rnd_int(256), 1);
}
return ret;
}
@@ -91,7 +91,7 @@
}
function f_rnd_imsi(in hexstring prefix) return hexstring {
- return prefix & f_rnd_hexstring(15 - lengthof(prefix), 9);
+ return prefix & f_rnd_hexstring(15 - lengthof(prefix), 10);
}
function f_rnd_msisdn(in octetstring prefix, integer len := 6) return octetstring {
@@ -249,7 +249,7 @@
/* generate a random 11-bit RA (packet-switched only) */
function f_rnd_ra11_ps() return BIT11 {
- var integer ra11 := f_rnd_int(bit2int('11111111111'B));
+ var integer ra11 := f_rnd_int(bit2int('11111111111'B) + 1);
return int2bit(ra11, 11);
}