bsc: clarify RESET logging: BSSMAP vs RANAP vs BSSMAP-LE
When a RESET-ACK times out, the logs currently are indistinguishable between
BSSMAP and BSSMAP-LE. Add protocol naming for each RESET / RESET-ACK logging to
make sure the information does not need guesswork.
Example of a test failure shown in jenkins:
BSC_Tests.TC_unsol_ass_compl
Stacktrace
Timeout waiting for RESET-ACK after sending RESET
BSC_Tests.ttcn:8295 BSC_Tests control part
BSC_Tests.ttcn:4274 TC_unsol_ass_compl testcase
Nothing conveys that it is (presumably) the background *BSSMAP-LE* timeout
halting the test 5 seconds in, and not an A-interface failure.
Change-Id: I874567e68b8279bf2460b9474241f0a9fe5ff0ff
diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn
index d95506c..fe85e58 100644
--- a/library/BSSAP_LE_Emulation.ttcn
+++ b/library/BSSAP_LE_Emulation.ttcn
@@ -315,13 +315,13 @@
T.start;
alt {
[] BSSAP_LE.receive(tr_BSSAP_LE_UNITDATA_ind(own, peer, tr_BSSMAP_LE_ResetAck)) {
- log("Received RESET-ACK in response to RESET, we're ready to go!");
+ log("BSSMAP-LE: Received RESET-ACK in response to RESET, we're ready to go!");
g_reset_ack_ready := true;
}
[] as_reset_ack();
[] BSSAP_LE.receive { repeat };
[] T.timeout {
- setverdict(fail, "Timeout waiting for RESET-ACK after sending RESET");
+ setverdict(fail, "BSSMAP-LE: Timeout waiting for RESET-ACK after sending RESET");
mtc.stop;
}
}
@@ -347,7 +347,7 @@
private altstep as_reset_ack() runs on BSSAP_LE_Emulation_CT {
var BSSAP_LE_N_UNITDATA_ind ud_ind;
[] BSSAP_LE.receive(tr_BSSAP_LE_UNITDATA_ind(?, ?, tr_BSSMAP_LE_Reset)) -> value ud_ind {
- log("Responding to inbound RESET with RESET-ACK");
+ log("BSSMAP-LE: Responding to inbound RESET with RESET-ACK");
BSSAP_LE.send(ts_BSSAP_LE_UNITDATA_req(ud_ind.callingAddress, ud_ind.calledAddress,
ts_BSSMAP_LE_ResetAck));
g_reset_ack_ready := true;
@@ -569,7 +569,7 @@
}
[wait_seconds == 0] T_reset_ack.timeout {
- setverdict(fail, "Timeout waiting for BSSMAP-LE RESET-ACK");
+ setverdict(fail, "BSSMAP-LE: Timeout waiting for RESET-ACK");
mtc.stop;
}
}