commit 33e5261154f12e21321c8090c4fd276295066d45
author Philipp Maier <pmaier@sysmocom.de> Wed May 30 17:22:02 2018 +0200
committer Harald Welte <laforge@gnumonks.org> Thu Jul 05 15:40:43 2018 +0000
tree 1aa8a598a89a270fa1f55b482d958303ed90102c
parent a59afab67fe44b52b0f7090c77fd9f10a592b05a

GGSN_Tests: test what happens when PCO contains only one DNS entry

When the protocol configuration options (PCO) contain an IPCP container
then lists only one one DNS server (normally there are two included, a
primary and a secondary). Than the parser in osmo-ggsn runs into an
endles loop. This testcase tries to provoke this behavior by sending
PDP CONTEXT ACTIVATE messages with PCO that contain only a single DNS
entry per IPCP container.

The hanging of osmo-ggsn is already fixed (see Depends). However when
Primary and Secondary DNS are in separate IPCP containers, then only
the first IPCP container is parsed (see also OS#3381)

Change-Id: I71761e1f9db7ceac3c3df43d2e539f8c8d53c4fc
Depends: osmo-msc Icffde89f9bc5d8fcadf6e2dd6c0b4de03440edd5
Closes: OS#3288
Related: OS#3381

ggsn_tests/expected-results.xml

diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml
index 1e5da38..383ea39 100644
--- a/ggsn_tests/expected-results.xml
+++ b/ggsn_tests/expected-results.xml
@@ -1,10 +1,17 @@
 <?xml version="1.0"?>
-<testsuite name='GGSN_Tests' tests='11' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'>
+<testsuite name='GGSN_Tests' tests='11' failures='1' errors='0' skipped='0' inconc='0' time='MASKED'>
   <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_ipcp' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_pcodns' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_gtpu_access' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp4_clients_interact' time='MASKED'/>
+  <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_with_single_dns' time='MASKED'/>
+  <testcase classname='GGSN_Tests' name='TC_pdp4_act_deact_with_separate_dns' time='MASKED'>
+    <failure type='fail-verdict'>Secondary DNS IPv4 PCO option not found
+      GGSN_Tests.ttcn:MASKED GGSN_Tests control part
+      GGSN_Tests.ttcn:MASKED TC_pdp4_act_deact_with_separate_dns testcase
+    </failure>
+  </testcase>
   <testcase classname='GGSN_Tests' name='TC_pdp6_act_deact' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp6_act_deact_pcodns' time='MASKED'/>
   <testcase classname='GGSN_Tests' name='TC_pdp6_act_deact_icmp6' time='MASKED'/>