Gitiles
Code Review Sign In
gerrit.osmocom.org / osmo-trx / b0e54265ad3407375f98999d7cdcebfc51320443
commitb0e54265ad3407375f98999d7cdcebfc51320443[log] [tgz]
authorPau Espin Pedrol <pespin@sysmocom.de>Mon Jan 13 16:00:04 2020 +0100
committerPau Espin Pedrol <pespin@sysmocom.de>Mon Jan 13 16:13:28 2020 +0100
tree2d1b8918dc52d5bc7b880f78dd5bc1cb51d59c03
parent62c92805903b992493f7e435823011f7b11dcc34 [diff]
lms: Change radioDevice constructor arg name to avoid masking instance attr

channel number mangling based on multi-arfcn feature being enabled was
moved to generic radioDevice() to reuse code. Hence, the generic parent
constructor sets this->chans to 1 if multi-arfcn feature is requested.
However, LMSDevice constructor argument had same name as the class
instance attribute, taking preference. As a result, if multi-arfcn is
enabled in LMSDevice, the generic constructor first sets this->chans=1
but afterwards LMSDEvice constructor keeps calling .resize() with the
argument value "chans" instead of using this->chans.

Let's rename the argument in all radioDevice child class constructors to
avoid potential future bugs in all of them.

Change-Id: Id6c837e9133f22783dd92a81dfcc493e51bf2d21
6 files changed
tree: 2d1b8918dc52d5bc7b880f78dd5bc1cb51d59c03
  1. CommonLibs/
  2. config/
  3. contrib/
  4. debian/
  5. doc/
  6. GSM/
  7. tests/
  8. Transceiver52M/
  9. utils/
  10. .gitignore
  11. .gitreview
  12. configure.ac
  13. COPYING
  14. git-version-gen
  15. LEGAL
  16. Makefile.am
  17. Makefile.common
  18. README.md
README.md

About OsmTRX

OsmoTRX is a software-defined radio transceiver that implements the Layer 1 physical layer of a BTS comprising the following 3GPP specifications:

  • TS 05.01 "Physical layer on the radio path"
  • TS 05.02 "Multiplexing and Multiple Access on the Radio Path"
  • TS 05.04 "Modulation"
  • TS 05.10 "Radio subsystem synchronization"

OsmoTRX is based on the transceiver code from the OpenBTS project, but setup to operate independently with the purpose of using with non-OpenBTS software and projects, while still maintaining backwards compatibility with OpenBTS when possible. Currently there are numerous features contained in OsmoTRX that extend the functionality of the OpenBTS transceiver. These features include enhanced support for various embedded platforms - notably ARM - and dual channel diversity support for the Fairwaves umtrx.

Homepage

The official homepage of the project is https://osmocom.org/projects/osmotrx/wiki/OsmoTRX

GIT Repository

You can clone from the official osmo-trx.git repository using

    git clone git://git.osmocom.org/osmo-trx.git

There is a cgit interface at http://git.osmocom.org/osmo-trx/

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at User Manual for OsmoTRX can be generated during the build process, and is also available online at http://ftp.osmocom.org/docs/latest/osmotrx-usermanual.pdf.

Mailing List

Discussions related to OsmoTRX are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for OsmoTRX can be seen at https://gerrit.osmocom.org/q/project:osmo-trx+status:open