commit ae91f13ecb8a3db44edad5b41963f59efe3504c1
author Tom Tsou <tom.tsou@ettus.com> Tue Mar 28 14:40:38 2017 -0700
committer Tom Tsou <tom@tsou.cc> Fri Mar 31 21:41:03 2017 +0000
tree b9e6e8430b7d5f1cfbe4d6758cc2c51aecba2d2e
parent 9d53ecf666b95948802384133e696d536deaf3bc

sigProcLib: Remove unreachable code and no-effect checks

Unreachable path and negative value inspection on unsigned
types.

Change-Id: If53b4b03550b0a7656c808cfe96806252153eb2f
Fixes: Coverity CID 165239, 165238, 165236

Transceiver52M/sigProcLib.cpp

diff --git a/Transceiver52M/sigProcLib.cpp b/Transceiver52M/sigProcLib.cpp
index 4c2222c..9673d99 100644
--- a/Transceiver52M/sigProcLib.cpp
+++ b/Transceiver52M/sigProcLib.cpp
@@ -1773,10 +1773,6 @@
   /* Normalize our channel gain */
   *amp = *amp / sync->gain;
 
-  /* Compenate for residual rotation with dual Laurent pulse */
-  if (sps == 4)
-    *amp = *amp * complex(0.0, 1.0);
-
   /* Compensate for residuate time lag */
   *toa = *toa - sync->toa;
 
@@ -1894,7 +1890,7 @@
   int rc, target, head, tail;
   CorrelationSequence *sync;
 
-  if ((tsc < 0) || (tsc > 7))
+  if (tsc > 7)
     return -SIGERR_UNSUPPORTED;
 
   target = 3 + 58 + 16 + 5;
@@ -1913,7 +1909,7 @@
   int rc, target, head, tail;
   CorrelationSequence *sync;
 
-  if ((tsc < 0) || (tsc > 7))
+  if (tsc > 7)
     return -SIGERR_UNSUPPORTED;
 
   target = 3 + 58 + 16 + 5;