fix file descriptor leak in osysmon_file_read
Don't forget to close the file which was opened at the
beginning of this function's scope. Found by Coverity.
Change-Id: Ie1b5734748438c6d785cd96dfa9af6303cd102da
Related: CID#189756
diff --git a/osysmon_file.c b/osysmon_file.c
index 6f826b4..3a228fa 100644
--- a/osysmon_file.c
+++ b/osysmon_file.c
@@ -77,7 +77,7 @@
static void osysmon_file_read(struct osysmon_file *of, struct value_node *parent)
{
char buf[512];
- char *nl;
+ char *s, *nl;
FILE *f;
f = fopen(of->cfg.path, "r");
@@ -85,7 +85,9 @@
value_node_add(parent, parent, of->cfg.name, "<NOTFOUND>");
return;
}
- if (fgets(buf, sizeof(buf), f) == NULL) {
+ s = fgets(buf, sizeof(buf), f);
+ fclose(f);
+ if (s == NULL) {
value_node_add(parent, parent, of->cfg.name, "<EMPTY>");
return;
}