commit 5ccd015371ba013f37e474b9e9f23b845fd17f43
author Holger Hans Peter Freyther <holger@moiji-mobile.com> Sun Jul 14 08:38:24 2013 +0200
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> Sun Jul 14 09:04:50 2013 +0200
tree fa90324a3f0d9b05aaaabeb2f601670bdeb3c68b
parent 995ff35f3913b7e755a0bd1425c3b5bc8d966354

nitb: The subscr->imsi is an array will never be NULL

Array compared against 0 (NO_EFFECT)
array_null: Comparing an array to null is not useful: "subscr->imsi"

Fixes: Coverity CID 1040716

openbsc/src/libbsc/bsc_vty.c

diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index 6c58ff1..b2b7977 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -841,8 +841,7 @@
 	if (subscr->extension)
 		vty_out(vty, "    Extension: %s%s", subscr->extension,
 			VTY_NEWLINE);
-	if (subscr->imsi)
-		vty_out(vty, "    IMSI: %s%s", subscr->imsi, VTY_NEWLINE);
+	vty_out(vty, "    IMSI: %s%s", subscr->imsi, VTY_NEWLINE);
 	if (subscr->tmsi != GSM_RESERVED_TMSI)
 		vty_out(vty, "    TMSI: %08X%s", subscr->tmsi,
 			VTY_NEWLINE);