commit c515551625e647796a26b2cdb43c7c445de69214
author Pascal Quantin <pascal@wireshark.org> Fri Jan 24 17:33:06 2020 +0100
committer Pau Espin Pedrol <pespin@sysmocom.de> Tue Jan 28 13:40:14 2020 +0100
tree 79137b4766b689630b49244ee3c392e83833e2e0
parent 5b71697618ddfa05766064da8d3103fd9c9c3cdb

csn1: Fix an infinite loop in CSN.1 dissector when having more than 255 padding bits

Port of wireshark.git 8b5aa913711b32b1e1bc707919d2a98c1875d443.

Ported-by: Pau Espin Pedrol <pespin@sysmocom.de>
Change-Id: I7f6aecc2c0f300c1a77cd683652969d3f1aa5794

src/csn1.cpp

diff --git a/src/csn1.cpp b/src/csn1.cpp
index 493d471..21bb976 100644
--- a/src/csn1.cpp
+++ b/src/csn1.cpp
@@ -1150,7 +1150,7 @@
         {
           while (remaining_bits_len > 0)
           {
-            guint8 bits_to_handle = remaining_bits_len%8;
+            guint bits_to_handle = remaining_bits_len%8;
             if (bits_to_handle > 0)
             {
 	      LOGPC(DCSN1, LOGL_NOTICE, "%" PRIu64 "|", bitvec_read_field(vector, &readIndex, bits_to_handle));