commit 94a367f224ff756335b29d1ae5954ebcfe33ae15
author Alexander Couzens <lynxis@fe80.eu> Tue Feb 16 16:57:15 2021 +0100
committer laforge <laforge@osmocom.org> Tue Feb 16 21:32:47 2021 +0000
tree 4011f3db6a8d6be68c232a62abe169e4c3bf8e9f
parent 13a12e2e3bf43fbd26e396c841dbeab82108430d

gprs_bssgp: rename gprs_ns_config -> gprs_ns_update_config

Improve the naming of the function to match it's purpose.

Related: SYS#5354
Change-Id: Ib8e4ae734503fd6f6695d9d6767d809e1bf79d22

src/gprs_bssgp_pcu.c

diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c
index 7d793be..ce36c6b 100644
--- a/src/gprs_bssgp_pcu.c
+++ b/src/gprs_bssgp_pcu.c
@@ -1097,10 +1097,11 @@
 	return 0;
 }
 
-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
-		   const struct osmo_sockaddr *local,
-		   const struct osmo_sockaddr *remote,
-		   uint16_t *nsvci, uint16_t valid)
+/* update the ns configuration if needed */
+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
+			  const struct osmo_sockaddr *local,
+			  const struct osmo_sockaddr *remote,
+			  uint16_t *nsvci, uint16_t valid)
 {
 	int rc = 0;
 	if (!bts->nse) {

src/gprs_bssgp_pcu.h

diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h
index 4b0e0aa..db77cbb 100644
--- a/src/gprs_bssgp_pcu.h
+++ b/src/gprs_bssgp_pcu.h
@@ -90,7 +90,7 @@
 		uint16_t mcc, uint16_t mnc, bool mnc_3_digits,
 		uint16_t lac, uint16_t rac, uint16_t cell_id);
 
-int gprs_ns_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
+int gprs_ns_update_config(struct gprs_rlcmac_bts *bts, uint16_t nsei,
 		   const struct osmo_sockaddr *local,
 		   const struct osmo_sockaddr *remote,
 		   uint16_t *nsvci, uint16_t valid);

src/pcu_l1_if.cpp

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 9873469..b6d6786 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -583,7 +583,7 @@
 		return -EINVAL;
 	}
 
-	return gprs_ns_config(bts, info_ind->nsei, local, remote, nsvci, valid);
+	return gprs_ns_update_config(bts, info_ind->nsei, local, remote, nsvci, valid);
 }
 
 static int pcu_rx_info_ind(struct gprs_rlcmac_bts *bts, const struct gsm_pcu_if_info_ind *info_ind)

tests/emu/pcu_emu.cpp

diff --git a/tests/emu/pcu_emu.cpp b/tests/emu/pcu_emu.cpp
index ef573a7..082f8ea 100644
--- a/tests/emu/pcu_emu.cpp
+++ b/tests/emu/pcu_emu.cpp
@@ -108,7 +108,7 @@
 	remote.u.sin.sin_port = htons(sgsn_port);
 
 	pcu = gprs_bssgp_init(bts, 20, 20, 901, 99, false, 1, 0, 0);
-	gprs_ns_config(bts, nsei, &local, &remote, &nsvci, 1);
+	gprs_ns_update_config(bts, nsei, &local, &remote, &nsvci, 1);
 
 	pcu->on_unblock_ack = bvci_unblocked;
 	pcu->on_dl_unit_data = bssgp_data;