commit 5a2b8be3f5c9659cedb56855d2741accfdaeab3d
author Jacob Erlbeck <jerlbeck@sysmocom.de> Tue Jul 14 11:35:21 2015 +0200
committer Jacob Erlbeck <jerlbeck@sysmocom.de> Thu Jul 16 19:24:13 2015 +0200
tree b52de4a174e185c8a372e8ff558e1c3a32f5da6f
parent 2b558857dd720ea0a743d2656873a8c472ecd6b9

alloc: Refactor alloc algorithms to only apply changes on success

Currently these algorithms modify other objects (MS, TBF, PDCH) even
if the allocation will fail later on. To implement an algorithm that
dynamically tries another algorithm on failure (e.g. A after B), the
first (failing) algorithm should not change or damage anything.

This commit refactors algorithm A and B to delay the actual allocation
until it is known that the allocation will not fail.

Ticket: #1934
Sponsored-by: On-Waves ehf

tests/alloc/AllocTest.err

diff --git a/tests/alloc/AllocTest.err b/tests/alloc/AllocTest.err
index c3852fe..da57413 100644
--- a/tests/alloc/AllocTest.err
+++ b/tests/alloc/AllocTest.err
@@ -1,14 +1,14 @@
 No TFI available.
 No TFI available.
 - Failed to find a usable TRX (TFI exhausted)
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
 No TFI available.
 No TFI available.
 No TFI available.
 No TFI available.
 - Failed to find a usable TRX (TFI exhausted)
-- Failed to allocate a TS, no TFI or USF available
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
+- Failed to allocate a TS, no USF available
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
@@ -21,7 +21,7 @@
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
@@ -34,11 +34,11 @@
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
 No TFI available.
 No TFI available.
 - Failed to allocate a TFI
@@ -58,7 +58,7 @@
 No TFI available.
 - Failed to find a usable TRX (TFI exhausted)
   Allocated 160 TBFs (previously -1)
-- Failed to allocate a TS, no TFI or USF available
+- Failed to allocate a TS, no USF available
   Allocated 35 TBFs (previously 160)
 No TFI available.
 No TFI available.