| commit | 43fc4a8690c2b1accda4f6d07865a6ce6b55f4df | [log] [tgz] |
|---|---|---|
| author | Pau Espin Pedrol <pespin@sysmocom.de> | Fri Nov 05 13:36:49 2021 +0100 |
| committer | Pau Espin Pedrol <pespin@sysmocom.de> | Fri Nov 05 20:44:39 2021 +0100 |
| tree | 7fc3012412d26fd0567f1036fcc900ab0fb82ff6 | |
| parent | 7ce56d7c644904c5e90b71fd9c270e478ad18209 [diff] |
vty: Avoid crash in tbf_print_vty_info with null ptr ctrg Previous code did use a ctrg based on MS being EGPRS capable or not. However, an MS being EGPRS capable doesn't mean necessarily that all its TBFs are EGPRS, since we may known about the capability after we already created some previous TBF, so it was not ugpraded. Hence, we were sometimes accessing the wrong NULL ctrg. Let's simply check for non NULL ctrg when deciding what to print. """ Program received signal SIGSEGV, Segmentation fault. 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty@entry=0x897850, prefix=prefix@entry=0x4482cd " ", ctrg=0x0) at utils.c:82 82 utils.c: No such file or directory. (gdb) bt #0 0x00007ffff7561ea6 in vty_out_rate_ctr_group (vty=vty@entry=0x897850, prefix=prefix@entry=0x4482cd " ", ctrg=0x0) at utils.c:82 #1 0x000000000041437b in tbf_print_vty_info (vty=vty@entry=0x897850, tbf=0x3fb61f0) at pcu_vty_functions.cpp:98 #2 0x0000000000414acc in pcu_vty_show_tbf_all (vty=vty@entry=0x897850, bts=bts@entry=0x7be650, flags=4294967295) at pcu_vty_functions.cpp:127 #3 0x000000000041206f in show_tbf (self=<optimized out>, vty=0x897850, argc=<optimized out>, argv=0x7fffffffe040) at pcu_vty.c:1150 #4 0x00007ffff755d167 in cmd_execute_command_real (vline=vline@entry=0x7bc300, vty=vty@entry=0x897850, cmd=<optimized out>) at command.c:2604 """ Related: SYS#5689 Change-Id: I3979bfc12dd3b9a53b34b284537f271c356a3024
This repository contains a C/C++-language implementation of a GPRS Packet Control Unit, as specified by ETSI/3GPP. It is part of the Osmocom Open Source Mobile Communications project.
The Packet Control Unit is terminating the Layer 2 (RLC/MAC) of the GPRS radio interface and adapting it to the Gb Interface (BSSGP+NS Protocol) towards the SGSN.
The PCU interfaces with the physical layer of the radio interface. OsmoPCU is typically used co-located with the BTS, specifically OsmoBTS. For legacy BTSs that run proprietary sotware without an interface to OsmoPCU, you may also co-locate it with the BSC, specifically OsmoBSC
The official homepage of the project is https://osmocom.org/projects/osmopcu/wiki/OsmoPCU
You can clone from the official osmo-pcu.git repository using
git clone git://git.osmocom.org/osmo-pcu.git
There is a cgit interface at http://git.osmocom.org/osmo-pcu/
We provide a user manual as well as a vty reference manual
Please note that a lot of the PCU configuration actually happens inside the BSC, which passes this configuration via A-bis OML to the BTS, which then in turn passes it via the PCU socket into OsmoPCU.
Discussions related to osmo-pcu are happening on the osmocom-net-gprs@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/osmocom-net-gprs for subscription options and the list archive.
Please observe the Osmocom Mailing List Rules when posting.
Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards
We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details
The current patch queue for osmo-pcu can be seen at https://gerrit.osmocom.org/#/q/project:osmo-pcu+status:open