Enable egprs support through PCUIF from BTS/BSC
This VTY command was added due to EGPRS being introduced later as an
experimental feature. It's no longer needed and causes more problems
than goodness (since people sometimes forgets to enable it).
Let's rather simply enable EGPRS support based on what BTS/BSC requests
over PCUIF.
Related: OS#4544
Change-Id: Ic80970a136361584da9c912252a07e7c3c9d85d0
diff --git a/src/pcu_vty.c b/src/pcu_vty.c
index bd83544..5e5dfbe 100644
--- a/src/pcu_vty.c
+++ b/src/pcu_vty.c
@@ -108,9 +108,6 @@
unsigned int i;
vty_out(vty, "pcu%s", VTY_NEWLINE);
- if (bts->egprs_enabled)
- vty_out(vty, " egprs only%s", VTY_NEWLINE);
-
vty_out(vty, " flow-control-interval %d%s", bts->fc_interval,
VTY_NEWLINE);
if (bts->fc_bvc_bucket_size)
@@ -273,29 +270,21 @@
#define EGPRS_STR "EGPRS configuration\n"
-DEFUN_USRATTR(cfg_pcu_egprs,
- cfg_pcu_egprs_cmd,
- X(PCU_VTY_ATTR_NEW_TBF),
- "egprs only",
- EGPRS_STR "Use EGPRS and disable plain GPRS\n")
+DEFUN_DEPRECATED(cfg_pcu_egprs,
+ cfg_pcu_egprs_cmd,
+ "egprs only",
+ EGPRS_STR "Use EGPRS and disable plain GPRS\n")
{
- struct gprs_rlcmac_bts *bts = bts_main_data();
-
- bts->egprs_enabled = true;
-
+ vty_out (vty, "'egprs only' is deprecated, egprs support is controled from BTS/BSC config, this is now a no-op%s", VTY_NEWLINE);
return CMD_SUCCESS;
}
-DEFUN_USRATTR(cfg_pcu_no_egprs,
- cfg_pcu_no_egprs_cmd,
- X(PCU_VTY_ATTR_NEW_TBF),
- "no egprs",
- NO_STR EGPRS_STR)
+DEFUN_DEPRECATED(cfg_pcu_no_egprs,
+ cfg_pcu_no_egprs_cmd,
+ "no egprs",
+ NO_STR EGPRS_STR)
{
- struct gprs_rlcmac_bts *bts = bts_main_data();
-
- bts->egprs_enabled = false;
-
+ vty_out (vty, "'no egprs only' is deprecated, egprs support is controled from BTS/BSC config, this is now a no-op%s", VTY_NEWLINE);
return CMD_SUCCESS;
}