Replace tbf->establish_dl_tbf_on_pacch() refactoring GprsMs functions
ms_new_dl_tbf_assignment() is split into 2 functions, one to
allocate+assign on PACCH and another one for PCH.
This makes a lot clearer the aim of each caller of the function.
Once this is done, it becomes obvious tbf->establish_dl_tbf_on_pacch()
is basically doing the same as ms_new_dl_tbf_assigned_on_pacch() so drop
it.
Change-Id: I610210e3120c962d91ce8ff94c66161e086761ba
diff --git a/src/tbf_dl.cpp b/src/tbf_dl.cpp
index 0e6b922..c63af58 100644
--- a/src/tbf_dl.cpp
+++ b/src/tbf_dl.cpp
@@ -973,6 +973,7 @@
int gprs_rlcmac_dl_tbf::rcvd_dl_final_ack()
{
uint16_t received;
+ int rc = 0;
osmo_fsm_inst_dispatch(this->state_fsm.fi, TBF_EV_FINAL_ACK_RECVD, NULL);
@@ -986,9 +987,9 @@
/* check for LLC PDU in the LLC Queue */
if (llc_queue_size(llc_queue()) > 0)
/* we have more data so we will re-use this tbf */
- establish_dl_tbf_on_pacch();
+ rc = ms_new_dl_tbf_assigned_on_pacch(ms(), dl_tbf_as_tbf(this));
- return 0;
+ return rc;
}
int gprs_rlcmac_dl_tbf::rcvd_dl_ack(bool final_ack, unsigned first_bsn,