drop msc_compl_l3() return value
msc_compl_l3() always returns MSC_CONN_ACCEPT, because the conn FSM handles (or
should handle) all reject cases. The accept/reject return value is a legacy
from libbsc internally passing a conn over to libmsc, in osmo-nitb.
Drop enum msc_compl_l3_rc.
Change msc_compl_l3_rc() to return void.
Change all callers to always act like for acceptance, as they always did anyway.
Drop some local variables now no longer needed.
Adjust the comment to msc_compl_l3().
Drop a bunch of #if-0'd code from msc_compl_l3().
Change-Id: I759d15f4e820d5fc16397ed7210ce92308e52a09
diff --git a/src/libmsc/iucs.c b/src/libmsc/iucs.c
index 95bbbee..c3fea0d 100644
--- a/src/libmsc/iucs.c
+++ b/src/libmsc/iucs.c
@@ -142,7 +142,6 @@
int gsm0408_rcvmsg_iucs(struct gsm_network *network, struct msgb *msg,
uint16_t *lac)
{
- int rc;
struct ranap_ue_conn_ctx *ue_ctx;
struct gsm_subscriber_connection *conn;
@@ -174,7 +173,6 @@
OSMO_ASSERT(pdisc != GSM48_PDISC_RR);
msc_dtap(conn, msg);
- rc = 0;
} else {
/* allocate a new connection */
@@ -191,10 +189,10 @@
abort();
/* ownership of conn hereby goes to the MSC: */
- rc = msc_compl_l3(conn, msg, 0);
+ msc_compl_l3(conn, msg, 0);
}
- return rc;
+ return 0;
}
int iu_rab_act_cs(struct gsm_trans *trans)