tree b28f32d25b3661cd4839b06df5bd3a3896b3576d
parent bee75969cc90d3969dd23c1c79afc70755c87177
author Neels Hofmeyr <nhofmeyr@sysmocom.de> 1449439922 +0100
committer Neels Hofmeyr <nhofmeyr@sysmocom.de> 1449491835 +0100

gtphub: improve handling of restarted peer.

Handle peer restart earlier, so that all the tunnels are deleted by the restart
code path, instead of the first one being deleted due to reused TEI. That
caused confusing logging messages.

Also, when receiving Delete confirmations from the peer that didn't restart,
don't complain about unknown peer, but acknowledge and remove the half
invalidated tunnel. This means that the pending delete entry from the restart
code path is not needed / not used, so don't bother to add pending delete
entries upon peer restart.

The test test_peer_restarted_reusing_tei() hits the situation where a tunnel is
removed because of a reused TEI rather than the restart counter. Adjust the
test to expect the "out-of-band" delete request earlier on, and to still see
the half invalidated tunnel around. Enhance the test by adding the delete
response from the peer that didn't restart, and add a final tunnels_are()
verification.

Sponsored-by: On-Waves ehi