tree 077b21d3e0e2de76fbc70da89cc37bb4dad02cd7
parent d2278ec8990ecb372672bf5aed926c7bff93c474
author Neels Hofmeyr <neels@hofmeyr.de> 1519956742 +0100
committer Neels Hofmeyr <neels@hofmeyr.de> 1519957274 +0100

vlr_lu_fsm: guard against using the wrong fi

Various functions in vlr_lu_fsm.c belong to one of the four FSMs defined in
that file. After the recent error was uncovered where the lu_fsm called
lu_compl_fsm()'s termination function, I want to make sure it's correct.

Introduce distinct inline functions to dereference the respective fi->priv
pointers, each asserting that the fi indeed belongs to the proper FSM. Use
those *everywhere* to dereference fi->priv.

From this patch on, we are sure beyond doubt that we are not inadvertently
passing an fi pointer to the wrong FSM's handling functions, though we will
only catch this at runtime -- but then will immediately know the reason.

vlr_lu_fsm.c is the only file defining more than one FSM, so the other FSM
definitions are already reasonably safe.

Change-Id: I7419a780ff2d8b02efc4195bb1702818e4df181c