commit baf71a72ecbdb6b69bedced43853cf6c032ed492
author Vadim Yanitskiy <axilirator@gmail.com> Sat Jan 25 10:49:14 2020 +0700
committer Vadim Yanitskiy <axilirator@gmail.com> Sat Jan 25 10:52:26 2020 +0700
tree 43a4a32a4fbcad4f7756777bf96a56fa7bbd835a
parent ffc7f39f016091e19eedb18528228927e198a9c1

libvlr: use generic osmo_tdef API for T3250, T3260, and T3270

These timers so far were implemented as a list of unsigned integers,
which has never been initialized to any reasonable defaults. Since
they are used as state timeouts in several FSMs, we might end up
staying in some state forever.

Let's migrate to generic osmo_tdef API and use default values from
table 11.2 of 3GPP TS 24.008. This way the user can introspect and
change their values from the VTY / configuration file.

Change-Id: Ia8cf98da0aea0e626c5ff088a833d7359c43847f
Related: OS#4368

doc/manuals/vty/msc_vty_reference.xml

diff --git a/doc/manuals/vty/msc_vty_reference.xml b/doc/manuals/vty/msc_vty_reference.xml
index 36cbf77..6418425 100644
--- a/doc/manuals/vty/msc_vty_reference.xml
+++ b/doc/manuals/vty/msc_vty_reference.xml
@@ -576,10 +576,11 @@
         <param name='&lt;0-65535&gt;' doc='CI' />
       </params>
     </command>
-    <command id='show timer [(mgw|mncc|sccp|geran|utran|sgs)] [TNNNN]'>
+    <command id='show timer [(vlr|mgw|mncc|sccp|geran|utran|sgs)] [TNNNN]'>
       <params>
         <param name='show' doc='Show running system information' />
         <param name='timer' doc='Show timers' />
+        <param name='[vlr]' doc='VLR (Visitors Location Register)' />
         <param name='[mgw]' doc='MGW (Media Gateway) interface' />
         <param name='[mncc]' doc='MNCC (Mobile Network Call Control) interface' />
         <param name='[sccp]' doc='SCCP (Signalling Connection Control Part)' />
@@ -1405,10 +1406,11 @@
         <param name='&lt;0-65535&gt;' doc='CI' />
       </params>
     </command>
-    <command id='show timer [(mgw|mncc|sccp|geran|utran|sgs)] [TNNNN]'>
+    <command id='show timer [(vlr|mgw|mncc|sccp|geran|utran|sgs)] [TNNNN]'>
       <params>
         <param name='show' doc='Show running system information' />
         <param name='timer' doc='Show timers' />
+        <param name='[vlr]' doc='VLR (Visitors Location Register)' />
         <param name='[mgw]' doc='MGW (Media Gateway) interface' />
         <param name='[mncc]' doc='MNCC (Mobile Network Call Control) interface' />
         <param name='[sccp]' doc='SCCP (Signalling Connection Control Part)' />
@@ -2936,9 +2938,10 @@
         <param name='RAN_PC_OR_MSC_IPA_NAME' doc='Point code or MSC IPA name value' />
       </params>
     </command>
-    <command id='timer [(mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] [(&lt;0-2147483647&gt;|default)]'>
+    <command id='timer [(vlr|mgw|mncc|sccp|geran|utran|sgs)] [TNNNN] [(&lt;0-2147483647&gt;|default)]'>
       <params>
         <param name='timer' doc='Configure or show timers' />
+        <param name='[vlr]' doc='VLR (Visitors Location Register)' />
         <param name='[mgw]' doc='MGW (Media Gateway) interface' />
         <param name='[mncc]' doc='MNCC (Mobile Network Call Control) interface' />
         <param name='[sccp]' doc='SCCP (Signalling Connection Control Part)' />