VLR: log subscriber update
* move log helpers to generic header
* log subscriber update
It's handy for troubleshooting issues with subscriber update via GSUP
from HLR.
Change-Id: I1958aeeb3ea99831c7e2c5ee9a6b59834baf4520
diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c
index 88472e0..3045f71 100644
--- a/src/libmsc/gsm_04_08.c
+++ b/src/libmsc/gsm_04_08.c
@@ -3476,7 +3476,8 @@
/* VLR informs us that the subscriber data has somehow been modified */
static void msc_vlr_subscr_update(struct vlr_subscr *subscr)
{
- /* FIXME */
+ LOGVSUBP(LOGL_NOTICE, subscr, "VLR: update for IMSI=%s (MSISDN=%s, used=%d)\n",
+ subscr->imsi, subscr->msisdn, subscr->use_count);
}
/* VLR informs us that the subscriber has been associated with a conn */
diff --git a/src/libvlr/vlr.c b/src/libvlr/vlr.c
index 8c6911a..73c3f13 100644
--- a/src/libvlr/vlr.c
+++ b/src/libvlr/vlr.c
@@ -651,7 +651,7 @@
unsigned idx;
int rc;
- if (gsup_msg->msisdn_enc) {
+ if (gsup_msg->msisdn_enc) {//FIXME: vlr_subscr_set_msisdn()?
decode_bcd_number_safe(vsub->msisdn, sizeof(vsub->msisdn),
gsup_msg->msisdn_enc,
gsup_msg->msisdn_enc_len, 0);
diff --git a/src/libvlr/vlr_core.h b/src/libvlr/vlr_core.h
index 310cd97..bf6314d 100644
--- a/src/libvlr/vlr_core.h
+++ b/src/libvlr/vlr_core.h
@@ -4,16 +4,6 @@
struct osmo_gsup_message;
-#define LOGGSUPP(level, gsup, fmt, args...) \
- LOGP(DVLR, level, "GSUP(%s) " fmt, \
- (gsup)->imsi, \
- ## args)
-
-#define LOGVSUBP(level, vsub, fmt, args...) \
- LOGP(DVLR, level, "SUBSCR(%s) " fmt, \
- vlr_subscr_name(vsub), ## args)
-
-
const char *vlr_subscr_name(struct vlr_subscr *vsub);
int vlr_subscr_req_lu(struct vlr_subscr *vsub, bool is_ps);
int vlr_subscr_req_sai(struct vlr_subscr *vsub, const uint8_t *auts,