commit 96df07708371313348d063032ee341592c27defc
author Harald Welte <laforge@gnumonks.org> Fri Nov 25 23:57:01 2016 +0100
committer Harald Welte <laforge@gnumonks.org> Sat Nov 26 16:08:38 2016 +0000
tree 416a6cacecc6b630199310ef51b13e2a2ff143d9
parent b0993e61d002b265048c3dc734c4fa89e0b1995f

libmsc/db: avoid subscr->name without terminating NULL char

Change-Id: Ic8944ac4c5e940c9d835c52f1701461f274238db
Fixes: Coverity CID 57621

openbsc/src/libmsc/db.c

diff --git a/openbsc/src/libmsc/db.c b/openbsc/src/libmsc/db.c
index 68eba3e..5cccb32 100644
--- a/openbsc/src/libmsc/db.c
+++ b/openbsc/src/libmsc/db.c
@@ -831,8 +831,10 @@
 		subscr->tmsi = tmsi_from_string(string);
 
 	string = dbi_result_get_string(result, "name");
-	if (string)
+	if (string) {
 		strncpy(subscr->name, string, GSM_NAME_LENGTH);
+		subscr->name[sizeof(subscr->name)-1] = '\0';
+	}
 
 	string = dbi_result_get_string(result, "extension");
 	if (string)