unify allocation of gsm_subscriber_connection
The current msc_subscr_con_allocate() was in fact only used by msc_vlr_tests,
while both a_iface_bssap.c and iucs.c did their own duplicate code of
allocating the gsm_subscriber_connection struct. Unify.
Drop the old msc_subscr_con_allocate(), instead add msc_subscr_conn_alloc().
The new function also takes via_ran and lac arguments directly.
The conn allocation will soon be closely tied to the subscr_conn_fsm instance
allocation, so place the new function definition alongside the other
subscr_conn_fsm API, and match its naming ("conn").
Related: OS#3122
Change-Id: Ia57b42a149a43f9c370b1310e2e1f512183993ea
diff --git a/src/libmsc/iucs.c b/src/libmsc/iucs.c
index d6da1f7..a3092f8 100644
--- a/src/libmsc/iucs.c
+++ b/src/libmsc/iucs.c
@@ -57,17 +57,12 @@
DEBUGP(DIUCS, "Allocating IuCS subscriber conn: lac %d, conn_id %" PRIx32 "\n",
lac, ue->conn_id);
- conn = talloc_zero(network, struct gsm_subscriber_connection);
+ conn = msc_subscr_conn_alloc(network, RAN_UTRAN_IU, lac);
if (!conn)
return NULL;
- conn->network = network;
- conn->via_ran = RAN_UTRAN_IU;
conn->iu.ue_ctx = ue;
conn->iu.ue_ctx->rab_assign_addr_enc = network->iu.rab_assign_addr_enc;
- conn->lac = lac;
-
- llist_add_tail(&conn->entry, &network->subscr_conns);
return conn;
}