commit 7934e0d974b4f18c3bf415c9faddef90c3e7fccf
author Neels Hofmeyr <nhofmeyr@sysmocom.de> Mon Oct 31 18:13:47 2022 +0100
committer Neels Hofmeyr <nhofmeyr@sysmocom.de> Sat Mar 18 03:05:34 2023 +0100
tree a1d0ad12940c6c44ea131677f396437a9fcdec2f
parent cec51b340ea424e429e8a266d3a7137c0a8ad552

in ran_msg, return gsm0808_speech_codec (inter-MSC)

Get rid of enum mgcp_codecs in inter-MSC handover related code.

Change-Id: I9c649f98738a55b8637ae600d5cdf81099fd08e5

src/libmsc/msc_t.c

diff --git a/src/libmsc/msc_t.c b/src/libmsc/msc_t.c
index 787d736..7f316a7 100644
--- a/src/libmsc/msc_t.c
+++ b/src/libmsc/msc_t.c
@@ -38,6 +38,7 @@
 #include <osmocom/msc/vlr.h>
 #include <osmocom/msc/msc_i.h>
 #include <osmocom/msc/gsm_data.h>
+#include <osmocom/msc/codec_mapping.h>
 
 static struct osmo_fsm msc_t_fsm;
 
@@ -448,11 +449,20 @@
 			LOG_MSC_T(msc_t, LOGL_DEBUG, "No RTP IP:port in Handover Request Ack\n");
 		}
 		if (r->codec_present) {
-			LOG_MSC_T(msc_t, LOGL_DEBUG, "From Handover Request Ack, got %s\n",
-				  osmo_mgcpc_codec_name(r->codec));
-			rtp_stream_set_codecs_from_mgcp_codec(rtp_ran, r->codec);
-			if (rtp_cn)
-				rtp_stream_set_codecs_from_mgcp_codec(rtp_cn, r->codec);
+			const struct codec_mapping *m = codec_mapping_by_gsm0808_speech_codec_type(r->codec.type);
+			/* TODO: use codec_mapping_by_gsm0808_speech_codec() to also match on codec.cfg */
+			if (!m) {
+				LOG_MSC_T(msc_t, LOGL_ERROR, "Cannot resolve codec in Handover Request Ack: %s / %s\n",
+					  gsm0808_speech_codec_type_name(r->codec.type),
+					  m ? sdp_audio_codec_to_str(&m->sdp) : "(unknown)");
+			} else {
+				LOG_MSC_T(msc_t, LOGL_DEBUG, "From Handover Request Ack, got codec %s / %s\n",
+					  gsm0808_speech_codec_type_name(r->codec.type),
+					  sdp_audio_codec_to_str(&m->sdp));
+				rtp_stream_set_one_codec(rtp_ran, &m->sdp);
+				if (rtp_cn)
+					rtp_stream_set_one_codec(rtp_cn, &m->sdp);
+			}
 		} else {
 			LOG_MSC_T(msc_t, LOGL_DEBUG, "No codec in Handover Request Ack\n");
 		}