MNCC: Add input validation
There appears to have been no input validation whatsoever on MNCC
messages. Hence it was very easy for an external MNCC handler to
crash OsmoMSC, such as in OS#2853
Change-Id: Idaf3b8e409c84564b1eb26d01a19c605f89b14f4
Closes: OS#2853
diff --git a/src/libmsc/mncc_sock.c b/src/libmsc/mncc_sock.c
index b6b1bc9..14613ca 100644
--- a/src/libmsc/mncc_sock.c
+++ b/src/libmsc/mncc_sock.c
@@ -123,8 +123,11 @@
return 0;
goto close;
}
+ msgb_put(msg, rc);
- rc = mncc_tx_to_cc(state->net, mncc_prim->msg_type, mncc_prim);
+ rc = mncc_prim_check(mncc_prim, rc);
+ if (rc == 0)
+ rc = mncc_tx_to_cc(state->net, mncc_prim->msg_type, mncc_prim);
/* as we always synchronously process the message in mncc_send() and
* its callbacks, we can free the message here. */