commit 4ad593c8f636ba566f914c086287c43bb75ed7f8
author Alexander Chemeris <alexander.chemeris@gmail.com> Fri Oct 04 02:42:27 2013 +0200
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> Fri Oct 04 08:18:32 2013 +0200
tree 36ab12516468b834fd596400c307a9551cdd7e18
parent a3d41c91242fe253215afb66e87d3a905ac02dfe

sms: Possiqble meamleak fix gsm340_rx_tpdu()

Slight clean up of the code in gsm340_rx_tpdu() and a fix for
an unlikely, but possible memory leak there.

openbsc/src/libmsc/gsm_04_11.c

diff --git a/openbsc/src/libmsc/gsm_04_11.c b/openbsc/src/libmsc/gsm_04_11.c
index 2fc250b..e554b74 100644
--- a/openbsc/src/libmsc/gsm_04_11.c
+++ b/openbsc/src/libmsc/gsm_04_11.c
@@ -337,8 +337,8 @@
 
 	sms_alphabet = gsm338_get_sms_alphabet(gsms->data_coding_scheme);
 	if (sms_alphabet == 0xffffffff) {
-		sms_free(gsms);
-		return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
+		rc = GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
+		goto out;
 	}
 
 	switch (sms_vpf) {
@@ -359,7 +359,8 @@
 	default:
 		LOGP(DLSMS, LOGL_NOTICE,
 		     "SMS Validity period not implemented: 0x%02x\n", sms_vpf);
-		return GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
+		rc = GSM411_RP_CAUSE_MO_NET_OUT_OF_ORDER;
+		goto out;
 	}
 	gsms->user_data_len = *smsp++;
 	if (gsms->user_data_len) {