commit 477cbc6d93bdaf90a7dc0df7f297c31a20f9c4d8
author Vadim Yanitskiy <axilirator@gmail.com> Sat Feb 23 16:59:16 2019 +0700
committer Vadim Yanitskiy <axilirator@gmail.com> Thu Feb 28 00:14:21 2019 +0700
tree 726d1c7a1da3abf6192c250404a6a83ff16bdc7d
parent 4d75877e61f13e80701b8436a5d71aa868f0d295

libmsc/msc_vty.c: drop dead comparison against null

Since vsub->sgs.mme_name is allocated statically, comparing it
to null doesn't make sense - it's always != NULL.

Change-Id: Ib2933a20471ebff9dfe1d9fdddf39d177504c951
Fixes: CID#178166 Array compared against 0 (NO_EFFECT)

src/libmsc/msc_vty.c

diff --git a/src/libmsc/msc_vty.c b/src/libmsc/msc_vty.c
index 5aa533b..2adb2a4 100644
--- a/src/libmsc/msc_vty.c
+++ b/src/libmsc/msc_vty.c
@@ -749,7 +749,7 @@
 	/* SGs related */
 	vty_out(vty, "    SGs-state: %s%s",
 		osmo_fsm_inst_state_name(vsub->sgs_fsm), VTY_NEWLINE);
-	if (vsub->sgs.mme_name && strlen(vsub->sgs.mme_name))
+	if (strlen(vsub->sgs.mme_name))
 		vty_out(vty, "    SGs-MME: %s%s", vsub->sgs.mme_name, VTY_NEWLINE);
 	else
 		vty_out(vty, "    SGs-MME: (none)%s", VTY_NEWLINE);