commit bbb17f014825ce6cefb4756bfc2c156f7ceb2ec2
author Harald Welte <laforge@gnumonks.org> Mon Jul 17 23:59:39 2017 +0200
committer Neels Hofmeyr <neels@hofmeyr.de> Sun Aug 27 17:44:57 2017 +0200
tree 725e7bca72b46634716ae341b9cc6148cc0b3504
parent ca52991d6ece89e37ba43d64cb215f49e8911c4e

gtphob: check for missing result of rate_ctr_group_alloc()

In case the counter group allocation fails, we must handle this
gracefully and fail the allocation of the parent object, too.

The recent change (Id I7dad4a4d52fe05f6b990359841b4408df5990e21) seems
to have missed one instance, so let's follow-up.

Change-Id: I1ee9e3d26dcc18e7f979fd9a786162cbcc50942c
Related: OS#2361

src/gprs/gtphub.c

diff --git a/src/gprs/gtphub.c b/src/gprs/gtphub.c
index 211018b..5e7520e 100644
--- a/src/gprs/gtphub.c
+++ b/src/gprs/gtphub.c
@@ -2708,6 +2708,10 @@
 
 	pp->counters_io = rate_ctr_group_alloc(osmo_gtphub_ctx,
 					       &gtphub_ctrg_io_desc, 0);
+	if (!pp->counters_io) {
+		talloc_free(pp);
+		return NULL;
+	}
 
 	llist_add(&pp->entry, &a->ports);