mgcp_send_dummy: Check RTP destination is available before attempt tx
Several log messages showing "Failed to send dummy RTP packet." were
seen in a osmo-mgw on the field. Let's re-use the function to check and
provide more information on what's wrong to ease debugging.
Related: SYS#5498
Change-Id: Iee6ac1f4d24c131e3bf40c37e6fdc252e5208ec8
diff --git a/src/libosmo-mgcp/mgcp_network.c b/src/libosmo-mgcp/mgcp_network.c
index dfa952b..5b3ea51 100644
--- a/src/libosmo-mgcp/mgcp_network.c
+++ b/src/libosmo-mgcp/mgcp_network.c
@@ -1037,6 +1037,12 @@
LOGPCONN(conn->conn, DRTP, LOGL_DEBUG, "sending dummy packet... %s\n",
mgcp_conn_dump(conn->conn));
+ /* Before we try to deliver the packet, we check if the destination
+ * port and IP-Address make sense at all. If not, we will be unable
+ * to deliver the packet. */
+ if (check_rtp_destin(conn) != 0)
+ goto failed;
+
rc = mgcp_udp_send(conn->end.rtp.fd, &conn->end.addr,
conn->end.rtp_port, rtp_dummy_payload, sizeof(rtp_dummy_payload));
diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index e6862e5..5bb7b27 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -634,6 +634,10 @@
dummy_packets += 1;
}
+ /* Make sure address+port are valid */
+ OSMO_ASSERT(dest_host);
+ OSMO_ASSERT(dest_port);
+
return len;
}
diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok
index 9c48147..d3f8a26 100644
--- a/tests/mgcp/mgcp_test.ok
+++ b/tests/mgcp/mgcp_test.ok
Binary files differ