mgcp_client: Deprecate unused IPv4-only API
The API and related implementation fields are not used internally nor
externally, and only support IPv4. Let's simply deprecate the API and
drop all the uneeded implementation.
Change-Id: I905d4c4efabb6b4a4bc5c02e956808777243cadc
diff --git a/src/libosmo-mgcp-client/mgcp_client.c b/src/libosmo-mgcp-client/mgcp_client.c
index 72068b4..5972803 100644
--- a/src/libosmo-mgcp-client/mgcp_client.c
+++ b/src/libosmo-mgcp-client/mgcp_client.c
@@ -823,7 +823,6 @@
* \returns 0 on success, -EINVAL on error. */
int mgcp_client_connect(struct mgcp_client *mgcp)
{
- struct sockaddr_in addr;
struct osmo_wqueue *wq;
int rc;
@@ -843,9 +842,6 @@
goto error_close_fd;
}
- inet_aton(mgcp->actual.remote_addr, &addr.sin_addr);
- mgcp->remote_addr = htonl(addr.sin_addr.s_addr);
-
osmo_wqueue_init(wq, 1024);
wq->bfd.when = OSMO_FD_READ;
wq->bfd.data = mgcp;
@@ -877,12 +873,13 @@
return mgcp->actual.remote_port;
}
-/*! Get the IP-Aaddress of the associated MGW as its numeric representation.
+/*! Get the IP-Address of the associated MGW as its numeric representation.
+ * DEPRECATED, DON'T USE.
* \param[in] mgcp MGCP client descriptor.
* \returns IP-Address as 32 bit integer (network byte order) */
uint32_t mgcp_client_remote_addr_n(struct mgcp_client *mgcp)
{
- return mgcp->remote_addr;
+ return 0;
}
/* To compose endpoint names, usually for CRCX, use this as domain name.