tree b7eaefc9675bb31cb3b4bb01101bdb7a77c2d09b
parent 0572ee045d1b7c29a0c34b27867b3f8669eb5038
author Jacob Erlbeck <jerlbeck@sysmocom.de> 1421065385 +0100
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> 1421583429 +0100

gprs: Handle empty GSUP messages correctly

Currently, the gprs_gsup_decode function doesn't check the return
value of gprs_shift_v_fixed before using the value pointer. The
function fails, if the GSUP message length (not including IPA
headers) is 0. In this case, a segfault can happen, depending on the
value of the uninitialized 'value' pointer. The test case doesn't
trigger a segfault, but valgrind complains about reading
uninitialized data.

This patch adds a check for the return value that would return with
an error code if the shift function failed.

Sponsored-by: On-Waves ehf