tree be8bd36badf9e0ec630efda748ce83e002220059
parent 9d1a17e15f6902bc9591680da3375b2d14db16ab
author Jacob Erlbeck <jerlbeck@sysmocom.de> 1421661375 +0100
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> 1422258112 +0100

gprs: Return 0 from gsup_client_connect if ok or retry timer enabled

Currently the gsup_client_connect return 0 if the call to
ipa_client_conn_open was successful and -errno otherwise. This makes
it difficult for the caller to determine, whether the the whole
operation has been cancelled (currently on EBADF, ENOTSOCK,
EAFNOSUPPORT, EINVAL) or whether the GSUP client will retry to
connect after a timeout. This will cause gprs_gsup_client_create to
destroy the GSUP client object, even if the error might be temporary.

This patch changes the function to return 0 if (and only if)
ipa_client_conn_open was successful or the retry timer has been
started. Since the return value 0 doesn't guarantee, that a
subsequent call to gprs_gsup_client_send will succeed, this shouldn't
break anything.

Sponsored-by: On-Waves ehf