commit 1c3287f1dbdad125ffcf1b8380e62c87c1109529
author Philipp Maier <pmaier@sysmocom.de> Thu Nov 30 09:15:12 2017 +0100
committer Philipp Maier <pmaier@sysmocom.de> Mon Dec 04 16:04:10 2017 +0100
tree 94e53ea69117c654639b91d8b39581af10f6e0a9
parent 922ae9a5bf6fc0df113c8b83ed9b70a90b769e4a

conn: remove assertions

the assertions in the code that handles the connection
lists introduce a lot of unnecessary bloat.

Change-Id: I7badc729e97b76701abbce6a73a1ad1e46d3fee0

src/libosmo-mgcp/mgcp_conn.c

diff --git a/src/libosmo-mgcp/mgcp_conn.c b/src/libosmo-mgcp/mgcp_conn.c
index ae3f026..4090a9f 100644
--- a/src/libosmo-mgcp/mgcp_conn.c
+++ b/src/libosmo-mgcp/mgcp_conn.c
@@ -124,10 +124,6 @@
 	struct mgcp_conn *conn;
 	int rc;
 
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-	OSMO_ASSERT(strlen(name) < sizeof(conn->name));
-
 	/* Do not allow more then two connections */
 	if (llist_count(&endp->conns) >= endp->type->max_conns)
 		return NULL;
@@ -170,11 +166,6 @@
  *  \returns pointer to allocated connection, NULL if not found */
 struct mgcp_conn *mgcp_conn_get(struct mgcp_endpoint *endp, const char *id)
 {
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(id);
-	OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-
 	struct mgcp_conn *conn;
 
 	llist_for_each_entry(conn, &endp->conns, entry) {
@@ -192,11 +183,6 @@
 struct mgcp_conn_rtp *mgcp_conn_get_rtp(struct mgcp_endpoint *endp,
 					const char *id)
 {
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(id);
-	OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-
 	struct mgcp_conn *conn;
 
 	conn = mgcp_conn_get(endp, id);
@@ -214,11 +200,6 @@
  *  \param[in] id identification number of the connection */
 void mgcp_conn_free(struct mgcp_endpoint *endp, const char *id)
 {
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(id);
-	OSMO_ASSERT(strlen(id) < MGCP_CONN_ID_LENGTH);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-
 	struct mgcp_conn *conn;
 
 	conn = mgcp_conn_get(endp, id);
@@ -246,9 +227,6 @@
  *  \param[in] endp associated endpoint */
 void mgcp_conn_free_oldest(struct mgcp_endpoint *endp)
 {
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-
 	struct mgcp_conn *conn;
 
 	if (llist_empty(&endp->conns))
@@ -265,9 +243,6 @@
  *  \param[in] endp associated endpoint */
 void mgcp_conn_free_all(struct mgcp_endpoint *endp)
 {
-	OSMO_ASSERT(endp);
-	OSMO_ASSERT(endp->conns.next != NULL && endp->conns.prev != NULL);
-
 	struct mgcp_conn *conn;
 	struct mgcp_conn *conn_tmp;