commit 1a099fd34c02b10a466e4afcb51b91c330bd50ae
author Vadim Yanitskiy <vyanitskiy@sysmocom.de> Mon Apr 18 02:29:37 2022 +0300
committer Harald Welte <laforge@osmocom.org> Mon Apr 18 10:57:08 2022 +0200
tree 2509c2078a7b5b48f0f9ce35ca54df5bb0926a9a
parent 58dc88bc310e6a2f0c3d750aa764c1a91549018b

libosmo-mgcp: e1: fix memleaks in e1_recv_cb()

Change-Id: I4be9e6d09b34e792f24c9f09d19dce15b9dfbe3f
Fixes: OS#5533

src/libosmo-mgcp/mgcp_e1.c

diff --git a/src/libosmo-mgcp/mgcp_e1.c b/src/libosmo-mgcp/mgcp_e1.c
index e88b8c5..9a6efe2 100644
--- a/src/libosmo-mgcp/mgcp_e1.c
+++ b/src/libosmo-mgcp/mgcp_e1.c
@@ -338,6 +338,7 @@
 	trunk = mgcp_trunk_by_line_num(cfg, ts->line->num);
 	if (!trunk) {
 		LOGP(DE1, LOGL_ERROR, "E1-RX: unable to find a trunk for E1-line %u!\n", ts->line->num);
+		msgb_free(msg);
 		return;
 	}
 
@@ -359,6 +360,9 @@
 
 	/* Trigger sending of pending E1 traffic */
 	e1_send(ts, trunk);
+
+	/* e1inp_rx_ts() does not free() msgb */
+	msgb_free(msg);
 }
 
 static int e1_init(struct mgcp_trunk *trunk, uint8_t ts_nr)