mgw: Support lowercase header parameters
MGCP RFC3435 (https://tools.ietf.org/html/rfc3435) states almost all
text has to be handled in a case-insensitive way, except SDP parts.
Related: OS#4001
Change-Id: I48252415f9d0cd985ad097f334aa4c1665f52511
diff --git a/src/libosmo-mgcp/mgcp_protocol.c b/src/libosmo-mgcp/mgcp_protocol.c
index 9baf50d..3a4591f 100644
--- a/src/libosmo-mgcp/mgcp_protocol.c
+++ b/src/libosmo-mgcp/mgcp_protocol.c
@@ -813,7 +813,7 @@
if (!mgcp_check_param(endp, line))
continue;
- switch (line[0]) {
+ switch (toupper(line[0])) {
case 'L':
local_options = (const char *)line + 3;
break;
@@ -831,7 +831,6 @@
mode = (const char *)line + 3;
break;
case 'X':
- case 'x':
if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) {
/* If osmux is disabled, just skip setting it up */
if (!p->endp->cfg->osmux)
@@ -1090,7 +1089,7 @@
if (!mgcp_check_param(endp, line))
continue;
- switch (line[0]) {
+ switch (toupper(line[0])) {
case 'C':
if (mgcp_verify_call_id(endp, line + 3) != 0) {
rate_ctr_inc(&rate_ctrs->ctr[MGCP_MDCX_FAIL_INVALID_CALLID]);
@@ -1115,7 +1114,6 @@
silent = strcmp("noanswer", line + 3) == 0;
break;
case 'X':
- case 'x':
if (strncasecmp("Osmux: ", line + 2, strlen("Osmux: ")) == 0) {
/* If osmux is disabled, just skip setting it up */
if (!p->endp->cfg->osmux)
@@ -1314,7 +1312,7 @@
if (!mgcp_check_param(endp, line))
continue;
- switch (line[0]) {
+ switch (toupper(line[0])) {
case 'C':
if (mgcp_verify_call_id(endp, line + 3) != 0) {
error_code = 516;
@@ -1465,7 +1463,7 @@
LOGP(DLMGCP, LOGL_NOTICE, "RQNT: processing request for notification ...\n");
for_each_line(line, p->save) {
- switch (line[0]) {
+ switch (toupper(line[0])) {
case 'S':
tone = extract_tone(line);
break;
diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c
index ab6d0ce..c67b9d5 100644
--- a/tests/mgcp/mgcp_test.c
+++ b/tests/mgcp/mgcp_test.c
@@ -211,10 +211,10 @@
/* Test different upper/lower case in options */
#define MDCX4_PT4 \
"MDCX 18983220 1@mgw MGCP 1.0\r\n" \
- "M: sendrecv\r" \
- "C: 2\r\n" \
- "I: %s\r\n" \
- "L: A:AMR, NT:IN\r\n" \
+ "m: sendrecv\r" \
+ "c: 2\r\n" \
+ "i: %s\r\n" \
+ "l: A:AMR, NT:IN\r\n" \
"\n" \
"v=0\r\n" \
"o=- %s 23 IN IP4 0.0.0.0\r\n" \
@@ -260,7 +260,7 @@
#define CRCX \
"CRCX 2 1@mgw MGCP 1.0\r\n" \
- "M: recvonly\r\n" \
+ "m: recvonly\r\n" \
"C: 2\r\n" \
"L: p:20\r\n" \
"\r\n" \
diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok
index 3929d79..08ea438 100644
--- a/tests/mgcp/mgcp_test.ok
+++ b/tests/mgcp/mgcp_test.ok
Binary files differ