ranap_parse_lai(): Fix wrong BCD decoding for MNC. Add test.
Fix the ranap_parse_lai() part that decodes the MNC: place the *10 at the
proper MNC digit.
Add a comprehensive test for ranap_parse_lai() in test-helpers.c. Because
ranap_parse_lai() logs things, add test_common.c to test-helpers compilation
and an expected stderr output to test-helpers' testsuite.at def.
diff --git a/src/ranap_common.c b/src/ranap_common.c
index 57f2e83..dc46459 100644
--- a/src/ranap_common.c
+++ b/src/ranap_common.c
@@ -508,8 +508,8 @@
ra_id->mcc = (ptr[0] & 0xF) * 100 +
(ptr[0] >> 4) * 10 +
(ptr[1] & 0xF);
- ra_id->mnc = (ptr[2] & 0xF) +
- (ptr[2] >> 4) * 10;
+ ra_id->mnc = (ptr[2] & 0xF) * 10 +
+ (ptr[2] >> 4);
if ((ptr[1] >> 4) != 0xF)
ra_id->mnc += (ptr[1] >> 4) * 100;