cosmetic: comments, log typo, explicit pointer
Fix log typo 'REGSITER' and add some comments on UE Register with TMSI.
The container_pair struct starts with 'list', so passing the container_pair
pointer is equivalent to passing the list; but instead, explicitly mention the
list member to avoid confusion.
diff --git a/src/hnbgw.h b/src/hnbgw.h
index d2d4b09..a7a6f9a 100644
--- a/src/hnbgw.h
+++ b/src/hnbgw.h
@@ -101,6 +101,8 @@
/*! Unique Context ID for this UE */
uint32_t context_id;
char imsi[16+1];
+ /* TODO: track TMSI, for HNBAP UE Register Request with TMSI,
+ * seen with ip.access nano3G femto cell */
/*! UE is serviced via this HNB */
struct hnb_context *hnb;
};
diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 971e97e..246c983 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -123,7 +123,7 @@
if (rc < 0)
return rc;
- DEBUGP(DHNBAP, "HNB-DE-REGSITER cause=%ld\n",
+ DEBUGP(DHNBAP, "HNB-DE-REGISTER cause=%ld\n",
ies.cause);
hnbap_free_hnbde_registeries(&ies);
@@ -184,7 +184,9 @@
ies.uE_Identity.choice.iMSIESN.iMSIDS41.size);
break;
default:
- LOGP(DHNBAP, LOGL_NOTICE, "UE-REGISTER-REQ without IMSI?!?\n");
+ LOGP(DHNBAP, LOGL_NOTICE, "UE-REGISTER-REQ without IMSI\n");
+ /* TODO: this is probably a TMSI registration. Store TMSIs
+ * and look them up to accept UE Registration. */
return -1;
}
diff --git a/src/ranap_msg_factory.c b/src/ranap_msg_factory.c
index 6cf997d..7e03b13 100644
--- a/src/ranap_msg_factory.c
+++ b/src/ranap_msg_factory.c
@@ -814,7 +814,7 @@
RANAP_ProtocolIE_ContainerPair_t *container_pair = CALLOC(1, sizeof(*container_pair));
/* Add the pair to the list of IEs of the RAB ass.req */
- ASN_SEQUENCE_ADD(container_pair, pair);
+ ASN_SEQUENCE_ADD(&container_pair->list, pair);
/* Add the pair to the list of IEs of the RAB ass.req */
ASN_SEQUENCE_ADD(&ies.raB_SetupOrModifyList.list, container_pair);