commit 1d2c39d83bcbcf2c424e29edd7d804b87a726885
author Harald Welte <laforge@gnumonks.org> Fri Sep 11 17:49:37 2015 +0200
committer Harald Welte <laforge@gnumonks.org> Fri Sep 11 17:49:37 2015 +0200
tree 38dfeb7b45bfb3af65d4f610213db1e0afc909ea
parent 35cbc11757cb6f8360e7d22d55e07c2d864a2979

various cleanups (compiler warnings, coding style)

src/hnbgw.c

diff --git a/src/hnbgw.c b/src/hnbgw.c
index b50cd9d..d26f166 100644
--- a/src/hnbgw.c
+++ b/src/hnbgw.c
@@ -8,8 +8,9 @@
 
 #include <sys/types.h>
 #include <sys/socket.h>
+#include <netinet/in.h>
 #include <netinet/sctp.h>
-//#include <arpa/inet.h>
+#include <arpa/inet.h>
 
 #include <osmocom/core/application.h>
 #include <osmocom/core/talloc.h>

src/hnbgw_hnbap.c

diff --git a/src/hnbgw_hnbap.c b/src/hnbgw_hnbap.c
index 1915ad6..25bc272 100644
--- a/src/hnbgw_hnbap.c
+++ b/src/hnbgw_hnbap.c
@@ -7,6 +7,7 @@
 #include <string.h>
 
 #include "asn1helpers.h"
+#include "iu_helpers.h"
 
 #include "hnbgw.h"
 #include "hnbap_common.h"
@@ -61,11 +62,13 @@
 	size_t encoded_imsi_len;
 	int rc;
 
-	encoded_imsi_len = encode_iu_imsi(encoded_imsi, sizeof(encoded_imsi), ue->imsi);
+	encoded_imsi_len = encode_iu_imsi(encoded_imsi,
+					  sizeof(encoded_imsi), ue->imsi);
 
 	memset(&accept, 0, sizeof(accept));
 	accept.uE_Identity.present = UE_Identity_PR_iMSI;
-	OCTET_STRING_fromBuf(&accept.uE_Identity.choice.iMSI, (const char *)encoded_imsi, encoded_imsi_len);
+	OCTET_STRING_fromBuf(&accept.uE_Identity.choice.iMSI,
+			     (const char *)encoded_imsi, encoded_imsi_len);
 	asn1_u32_to_bitstring(&accept.context_ID, &ue->context_id);
 
 	memset(&accept_out, 0, sizeof(accept_out));
@@ -131,7 +134,7 @@
 			      ies.uE_Identity.choice.iMSIESN.iMSIDS41.size);
 		break;
 	default:
-		DEBUGP(DMAIN, "UE-REGISTER-REQ without IMSI?!?\n");
+		LOGP(DMAIN, LOGL_NOTICE, "UE-REGISTER-REQ without IMSI?!?\n");
 		return -1;
 	}
 
@@ -151,7 +154,7 @@
 	ErrorIndicationIEs_t ies;
 	int rc;
 
-	rc = hnbap_decode_hnbregisterrequesties(&ies, in);
+	rc = hnbap_decode_errorindicationies(&ies, in);
 	if (rc < 0)
 		return rc;
 
@@ -184,11 +187,11 @@
 	case ProcedureCode_id_RelocationComplete:	/* 8.11 */
 	case ProcedureCode_id_U_RNTIQuery:	/* 8.12 */
 	case ProcedureCode_id_privateMessage:
-		LOGP(DMAIN, LOGL_NOTICE, "Unimplemented HNBAP Procedure %u\n",
+		LOGP(DMAIN, LOGL_NOTICE, "Unimplemented HNBAP Procedure %ld\n",
 			imsg->procedureCode);
 		break;
 	default:
-		LOGP(DMAIN, LOGL_NOTICE, "Unknown HNBAP Procedure %u\n",
+		LOGP(DMAIN, LOGL_NOTICE, "Unknown HNBAP Procedure %ld\n",
 			imsg->procedureCode);
 		break;
 	}

src/iu_helpers.c

diff --git a/src/iu_helpers.c b/src/iu_helpers.c
index fee51bc..bc87905 100644
--- a/src/iu_helpers.c
+++ b/src/iu_helpers.c
@@ -1,4 +1,5 @@
 #include <stdint.h>
+#include <string.h>
 
 #include <osmocom/core/utils.h>