commit fdc3c1549e03e446e777e588eda313db9ecc5a9a
author Daniel Willmann <daniel@totalueberwachung.de> Sat Jul 16 21:50:13 2011 +0200
committer Holger Hans Peter Freyther <zecke@selfish.org> Tue Jul 19 20:07:20 2011 +0200
tree 2010348ed446eef660ac84230bf39733158227b7
parent 72d807c9ea2321820390a1ecad8897598c0c9f93

osmo-bsc: Improve return handling in verify_net_loc

openbsc/src/osmo-bsc/osmo_bsc_main.c

diff --git a/openbsc/src/osmo-bsc/osmo_bsc_main.c b/openbsc/src/osmo-bsc/osmo_bsc_main.c
index 3a2306c..1b91468 100644
--- a/openbsc/src/osmo-bsc/osmo_bsc_main.c
+++ b/openbsc/src/osmo-bsc/osmo_bsc_main.c
@@ -220,7 +220,6 @@
 int verify_net_loc(struct ctrl_cmd *cmd, const char *value, void *data)
 {
 	char *saveptr, *latstr, *lonstr, *heightstr, *agestr, *tmp;
-	int  ret = 0;
 	unsigned long age;
 	double lat, lon, height;
 
@@ -235,7 +234,7 @@
 
 	if ((agestr == NULL) || (latstr == NULL) ||
 			(lonstr == NULL) || (heightstr == NULL))
-		ret = 1;
+		return 1;
 
 	age = atol(agestr);
 	lat = atof(latstr);
@@ -246,7 +245,7 @@
 	if ((age == 0) || (lat < -90) || (lat > 90) || (lon < -180) || (lon > 180))
 		return 1;
 
-	return ret;
+	return 0;
 }
 
 CTRL_CMD_DEFINE(trx_rf_lock, "rf_locked");