Gitiles
Code Review Sign In
gerrit.osmocom.org / osmo-gbproxy / e705b3fb3f6fdf71c50e2a52f7d2ab7e64b7ca45
commite705b3fb3f6fdf71c50e2a52f7d2ab7e64b7ca45[log] [tgz]
authorDaniel Willmann <dwillmann@sysmocom.de>Thu Nov 25 22:04:56 2021 +0100
committerDaniel Willmann <dwillmann@sysmocom.de>Thu Nov 25 22:04:56 2021 +0100
tree5a9dd0d210b35577414f5d9dfc40ce0a9f1ae566
parentaf2e9b349cfe1ccf4a19b7bf21c70ffc9d9191ed [diff]
gbproxy: Fix crash when FLUSH_LL_ACK does not contain a BVCI IE

The BVCI IE is listed as conditional and is only included if the flush
action indicates that LLC-PDUs are transferred. (3GPP TS 48.018 Ch.
10.4.2).

The code in gbprox_rx_sig_from_bss unconditionally tries to get a BVCI
from a FLUSH_LL message which could result in a segfault if no such IE
is included. Routing towards the SGSN can happen simply based on TLLI (for pooling)
since there is only one signalling BVC towards the SGSN.

Related: OS#5332
Change-Id: I659f9c925bb38b8cf2348b84b976142d8d4693f7
1 file changed
tree: 5a9dd0d210b35577414f5d9dfc40ce0a9f1ae566
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tests/
  8. .gitignore
  9. .gitreview
  10. .mailmap
  11. AUTHORS
  12. configure.ac
  13. COPYING
  14. git-version-gen
  15. Makefile.am
  16. osmoappdesc.py
  17. README.md
  18. README.vty-tests
  19. TODO-RELEASE
README.md

About osmo-gbproxy

osmo-gbproxy is a proxy for the Gb interface within the 3GPP GERAN (GPRS/EDGE RAN) architecture. It is part of the Osmocom Open Source Mobile Communications projects.

It allows you to aggregate many Gb links/connections into one. It also has the ability to convert between different Gb interface protocol stacking, such as from Gb-over-FrameRelay to Gb-over-IP.

Until 2021 it used to be part of the osmo-sgsn git repository, and before that (until 2017) part of openbsc.git

Homepage and Issue Tracker

Find the issue tracker and wiki online at https://osmocom.org/projects/osmo-gbproxy and https://osmocom.org/projects/osmo-gbproxy/wiki, respectively.

Documentation

You can find the user manual at https://ftp.osmocom.org/docs/latest/osmogbproxy-usermanual.pdf and the VTY reference manual at https://ftp.osmocom.org/docs/latest/osmogbproxy-vty-reference.pdf.