tree 377e1255069dcf51c96e81bf282a303eb7ab73f1
parent 508c3108e840a2f7b0b26cd5c7b16559d0b6182f
author Jacob Erlbeck <jerlbeck@sysmocom.de> 1428583638 +0200
committer Holger Hans Peter Freyther <holger@moiji-mobile.com> 1428648420 +0200

nitb: Fix IMSI/IMEI buffer handling (Coverity)

Currently the handling of the buffers is not done consistently. Some
code assumes that the whole buffer may be used to store the string
while at other places, the last buffer byte is left untouched in the
assumption that it contains a terminating NUL-character. The latter
is the correct behaviour.

This commit changes to code to not touch the last byte in the buffers
and to rely on the last byte being NUL. So the maximum IMSI/IMEI
length is GSM_IMSI_LENGTH-1/GSM_IMEI_LENGTH-1.

For information: We assume that we allocate the structure with
talloc_zero. This means we have NULed the entire imsi array and then
only write sizeof - 1 characters to it. So the last byte remains NUL.

Fixes: Coverity CID 1206568, 1206567
Sponsored-by: On-Waves ehf