tree 615e2ff4e5cfb4093772f86e24ab893923e4a4d0
parent 42d284f068a8739f51f9fddf30c7e499345a59d3
author Jacob Erlbeck <jerlbeck@sysmocom.de> 1414504673 +0100
committer Jacob Erlbeck <jerlbeck@sysmocom.de> 1414505822 +0100

nitb/ctrl: Fix access to freed memory in verify_subscriber_modify

Currently the temporary string 'tmp' is freed before parts of it are
referenced. This lets address sanitizer complain when evaluating
strlen(imsi), where imsi points into the 'tmp' data block.

This patch moves the talloc_free to the end of the function and uses
a rc variable instead of using early returns.

Addresses:
testSubscriberAddRemove (__main__.TestCtrlNITB) ... Launch:
./src/osmo-nitb/osmo-nitb -c
  ./doc/examples/osmo-nitb/nanobts/openbsc.cfg -l test_hlr.sqlite3
Connecting to host 127.0.0.1:4249
Sending "SET 1000 subscriber-modify-v1 2620345,445566"
Decoded replies:  {}
ERROR

Sponsored-by: On-Waves ehf