tree 4da5fa1fbab15f8dfd81522e24aefa758e5d325e
parent fb7f9136db836274e887d4eaf0a526d55e5cb09f
author Pau Espin Pedrol <pespin@sysmocom.de> 1503051983 +0200
committer Neels Hofmeyr <neels@hofmeyr.de> 1503848456 +0200

libmsc: Fix wrong handling of user_message_reference parameter

libsmpp34 already converts received TLV integer values to native
endianess in libsmpp34_(un)pack.

Converting them again at receive time swaps the 2 bytes of
user_message_reference, then using a wrong value. As GSM03.40 spec
uses only 1 byte for the id, then only the high byte of the initial
value is used and eventually sent back to the ESME. Again, at that time,
htons() is not needed because libsmpp34 already handles that part.

See OS-#2429 for more details.

Change-Id: If748548a4a223e529a1110c89e483b599b406e8b