tree 2f5f801a6bd5af1de135e099fb287157b6848b85
parent 9afe43502d7f70a1cf17e8a3870afab18b5f1f76
author Pau Espin Pedrol <pespin@sysmocom.de> 1560445405 +0200
committer Pau Espin Pedrol <pespin@sysmocom.de> 1560446616 +0200

sgsn: Have authentication required on by default

Previous commit introduced command "authentication (optional|required)",
which is only meaningful if auth-policy is remote. Upon adding the cmd,
it changed the default logic for remote policy to not require
authentication, which broke TTCN3 tests because sgsn no longer tries to
authenticate the users.

Since it's actually good to enable authentication by default where
possible, let's enable it by default when on auth-policy remote.

In order to do so, let's simply not care about the value of variable
require_authentication if auth_policy is not REMOTE. As a result, we
drop parts of the previous patch and remove unneeded checks (which are
only partially useful based on order of commands during VTY read).

Fixes: 794f446a284ed1ac6d31eb79a8f4c874d66fc34e
Change-Id: Ic707a95af178b44f08809df3d3bc8354bf34273c