We're using NECI=0, but the channel reauest reasons we're seeing from MS's are wrong
So we don't know what's the problem. Using the NECI=1 tables makes us allocate SDCCH
for MO SMS, which is good.
diff --git a/openbsc/src/gsm_04_08.c b/openbsc/src/gsm_04_08.c
index 967e4ce..64405ec 100644
--- a/openbsc/src/gsm_04_08.c
+++ b/openbsc/src/gsm_04_08.c
@@ -3755,10 +3755,10 @@
enum gsm_chan_t get_ctype_by_chreq(struct gsm_bts *bts, u_int8_t ra)
{
int i;
- /* FIXME: determine if we set NECI = 0 in the BTS SI4 */
+ /* FIXME: determine if we set NECI = 1 in the BTS SI4 */
- for (i = 0; i < ARRAY_SIZE(chreq_type_neci0); i++) {
- const struct chreq *chr = &chreq_type_neci0[i];
+ for (i = 0; i < ARRAY_SIZE(chreq_type_neci1); i++) {
+ const struct chreq *chr = &chreq_type_neci1[i];
if ((ra & chr->mask) == chr->val)
return ctype_by_chreq[chr->type];
}
@@ -3769,10 +3769,10 @@
enum gsm_chreq_reason_t get_reason_by_chreq(struct gsm_bts *bts, u_int8_t ra)
{
int i;
- /* FIXME: determine if we set NECI = 0 in the BTS SI4 */
+ /* FIXME: determine if we set NECI = 1 in the BTS SI4 */
- for (i = 0; i < ARRAY_SIZE(chreq_type_neci0); i++) {
- const struct chreq *chr = &chreq_type_neci0[i];
+ for (i = 0; i < ARRAY_SIZE(chreq_type_neci1); i++) {
+ const struct chreq *chr = &chreq_type_neci1[i];
if ((ra & chr->mask) == chr->val)
return reason_by_chreq[chr->type];
}