Make TRX rf locking more visible
* log administrative state transitions
* log what's caused it
* while at it, mark boolean variable as such
Change-Id: I3e25a19fac4d0b4886d825c9876771b1f66efe58
Related: SYS#3864
diff --git a/src/libbsc/bsc_rf_ctrl.c b/src/libbsc/bsc_rf_ctrl.c
index 20115e1..f4a21b5 100644
--- a/src/libbsc/bsc_rf_ctrl.c
+++ b/src/libbsc/bsc_rf_ctrl.c
@@ -123,7 +123,7 @@
}
}
-static int lock_each_trx(struct gsm_network *net, int lock)
+static int lock_each_trx(struct gsm_network *net, bool lock)
{
struct gsm_bts *bts;
@@ -138,7 +138,7 @@
}
llist_for_each_entry(trx, &bts->trx_list, list) {
- gsm_trx_lock_rf(trx, lock);
+ gsm_trx_lock_rf(trx, lock, "ctrl");
}
}
@@ -245,7 +245,7 @@
static int switch_rf_off(struct osmo_bsc_rf *rf)
{
- lock_each_trx(rf->gsm_network, 1);
+ lock_each_trx(rf->gsm_network, true);
send_signal(rf, S_RF_OFF);
return 0;
@@ -289,7 +289,7 @@
case RF_CMD_ON:
rf->last_state_command = "RF Direct On";
osmo_timer_del(&rf->grace_timeout);
- lock_each_trx(rf->gsm_network, 0);
+ lock_each_trx(rf->gsm_network, false);
send_signal(rf, S_RF_ON);
osmo_timer_schedule(&rf->rf_check, 3, 0);
break;