Gitiles
Code Review Sign In
gerrit.osmocom.org / libosmocore / fb4ce0b029cb52278b8d835c71ce54743226c239
commitfb4ce0b029cb52278b8d835c71ce54743226c239[log] [tgz]
authorVadim Yanitskiy <vyanitskiy@sysmocom.de>Sun Dec 31 16:38:40 2023 +0700
committerVadim Yanitskiy <vyanitskiy@sysmocom.de>Sun Dec 31 16:59:40 2023 +0700
treea25d112d05f09d00231513815c30de0956b82ea1
parent0f59cebf081edc20d8a7b19cb799810446fc2ab3 [diff]
utils: fix -Wsign-compare in definition of OSMO_STRBUF_CHAR_COUNT

We're seeing tons of -Wsign-compare warnings since I merged 0f59cebf:

include/osmocom/core/utils.h: In function 'size_t _osmo_strbuf_char_count(const osmo_strbuf*)':
include/osmocom/core/utils.h:24:29: error: comparison of integer expressions of different
                                    signedness: 'long int' and 'long unsigned int'
                                    [-Werror=sign-compare]
   24 | #define OSMO_MIN(a, b) ((a) >= (b) ? (b) : (a))
      |                         ~~~~^~~~~~
include/osmocom/core/utils.h:309:16: note: in expansion of macro 'OSMO_MIN'
  309 |         return OSMO_MIN(sb->pos - sb->buf, sb->len - 1);
      |                ^~~~~~~~

Interestingly enough, this -Wsign-compare problem has always been the
case, even before commit 0f59cebf.  And somehow this did not show up
when building libosmocore.git, but only when building C++ projects
(osmo-pcu and osmo-trx).

Perhaps it has something to do with how g++ compiles extern "C" code.

Change-Id: I8e396459409e4260b8715f9e890e8972d4609a31
Fixes: 0f59cebf "utils: improve readability of OSMO_STRBUF_CHAR_COUNT"
1 file changed
tree: a25d112d05f09d00231513815c30de0956b82ea1
  1. contrib/
  2. debian/
  3. doc/
  4. include/
  5. m4/
  6. src/
  7. tapset/
  8. tests/
  9. utils/
  10. .checkpatch.conf
  11. .gitignore
  12. .gitreview
  13. .mailmap
  14. configure.ac
  15. COPYING
  16. Doxyfile.codec.in
  17. Doxyfile.coding.in
  18. Doxyfile.core.in
  19. Doxyfile.ctrl.in
  20. Doxyfile.gb.in
  21. Doxyfile.gsm.in
  22. Doxyfile.isdn.in
  23. Doxyfile.sim.in
  24. Doxyfile.usb.in
  25. Doxyfile.vty.in
  26. git-version-gen
  27. libosmocodec.pc.in
  28. libosmocoding.pc.in
  29. libosmocore.pc.in
  30. libosmoctrl.pc.in
  31. libosmogb.pc.in
  32. libosmogsm.pc.in
  33. libosmoisdn.pc.in
  34. libosmosim.pc.in
  35. libosmousb.pc.in
  36. libosmovty.pc.in
  37. Makefile.am
  38. osmo-release.mk
  39. osmo-release.sh
  40. README.md
  41. TODO-RELEASE
README.md

libosmocore - set of Osmocom core libraries

This repository contains a set of C-language libraries that form the core infrastructure of many Osmocom Open Source Mobile Communications projects.

Historically, a lot of this code was developed as part of the OpenBSC project, but which are of a more generic nature and thus useful to (at least) other programs that we develop in the sphere of Free Software / Open Source mobile communications.

There is no clear scope of it. We simply move all shared code between the various Osmocom projects in this library to avoid code duplication.

The libosmocore.git repository build multiple libraries:

  • libosmocore contains some general-purpose functions like select-loop abstraction, message buffers, timers, linked lists
  • libosmovty contains routines related to the interactive command-line interface called VTY
  • libosmogsm contains definitions and helper code related to GSM protocols
  • libosmoctrl contains a shared implementation of the Osmocom control interface
  • libosmogb contains an implementation of the Gb interface with its NS/BSSGP protocols
  • libosmocodec contains an implementation of GSM voice codecs
  • libosmocoding contains an implementation of GSM channel coding
  • libosmosim contains infrastructure to interface SIM/UICC/USIM cards

Homepage

The official homepage of the project is https://osmocom.org/projects/libosmocore/wiki/Libosmocore

GIT Repository

You can clone from the official libosmocore.git repository using

git clone https://gitea.osmocom.org/osmocom/libosmocore

There is a web interface at https://gitea.osmocom.org/osmocom/libosmocore

Documentation

Doxygen-generated API documentation is generated during the build process, but also available online for each of the sub-libraries at https://ftp.osmocom.org/api/latest/libosmocore/

Mailing List

Discussions related to libosmocore are happening on the openbsc@lists.osmocom.org mailing list, please see https://lists.osmocom.org/mailman/listinfo/openbsc for subscription options and the list archive.

Please observe the Osmocom Mailing List Rules when posting.

Contributing

Our coding standards are described at https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards

We us a gerrit based patch submission/review process for managing contributions. Please see https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for more details

The current patch queue for libosmocore can be seen at https://gerrit.osmocom.org/#/q/project:libosmocore+status:open