vty: check for reserved flags in application specific attributes

We agreed to reserve uppercase flag letters for libraries.

Change-Id: If0c332f7c86ff26a4060a14b947445d194a6702e
Related: SYS#4937
diff --git a/src/vty/vty.c b/src/vty/vty.c
index 4d51165..3b723e1 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1809,6 +1809,14 @@
 	for (i = 0; i < ARRAY_SIZE(app_info->usr_attr_letters); i++) {
 		if (app_info->usr_attr_letters[i] == '\0')
 			continue;
+
+		/* Upper case flag letters are reserved for libraries */
+		if (app_info->usr_attr_letters[i] >= 'A' &&
+		    app_info->usr_attr_letters[i] <= 'Z') {
+			fprintf(stderr, "Attribute flag letter '%c' is reserved "
+				"for libraries! Please fix.\n", app_info->usr_attr_letters[i]);
+		}
+
 		for (j = i + 1; j < ARRAY_SIZE(app_info->usr_attr_letters); j++) {
 			if (app_info->usr_attr_letters[j] != app_info->usr_attr_letters[i])
 				continue;